Skip to content

[bug](prepared statement) fix double type value incorrect in legacy planner #36704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xy720 merged 1 commit into from
Jun 24, 2024
Merged

[bug](prepared statement) fix double type value incorrect in legacy planner #36704

xy720 merged 1 commit into from
Jun 24, 2024

Conversation

@xy720
Copy link
Member

@xy720 xy720 commented Jun 22, 2024

Proposed changes

Issue Number: close #xxx

fix double type value incorrect.

@xy720
Copy link
Member Author

xy720 commented Jun 22, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jun 22, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@doris-robot
Copy link

doris-robot commented Jun 22, 2024

TPC-H: Total hot run time: 39782 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 60b9b928f53bc217397c7d650c5859eff2873c25, data reload: false

------ Round 1 ----------------------------------
q1	17615	4372	4295	4295
q2	2026	187	197	187
q3	10464	1150	1070	1070
q4	10191	797	693	693
q5	7462	2661	2611	2611
q6	222	135	135	135
q7	956	637	598	598
q8	9228	2085	2064	2064
q9	9218	6533	6521	6521
q10	9072	3676	3773	3676
q11	481	248	237	237
q12	463	228	220	220
q13	17769	3010	2984	2984
q14	267	229	232	229
q15	524	480	490	480
q16	510	384	378	378
q17	952	684	739	684
q18	7939	7391	7363	7363
q19	5627	1481	1495	1481
q20	666	326	337	326
q21	4964	3217	3942	3217
q22	401	337	333	333
Total cold run time: 117017 ms
Total hot run time: 39782 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4417	4285	4248	4248
q2	377	263	275	263
q3	3026	2982	2972	2972
q4	2041	1744	1743	1743
q5	5644	5504	5487	5487
q6	232	131	132	131
q7	2221	1921	1868	1868
q8	3279	3376	3431	3376
q9	8670	8722	8786	8722
q10	4040	3904	3744	3744
q11	578	496	513	496
q12	839	652	627	627
q13	16911	3150	3171	3150
q14	301	284	261	261
q15	534	488	495	488
q16	498	457	433	433
q17	1804	1538	1524	1524
q18	8094	7888	7579	7579
q19	1783	1541	1573	1541
q20	2126	1927	1888	1888
q21	5168	5039	4882	4882
q22	605	527	574	527
Total cold run time: 73188 ms
Total hot run time: 55950 ms

@doris-robot
Copy link

doris-robot commented Jun 22, 2024

TPC-DS: Total hot run time: 174591 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 60b9b928f53bc217397c7d650c5859eff2873c25, data reload: false

query1	928	382	379	379
query2	6435	2507	2336	2336
query3	6628	216	213	213
query4	19015	17341	17332	17332
query5	3593	475	480	475
query6	233	165	160	160
query7	4586	306	287	287
query8	318	310	300	300
query9	8650	2355	2337	2337
query10	553	297	290	290
query11	10684	10186	10077	10077
query12	119	88	86	86
query13	1655	377	367	367
query14	9959	7725	7524	7524
query15	219	189	193	189
query16	7441	293	264	264
query17	1847	556	524	524
query18	1265	278	270	270
query19	192	156	153	153
query20	91	83	81	81
query21	207	126	124	124
query22	4364	4007	4120	4007
query23	33882	33862	33781	33781
query24	10667	2900	2864	2864
query25	602	370	367	367
query26	715	158	158	158
query27	2385	325	315	315
query28	6118	2132	2109	2109
query29	886	614	643	614
query30	243	156	156	156
query31	965	764	757	757
query32	98	54	67	54
query33	681	291	294	291
query34	896	485	478	478
query35	766	640	644	640
query36	1156	982	982	982
query37	142	77	78	77
query38	2922	2836	2802	2802
query39	890	843	852	843
query40	211	128	127	127
query41	56	52	51	51
query42	123	95	100	95
query43	595	576	554	554
query44	1094	737	739	737
query45	196	168	168	168
query46	1074	753	737	737
query47	1903	1775	1793	1775
query48	406	310	290	290
query49	833	404	408	404
query50	770	398	388	388
query51	6935	6691	6744	6691
query52	103	94	95	94
query53	363	295	288	288
query54	871	452	446	446
query55	74	72	74	72
query56	276	260	269	260
query57	1123	1045	1030	1030
query58	252	239	255	239
query59	3389	3134	3065	3065
query60	300	275	278	275
query61	91	90	96	90
query62	595	460	459	459
query63	321	290	290	290
query64	8576	2248	1744	1744
query65	3138	3097	3128	3097
query66	719	320	326	320
query67	15271	14760	14983	14760
query68	4506	544	553	544
query69	533	432	373	373
query70	1128	1153	1172	1153
query71	384	274	276	274
query72	7766	5539	5610	5539
query73	751	330	329	329
query74	5824	5489	5535	5489
query75	3352	2645	2659	2645
query76	2153	956	923	923
query77	428	299	302	299
query78	10208	9686	9769	9686
query79	2520	514	509	509
query80	1150	475	464	464
query81	540	222	223	222
query82	728	102	104	102
query83	225	165	164	164
query84	234	83	88	83
query85	1679	284	279	279
query86	481	308	326	308
query87	3324	3069	3113	3069
query88	3981	2437	2448	2437
query89	482	397	401	397
query90	1732	193	192	192
query91	125	101	116	101
query92	57	53	49	49
query93	2054	502	511	502
query94	1078	184	186	184
query95	397	314	309	309
query96	592	275	268	268
query97	3192	3049	3087	3049
query98	229	199	194	194
query99	1151	852	846	846
Total cold run time: 265638 ms
Total hot run time: 174591 ms

@doris-robot
Copy link

doris-robot commented Jun 22, 2024

ClickBench: Total hot run time: 30.96 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 60b9b928f53bc217397c7d650c5859eff2873c25, data reload: false

query1	0.04	0.04	0.03
query2	0.09	0.04	0.04
query3	0.22	0.06	0.05
query4	1.68	0.08	0.08
query5	0.50	0.52	0.50
query6	1.13	0.73	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.54	0.51	0.50
query10	0.53	0.52	0.54
query11	0.16	0.11	0.11
query12	0.15	0.13	0.12
query13	0.60	0.59	0.61
query14	0.79	0.78	0.78
query15	0.85	0.81	0.80
query16	0.37	0.37	0.38
query17	1.07	1.01	0.98
query18	0.21	0.25	0.26
query19	1.77	1.74	1.66
query20	0.02	0.01	0.01
query21	15.40	0.65	0.65
query22	4.58	6.47	2.11
query23	18.61	1.45	1.31
query24	2.14	0.23	0.22
query25	0.16	0.09	0.09
query26	0.27	0.18	0.18
query27	0.08	0.08	0.08
query28	13.17	1.02	1.00
query29	12.64	3.40	3.41
query30	0.27	0.06	0.06
query31	2.87	0.39	0.38
query32	3.27	0.46	0.47
query33	2.92	2.86	2.91
query34	17.18	4.46	4.39
query35	4.51	4.54	4.57
query36	0.66	0.46	0.46
query37	0.18	0.16	0.16
query38	0.15	0.15	0.15
query39	0.05	0.03	0.04
query40	0.17	0.14	0.14
query41	0.10	0.05	0.05
query42	0.05	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 110.27 s
Total hot run time: 30.96 s

zclllyybb
zclllyybb reviewed Jun 22, 2024
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/analysis/LiteralExpr.java
break;
case 5: // MYSQL_TYPE_DOUBLE
literalExpr = LiteralExpr.create("0", Type.DOUBLE);
literalExpr.setType(Type.DOUBLE);
Copy link
Contributor

@zclllyybb zclllyybb Jun 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if double should set it type, should we just change DOUBLE branch in LiteralExpr::create?

Copy link
Member Author

@xy720 xy720 Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LiteralExpr::create is used in many places, it's best not to change it.

lide-reed
lide-reed approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 24, 2024

PR approved by anyone and no changes requested.

@xy720 xy720 mentioned this pull request Jun 24, 2024
Merged
@xy720 xy720 merged commit e612702 into apache:master Jun 24, 2024
dataroaring pushed a commit that referenced this pull request Jun 26, 2024
@xy720 @dataroaring
[bug](prepared statement) fix double type value incorrect in legacy p…
a0319f5 
…lanner (#36704)

## Proposed changes

fix double type value incorrect.

<!--Describe your changes.-->
@eldenmoon eldenmoon mentioned this pull request Jun 26, 2024
Merged
eldenmoon added a commit that referenced this pull request Jun 26, 2024
@eldenmoon
[regression-test](prepared statement) fix unstable prepared_stmt_p0 (#…
afedfdd 
…36833)

introduced by #36704
dataroaring pushed a commit that referenced this pull request Jun 28, 2024
@eldenmoon @dataroaring
[regression-test](prepared statement) fix unstable prepared_stmt_p0 (#…
61da3a0 
…36833)

introduced by #36704
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Jul 1, 2024
@eldenmoon
[regression-test](prepared statement) fix unstable prepared_stmt_p0 (a…
73bd6d1 
…pache#36833)

introduced by apache#36704
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request Jul 1, 2024
@eldenmoon
[regression-test](prepared statement) fix unstable prepared_stmt_p0 (a…
a35d4b0 
…pache#36833)

introduced by apache#36704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zclllyybb zclllyybb zclllyybb left review comments

@lide-reed lide-reed lide-reed approved these changes

@cambyzju cambyzju cambyzju approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xy720 @doris-robot @lide-reed @cambyzju @zclllyybb @dataroaring