[Bug] Fix bug that runningTxnNum does not equal to the real running txn num #3674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xn num. This is because the logic for modifying the number of things running is wrong. Because we did not persist the previous status(preStatus) of a transaction. Therefore, when replaying the metadata log, we cannot decide whether to modify the `runningTxnNum` value based on `preStatus`. This info is lost.
morningman
added
kind/fix
acelyc111
pushed a commit
to acelyc111/incubator-doris
that referenced
this pull request
Jan 20, 2021
…xn num. (apache#3674) This is because the logic for modifying the number of things running is wrong. Because we did not persist the previous status(preStatus) of a transaction. Therefore, when replaying the metadata log, we cannot decide whether to modify the `runningTxnNum` value based on `preStatus`. This info is lost.
BiteTheDDDDt
pushed a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because the logic for modifying the number of txn running is wrong.
Because we did not persist the previous status(preStatus) of a transaction.
Therefore, when replaying the metadata log, we cannot decide whether to modify
the
runningTxnNumvalue based onpreStatus. This info is lost.Fix #3673