Skip to content

[fix](array)fix array_except/union for left const return only one row result #36776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldenmoon merged 1 commit into from
Jun 25, 2024
Merged

[fix](array)fix array_except/union for left const return only one row result #36776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion be/src/vec/functions/array/function_array_set.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,11 @@ struct ArraySetImpl {
constexpr auto execute_left_column_first = Impl::Action::execute_left_column_first;
size_t current = 0;
Impl impl;
for (size_t row = 0; row < left_data.offsets_ptr->size(); ++row) {
size_t row_size = left_data.offsets_ptr->size();
Copy link
Contributor

@zhiqiang-hhhh zhiqiang-hhhh Jun 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if right const

Copy link
Contributor Author

@amorynan amorynan Jun 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right and left is all not const ==> left_data.offsets_ptr->size()
right const && left is not const ==> left_data.offsets_ptr->size()
right is not const && left is const ==> right.offsets_ptr->size()
right and left is all const ==> left_data.offsets_ptr->size()

if constexpr (LCONST) {
row_size = right_data.offsets_ptr->size();
}
for (size_t row = 0; row < row_size; ++row) {
size_t count = 0;
size_t left_off = (*left_data.offsets_ptr)[index_check_const(row, LCONST) - 1];
size_t left_len = (*left_data.offsets_ptr)[index_check_const(row, LCONST)] - left_off;
Expand Down
12 changes: 12 additions & 0 deletions regression-test/data/query_p0/sql_functions/array_functions/test_array_functions.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1659,14 +1659,26 @@
10005 [10005, null, null] [null, 3, 10005, 2, 1]
10006 [60002, 60002, 60003, null, 60005] [null, 3, 60002, 60005, 60003, 2, 1]

-- !select_union_left_const --
10005 [10005, null, null] [null, 3, 10005, 2, 1]
10006 [60002, 60002, 60003, null, 60005] [null, 3, 60002, 60005, 60003, 2, 1]

-- !select_except --
10005 [10005, null, null] [10005, null]
10006 [60002, 60002, 60003, null, 60005] [60002, 60003, null, 60005]

-- !select_except_left_const --
10005 [10005, null, null] [1, 2, 3]
10006 [60002, 60002, 60003, null, 60005] [1, 2, 3]

-- !select_intersect --
10005 [10005, null, null] [null]
10006 [60002, 60002, 60003, null, 60005] [null]

-- !select_intersect_left_const --
10005 [10005, null, null] [null]
10006 [60002, 60002, 60003, null, 60005] [null]

-- !select_array_datetimev2_1 --
1 ["2023-01-19 18:11:11.111", "2023-01-19 18:22:22.222", "2023-01-19 18:33:33.333"] ["2023-01-19 18:22:22.222", "2023-01-19 18:33:33.333", "2023-01-19 18:44:44.444"] ["2023-01-19 18:11:11.111111", "2023-01-19 18:22:22.222222", "2023-01-19 18:33:33.333333"]

Expand Down
3 changes: 3 additions & 0 deletions regression-test/suites/query_p0/sql_functions/array_functions/test_array_functions.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,11 @@ suite("test_array_functions") {
sql """ insert into ${tableName3} values (10006,'bbbbb',[60002,60002,60003,null,60005]) """

qt_select_union "select class_id, student_ids, array_union(student_ids,[1,2,3]) from ${tableName3} order by class_id;"
qt_select_union_left_const "select class_id, student_ids, array_union([1,2,3], student_ids,[1,2,3]) from ${tableName3} order by class_id;"
qt_select_except "select class_id, student_ids, array_except(student_ids,[1,2,3]) from ${tableName3} order by class_id;"
qt_select_except_left_const "select class_id, student_ids, array_except([1,2,3], student_ids) from ${tableName3} order by class_id;"
qt_select_intersect "select class_id, student_ids, array_intersect(student_ids,[1,2,3,null]) from ${tableName3} order by class_id;"
qt_select_intersect_left_const "select class_id, student_ids, array_intersect([1,2,3,null], student_ids) from ${tableName3} order by class_id;"

def tableName4 = "tbl_test_array_datetimev2_functions"

Expand Down