Skip to content

[Bug](cast) fix cast string to int return wrong result #36788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HappenLee merged 2 commits into from
Jun 28, 2024
Merged

[Bug](cast) fix cast string to int return wrong result #36788

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6ed370
[Bug](cast) fix cast string to int return wrong result
zhangstar333 Jun 25, 2024
1b12955
add test case
zhangstar333 Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions be/src/util/string_parser.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,11 @@ T StringParser::string_to_int_internal(const char* __restrict s, int len, ParseR
[[fallthrough]];
case '+':
++i;
// only one '+'/'-' char, so could return failure directly
if (UNLIKELY(len == 1)) {
*result = PARSE_FAILURE;
return 0;
}
}

// This is the fast path where the string cannot overflow.
Expand Down
12 changes: 12 additions & 0 deletions regression-test/data/datatype_p0/json/json_cast.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,15 @@ true
-- !sql14 --
1.1111

-- !sql15 --
\N

-- !sql16 --
\N

-- !sql17 --
\N

-- !sql18 --
\N

6 changes: 5 additions & 1 deletion regression-test/suites/datatype_p0/json/json_cast.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
// under the License.

suite("test_json_type_cast", "p0") {
sql """ set enable_fold_constant_by_be = false;"""
qt_sql1 "SELECT CAST(CAST(10 AS JSON) as INT)"
qt_sql2 "SELECT CAST(CAST(102423 AS JSON) as TINYINT)"
qt_sql3 "SELECT CAST(CAST(102423 AS JSON) as SMALLINT)"
Expand All @@ -32,4 +31,9 @@ suite("test_json_type_cast", "p0") {
qt_sql12 """select cast("111111" as json)"""
qt_sql13 """select cast(111111 as json)"""
qt_sql14 """select cast(1.1111 as json)"""

qt_sql15 """select cast("+" as int);"""
qt_sql16 """select cast("-" as int);"""
qt_sql17 """select cast("a" as int);"""
qt_sql18 """select cast("/" as int);"""
}