Skip to content

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Jun 25, 2024

There is a bug of direct select mv with specified partitions. Planner will fail to find the mv column name. Because we need to create the LogicalOlapScan object using the given mv instead of the base table.

mysql> SELECT mv_id from part8 index mv1 partition p1;
ERROR 1105 (HY000): errCode = 2, detailMessage = Unknown column 'mv_id' in 'table list' in PROJECT clause

This pr is to fix this.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Jibing-Li Jibing-Li marked this pull request as ready for review June 25, 2024 10:13
@morrySnow
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 25, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 39619 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4aea2557b64ed0ace33ef3260a0510166cfd3f22, data reload: false

------ Round 1 ----------------------------------
q1	17603	4243	4256	4243
q2	2019	191	188	188
q3	10468	1140	1127	1127
q4	10178	781	745	745
q5	7461	2665	2592	2592
q6	217	134	131	131
q7	949	596	601	596
q8	9239	2061	2069	2061
q9	8871	6475	6427	6427
q10	8903	3726	3756	3726
q11	457	240	240	240
q12	518	227	221	221
q13	18744	3074	3140	3074
q14	263	228	238	228
q15	508	487	483	483
q16	534	396	385	385
q17	976	677	751	677
q18	8092	7383	7291	7291
q19	6298	1456	1520	1456
q20	632	311	311	311
q21	4919	3088	3900	3088
q22	398	341	329	329
Total cold run time: 118247 ms
Total hot run time: 39619 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4381	4224	4214	4214
q2	364	262	259	259
q3	2989	2906	2906	2906
q4	2001	1679	1766	1679
q5	5562	5459	5450	5450
q6	224	139	123	123
q7	2195	1860	1825	1825
q8	3242	3400	3417	3400
q9	8688	8691	8784	8691
q10	4119	3789	3787	3787
q11	607	506	501	501
q12	803	649	650	649
q13	16350	3133	3146	3133
q14	304	274	280	274
q15	537	474	473	473
q16	504	433	443	433
q17	1802	1508	1508	1508
q18	8004	7856	7716	7716
q19	1802	1645	1511	1511
q20	3113	1840	1889	1840
q21	5030	4987	4875	4875
q22	604	567	577	567
Total cold run time: 73225 ms
Total hot run time: 55814 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173558 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4aea2557b64ed0ace33ef3260a0510166cfd3f22, data reload: false

query1	900	383	379	379
query2	6431	2378	2278	2278
query3	6621	210	218	210
query4	18831	17150	17348	17150
query5	3639	492	462	462
query6	232	161	161	161
query7	4587	301	291	291
query8	302	268	286	268
query9	8784	2412	2423	2412
query10	566	318	283	283
query11	10401	9982	9999	9982
query12	113	85	84	84
query13	1630	368	383	368
query14	10683	7048	7170	7048
query15	228	186	186	186
query16	7376	275	260	260
query17	1413	525	509	509
query18	1836	270	280	270
query19	194	155	160	155
query20	88	83	84	83
query21	202	133	135	133
query22	4302	3967	3891	3891
query23	33922	33584	33671	33584
query24	11183	3007	2963	2963
query25	609	401	397	397
query26	714	160	169	160
query27	2261	328	336	328
query28	6021	2149	2159	2149
query29	896	686	644	644
query30	261	165	167	165
query31	979	764	766	764
query32	103	55	61	55
query33	787	307	310	307
query34	1007	509	487	487
query35	778	670	628	628
query36	1136	970	992	970
query37	144	80	80	80
query38	2921	2870	2894	2870
query39	877	865	849	849
query40	217	132	129	129
query41	56	53	55	53
query42	107	100	109	100
query43	582	536	537	536
query44	1182	746	731	731
query45	196	167	162	162
query46	1061	713	710	710
query47	1836	1760	1745	1745
query48	375	289	295	289
query49	843	409	422	409
query50	778	389	385	385
query51	6902	6742	6813	6742
query52	112	90	92	90
query53	358	298	296	296
query54	910	461	446	446
query55	75	74	96	74
query56	291	267	262	262
query57	1130	1053	1077	1053
query58	246	268	267	267
query59	3371	3110	3494	3110
query60	297	271	279	271
query61	94	88	101	88
query62	615	456	451	451
query63	324	296	301	296
query64	8523	2249	1767	1767
query65	3179	3085	3105	3085
query66	772	345	325	325
query67	15309	15009	14812	14812
query68	6264	553	539	539
query69	615	522	469	469
query70	1215	1094	1170	1094
query71	492	285	280	280
query72	7745	5612	5372	5372
query73	789	322	320	320
query74	5786	5491	5380	5380
query75	3929	2683	2674	2674
query76	3915	952	995	952
query77	665	324	329	324
query78	10499	9982	9681	9681
query79	2004	515	513	513
query80	1934	457	459	457
query81	557	214	216	214
query82	762	103	106	103
query83	278	177	192	177
query84	255	89	80	80
query85	1236	289	269	269
query86	455	289	327	289
query87	3235	3049	3030	3030
query88	4049	2363	2349	2349
query89	490	386	374	374
query90	1713	186	191	186
query91	135	99	125	99
query92	60	49	51	49
query93	2223	508	515	508
query94	1018	183	185	183
query95	395	311	315	311
query96	585	271	266	266
query97	3182	3051	3058	3051
query98	215	198	190	190
query99	1249	833	828	828
Total cold run time: 271643 ms
Total hot run time: 173558 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.75 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4aea2557b64ed0ace33ef3260a0510166cfd3f22, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.05
query3	0.22	0.05	0.05
query4	1.69	0.10	0.08
query5	0.50	0.48	0.49
query6	1.14	0.72	0.71
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.55	0.49	0.50
query10	0.55	0.54	0.54
query11	0.15	0.11	0.12
query12	0.15	0.11	0.12
query13	0.59	0.58	0.59
query14	0.77	0.78	0.79
query15	0.83	0.81	0.81
query16	0.37	0.37	0.36
query17	0.96	1.00	1.05
query18	0.23	0.23	0.24
query19	1.88	1.82	1.81
query20	0.01	0.01	0.02
query21	15.44	0.65	0.65
query22	4.10	7.11	2.13
query23	18.34	1.46	1.21
query24	2.12	0.21	0.23
query25	0.14	0.09	0.08
query26	0.26	0.17	0.18
query27	0.07	0.08	0.08
query28	13.16	1.03	1.00
query29	12.64	3.27	3.25
query30	0.25	0.06	0.05
query31	2.88	0.39	0.39
query32	3.28	0.48	0.47
query33	2.83	2.97	2.88
query34	16.98	4.39	4.41
query35	4.57	4.45	4.49
query36	0.65	0.46	0.46
query37	0.19	0.15	0.15
query38	0.15	0.15	0.15
query39	0.04	0.04	0.03
query40	0.17	0.14	0.15
query41	0.10	0.05	0.06
query42	0.05	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.22 s
Total hot run time: 30.75 s

@Jibing-Li
Copy link
Contributor Author

run p0

@Jibing-Li
Copy link
Contributor Author

run feut

@Jibing-Li
Copy link
Contributor Author

run external

@Jibing-Li
Copy link
Contributor Author

run p0

@Jibing-Li Jibing-Li merged commit 0a75e3b into apache:master Jun 26, 2024
@Jibing-Li Jibing-Li deleted the mv branch June 26, 2024 03:59
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Jun 28, 2024
…#36817)

There is a bug of direct select mv with specified partitions. Planner
will fail to find the mv column name. Because we need to create the
LogicalOlapScan object using the given mv instead of the base table.
```
mysql> SELECT mv_id from part8 index mv1 partition p1;
ERROR 1105 (HY000): errCode = 2, detailMessage = Unknown column 'mv_id' in 'table list' in PROJECT clause
```
This pr is to fix this.
Jibing-Li added a commit that referenced this pull request Jun 28, 2024
#36982)

There is a bug of direct select mv with specified partitions. Planner
will fail to find the mv column name. Because we need to create the
LogicalOlapScan object using the given mv instead of the base table.
```
mysql> SELECT mv_id from part8 index mv1 partition p1;
ERROR 1105 (HY000): errCode = 2, detailMessage = Unknown column 'mv_id' in 'table list' in PROJECT clause
```
This pr is to fix this.

backport: #36817
dataroaring pushed a commit that referenced this pull request Jun 28, 2024
There is a bug of direct select mv with specified partitions. Planner
will fail to find the mv column name. Because we need to create the
LogicalOlapScan object using the given mv instead of the base table.
```
mysql> SELECT mv_id from part8 index mv1 partition p1;
ERROR 1105 (HY000): errCode = 2, detailMessage = Unknown column 'mv_id' in 'table list' in PROJECT clause
```
This pr is to fix this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants