Skip to content

[regression-test](prepared statement) fix unstable prepared_stmt_p0 #36833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldenmoon merged 1 commit into from
Jun 26, 2024
Merged

[regression-test](prepared statement) fix unstable prepared_stmt_p0 #36833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions regression-test/suites/prepared_stmt_p0/prepared_stmt.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ suite("test_prepared_stmt", "nonConcurrent") {

qt_sql """select * from ${tableName} order by 1, 2, 3"""
qt_sql """select * from ${tableName} order by 1, 2, 3"""
sql "set global max_prepared_stmt_count = 10000"

def stmt_read = prepareStatement "select * from ${tableName} where k1 = ? order by k1"
assertEquals(stmt_read.class, com.mysql.cj.jdbc.ServerPreparedStatement);
Expand Down Expand Up @@ -149,7 +150,7 @@ suite("test_prepared_stmt", "nonConcurrent") {

sql """insert into mytable1 values(2,1,'user1',null);"""

sql "set experimental_enable_nereids_planner = false"
// sql "set experimental_enable_nereids_planner = false"

stmt_read = prepareStatement "SELECT *, ? FROM (select *, ? from mytable1 where pv is null) AS `SpotfireCustomQuery1` WHERE 1 = 1"
assertEquals(stmt_read.class, com.mysql.cj.jdbc.ServerPreparedStatement);
Expand All @@ -159,9 +160,9 @@ suite("test_prepared_stmt", "nonConcurrent") {
stmt_read.setString(1, "1111111")
stmt_read.setString(2, "1111111")
qe_select7 stmt_read
stmt_read.close()
// stmt_read.close()

sql "set experimental_enable_nereids_planner = true"
// sql "set experimental_enable_nereids_planner = true"

stmt_read.setString(1, "xxxlalala")
stmt_read.setDouble(2, 1234.1111)
Expand Down
2 changes: 0 additions & 2 deletions regression-test/suites/prepared_stmt_p0/prepared_stmt_in_list.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ suite("test_prepared_stmt_in_list", "nonConcurrent") {
def user = context.config.jdbcUser
def password = context.config.jdbcPassword
def url = context.config.jdbcUrl + "&useServerPrepStmts=true"
sql "set global enable_server_side_prepared_statement = true"
def result1 = connect(user=user, password=password, url=url) {
sql """DROP TABLE IF EXISTS ${tableName} """
sql """
Expand Down Expand Up @@ -190,5 +189,4 @@ suite("test_prepared_stmt_in_list", "nonConcurrent") {
stmt_read10.setString(5, '6022-01-01 11:30:38')
qe_stmt_read10_2 stmt_read10
}
sql "set global enable_server_side_prepared_statement = false"
}