[Fix](autoinc) Hanlde the processing of auto_increment column on exchange node rather than on TabletWriter when using TABLET_SINK_SHUFFLE_PARTITIONED
#36836
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| return DecimalType(value); | ||
| } | ||
|
|
||
| Status OlapTableBlockConvertor::_validate_column(RuntimeState* state, const TypeDescriptor& type, |
There was a problem hiding this comment.
warning: function '_validate_column' has cognitive complexity of 336 (threshold 50) [readability-function-cognitive-complexity]
Status OlapTableBlockConvertor::_validate_column(RuntimeState* state, const TypeDescriptor& type,
^Additional context
be/src/vec/sink/vtablet_block_convertor.cpp:191: +1
DCHECK((rows == nullptr) || (rows->size() == row_count));
^be/src/vec/sink/vtablet_block_convertor.cpp:193: nesting level increased to 1
auto set_invalid_and_append_error_msg = [&](int row) {
^be/src/vec/sink/vtablet_block_convertor.cpp:206: +1, including nesting penalty of 0, nesting level increased to 1
auto& real_column_ptr = column_ptr == nullptr ? column : (column_ptr->get_nested_column_ptr());
^be/src/vec/sink/vtablet_block_convertor.cpp:207: +1, including nesting penalty of 0, nesting level increased to 1
auto null_map = column_ptr == nullptr ? nullptr : column_ptr->get_null_map_data().data();
^be/src/vec/sink/vtablet_block_convertor.cpp:208: nesting level increased to 1
auto need_to_validate = [&null_map, this](size_t j, size_t row) {
^be/src/vec/sink/vtablet_block_convertor.cpp:212: nesting level increased to 1
auto string_column_checker = [&](const ColumnString* column_string) {
^be/src/vec/sink/vtablet_block_convertor.cpp:215: +2, including nesting penalty of 1, nesting level increased to 2
if (type.len > 0) {
^be/src/vec/sink/vtablet_block_convertor.cpp:221: +2, including nesting penalty of 1, nesting level increased to 2
for (int j = 0; j < row_count; ++j) {
^be/src/vec/sink/vtablet_block_convertor.cpp:225: +2, including nesting penalty of 1, nesting level increased to 2
if (invalid_count) {
^be/src/vec/sink/vtablet_block_convertor.cpp:226: +3, including nesting penalty of 2, nesting level increased to 3
for (size_t j = 0; j < row_count; ++j) {
^be/src/vec/sink/vtablet_block_convertor.cpp:227: +4, including nesting penalty of 3, nesting level increased to 4
auto row = rows ? (*rows)[j] : j;
^be/src/vec/sink/vtablet_block_convertor.cpp:228: +4, including nesting penalty of 3, nesting level increased to 4
if (need_to_validate(j, row)) {
^be/src/vec/sink/vtablet_block_convertor.cpp:231: +5, including nesting penalty of 4, nesting level increased to 5
if (invalid) {
^be/src/vec/sink/vtablet_block_convertor.cpp:232: +6, including nesting penalty of 5, nesting level increased to 6
if (str_val.size > type.len) {
^be/src/vec/sink/vtablet_block_convertor.cpp:239: +1, nesting level increased to 6
} else if (str_val.size > limit) {
^be/src/vec/sink/vtablet_block_convertor.cpp:249: +6, including nesting penalty of 5, nesting level increased to 6
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row));
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:249: +7, including nesting penalty of 6, nesting level increased to 7
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row));
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:257: +1, including nesting penalty of 0, nesting level increased to 1
switch (type.type) {
^be/src/vec/sink/vtablet_block_convertor.cpp:263: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(string_column_checker(column_string));
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:263: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(string_column_checker(column_string));
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:269: +2, including nesting penalty of 1, nesting level increased to 2
for (size_t j = 0; j < row_count; ++j) {
^be/src/vec/sink/vtablet_block_convertor.cpp:270: +3, including nesting penalty of 2, nesting level increased to 3
if (!_filter_map[j]) {
^be/src/vec/sink/vtablet_block_convertor.cpp:271: +4, including nesting penalty of 3, nesting level increased to 4
if (is_nullable && column_ptr && column_ptr->is_null_at(j)) {
^be/src/vec/sink/vtablet_block_convertor.cpp:271: +1
if (is_nullable && column_ptr && column_ptr->is_null_at(j)) {
^be/src/vec/sink/vtablet_block_convertor.cpp:276: +4, including nesting penalty of 3, nesting level increased to 4
if (invalid) {
^be/src/vec/sink/vtablet_block_convertor.cpp:279: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(set_invalid_and_append_error_msg(j));
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:279: +6, including nesting penalty of 5, nesting level increased to 6
RETURN_IF_ERROR(set_invalid_and_append_error_msg(j));
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:291: +2, including nesting penalty of 1, nesting level increased to 2
for (size_t j = 0; j < row_count; ++j) {
^be/src/vec/sink/vtablet_block_convertor.cpp:292: +3, including nesting penalty of 2, nesting level increased to 3
auto row = rows ? (*rows)[j] : j;
^be/src/vec/sink/vtablet_block_convertor.cpp:293: +3, including nesting penalty of 2, nesting level increased to 3
if (need_to_validate(j, row)) {
^be/src/vec/sink/vtablet_block_convertor.cpp:298: +4, including nesting penalty of 3, nesting level increased to 4
if (dec_val.greater_than_scale(type.scale)) {
^be/src/vec/sink/vtablet_block_convertor.cpp:302: +5, including nesting penalty of 4, nesting level increased to 5
if (code != E_DEC_OK) {
^be/src/vec/sink/vtablet_block_convertor.cpp:308: +4, including nesting penalty of 3, nesting level increased to 4
if (dec_val > max_decimalv2 || dec_val < min_decimalv2) {
^be/src/vec/sink/vtablet_block_convertor.cpp:308: +1
if (dec_val > max_decimalv2 || dec_val < min_decimalv2) {
^be/src/vec/sink/vtablet_block_convertor.cpp:318: +4, including nesting penalty of 3, nesting level increased to 4
if (invalid) {
^be/src/vec/sink/vtablet_block_convertor.cpp:319: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row));
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:319: +6, including nesting penalty of 5, nesting level increased to 6
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row));
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:357: +2, including nesting penalty of 1, nesting level increased to 2
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^be/src/vec/sink/vtablet_block_convertor.cpp:333: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
for (int j = 0; j < row_count; ++j) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:357: +1
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^be/src/vec/sink/vtablet_block_convertor.cpp:335: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
invalid_count += dec_val > max_decimal || dec_val < min_decimal; \
^be/src/vec/sink/vtablet_block_convertor.cpp:357: +2, including nesting penalty of 1, nesting level increased to 2
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^be/src/vec/sink/vtablet_block_convertor.cpp:337: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (invalid_count) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:357: +3, including nesting penalty of 2, nesting level increased to 3
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^be/src/vec/sink/vtablet_block_convertor.cpp:338: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
for (size_t j = 0; j < row_count; ++j) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:357: +4, including nesting penalty of 3, nesting level increased to 4
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^be/src/vec/sink/vtablet_block_convertor.cpp:339: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
auto row = rows ? (*rows)[j] : j; \
^be/src/vec/sink/vtablet_block_convertor.cpp:357: +4, including nesting penalty of 3, nesting level increased to 4
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^be/src/vec/sink/vtablet_block_convertor.cpp:340: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (need_to_validate(j, row)) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:357: +5, including nesting penalty of 4, nesting level increased to 5
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^be/src/vec/sink/vtablet_block_convertor.cpp:343: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (dec_val > max_decimal || dec_val < min_decimal) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:357: +1
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^be/src/vec/sink/vtablet_block_convertor.cpp:343: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (dec_val > max_decimal || dec_val < min_decimal) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:357: +5, including nesting penalty of 4, nesting level increased to 5
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^be/src/vec/sink/vtablet_block_convertor.cpp:351: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (invalid) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:357: +6, including nesting penalty of 5, nesting level increased to 6
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^be/src/vec/sink/vtablet_block_convertor.cpp:352: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:357: +7, including nesting penalty of 6, nesting level increased to 7
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal32);
^be/src/vec/sink/vtablet_block_convertor.cpp:352: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:361: +2, including nesting penalty of 1, nesting level increased to 2
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^be/src/vec/sink/vtablet_block_convertor.cpp:333: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
for (int j = 0; j < row_count; ++j) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:361: +1
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^be/src/vec/sink/vtablet_block_convertor.cpp:335: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
invalid_count += dec_val > max_decimal || dec_val < min_decimal; \
^be/src/vec/sink/vtablet_block_convertor.cpp:361: +2, including nesting penalty of 1, nesting level increased to 2
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^be/src/vec/sink/vtablet_block_convertor.cpp:337: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (invalid_count) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:361: +3, including nesting penalty of 2, nesting level increased to 3
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^be/src/vec/sink/vtablet_block_convertor.cpp:338: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
for (size_t j = 0; j < row_count; ++j) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:361: +4, including nesting penalty of 3, nesting level increased to 4
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^be/src/vec/sink/vtablet_block_convertor.cpp:339: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
auto row = rows ? (*rows)[j] : j; \
^be/src/vec/sink/vtablet_block_convertor.cpp:361: +4, including nesting penalty of 3, nesting level increased to 4
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^be/src/vec/sink/vtablet_block_convertor.cpp:340: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (need_to_validate(j, row)) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:361: +5, including nesting penalty of 4, nesting level increased to 5
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^be/src/vec/sink/vtablet_block_convertor.cpp:343: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (dec_val > max_decimal || dec_val < min_decimal) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:361: +1
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^be/src/vec/sink/vtablet_block_convertor.cpp:343: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (dec_val > max_decimal || dec_val < min_decimal) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:361: +5, including nesting penalty of 4, nesting level increased to 5
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^be/src/vec/sink/vtablet_block_convertor.cpp:351: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (invalid) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:361: +6, including nesting penalty of 5, nesting level increased to 6
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^be/src/vec/sink/vtablet_block_convertor.cpp:352: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:361: +7, including nesting penalty of 6, nesting level increased to 7
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal64);
^be/src/vec/sink/vtablet_block_convertor.cpp:352: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:365: +2, including nesting penalty of 1, nesting level increased to 2
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^be/src/vec/sink/vtablet_block_convertor.cpp:333: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
for (int j = 0; j < row_count; ++j) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:365: +1
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^be/src/vec/sink/vtablet_block_convertor.cpp:335: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
invalid_count += dec_val > max_decimal || dec_val < min_decimal; \
^be/src/vec/sink/vtablet_block_convertor.cpp:365: +2, including nesting penalty of 1, nesting level increased to 2
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^be/src/vec/sink/vtablet_block_convertor.cpp:337: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (invalid_count) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:365: +3, including nesting penalty of 2, nesting level increased to 3
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^be/src/vec/sink/vtablet_block_convertor.cpp:338: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
for (size_t j = 0; j < row_count; ++j) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:365: +4, including nesting penalty of 3, nesting level increased to 4
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^be/src/vec/sink/vtablet_block_convertor.cpp:339: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
auto row = rows ? (*rows)[j] : j; \
^be/src/vec/sink/vtablet_block_convertor.cpp:365: +4, including nesting penalty of 3, nesting level increased to 4
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^be/src/vec/sink/vtablet_block_convertor.cpp:340: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (need_to_validate(j, row)) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:365: +5, including nesting penalty of 4, nesting level increased to 5
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^be/src/vec/sink/vtablet_block_convertor.cpp:343: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (dec_val > max_decimal || dec_val < min_decimal) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:365: +1
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^be/src/vec/sink/vtablet_block_convertor.cpp:343: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (dec_val > max_decimal || dec_val < min_decimal) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:365: +5, including nesting penalty of 4, nesting level increased to 5
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^be/src/vec/sink/vtablet_block_convertor.cpp:351: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (invalid) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:365: +6, including nesting penalty of 5, nesting level increased to 6
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^be/src/vec/sink/vtablet_block_convertor.cpp:352: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:365: +7, including nesting penalty of 6, nesting level increased to 7
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal128V3);
^be/src/vec/sink/vtablet_block_convertor.cpp:352: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:369: +2, including nesting penalty of 1, nesting level increased to 2
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^be/src/vec/sink/vtablet_block_convertor.cpp:333: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
for (int j = 0; j < row_count; ++j) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:369: +1
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^be/src/vec/sink/vtablet_block_convertor.cpp:335: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
invalid_count += dec_val > max_decimal || dec_val < min_decimal; \
^be/src/vec/sink/vtablet_block_convertor.cpp:369: +2, including nesting penalty of 1, nesting level increased to 2
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^be/src/vec/sink/vtablet_block_convertor.cpp:337: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (invalid_count) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:369: +3, including nesting penalty of 2, nesting level increased to 3
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^be/src/vec/sink/vtablet_block_convertor.cpp:338: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
for (size_t j = 0; j < row_count; ++j) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:369: +4, including nesting penalty of 3, nesting level increased to 4
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^be/src/vec/sink/vtablet_block_convertor.cpp:339: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
auto row = rows ? (*rows)[j] : j; \
^be/src/vec/sink/vtablet_block_convertor.cpp:369: +4, including nesting penalty of 3, nesting level increased to 4
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^be/src/vec/sink/vtablet_block_convertor.cpp:340: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (need_to_validate(j, row)) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:369: +5, including nesting penalty of 4, nesting level increased to 5
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^be/src/vec/sink/vtablet_block_convertor.cpp:343: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (dec_val > max_decimal || dec_val < min_decimal) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:369: +1
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^be/src/vec/sink/vtablet_block_convertor.cpp:343: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (dec_val > max_decimal || dec_val < min_decimal) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:369: +5, including nesting penalty of 4, nesting level increased to 5
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^be/src/vec/sink/vtablet_block_convertor.cpp:351: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
if (invalid) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:369: +6, including nesting penalty of 5, nesting level increased to 6
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^be/src/vec/sink/vtablet_block_convertor.cpp:352: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:369: +7, including nesting penalty of 6, nesting level increased to 7
CHECK_VALIDATION_FOR_DECIMALV3(vectorized::Decimal256);
^be/src/vec/sink/vtablet_block_convertor.cpp:352: expanded from macro 'CHECK_VALIDATION_FOR_DECIMALV3'
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row)); \
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:380: +2, including nesting penalty of 1, nesting level increased to 2
for (size_t r = 0; r < row_count; ++r) {
^be/src/vec/sink/vtablet_block_convertor.cpp:381: +3, including nesting penalty of 2, nesting level increased to 3
for (size_t c = offsets[r - 1]; c < offsets[r]; ++c) {
^be/src/vec/sink/vtablet_block_convertor.cpp:386: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(_validate_column(state, nested_type, type.contains_nulls[0], false,
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:386: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_validate_column(state, nested_type, type.contains_nulls[0], false,
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:398: +2, including nesting penalty of 1, nesting level increased to 2
for (size_t r = 0; r < row_count; ++r) {
^be/src/vec/sink/vtablet_block_convertor.cpp:399: +3, including nesting penalty of 2, nesting level increased to 3
for (size_t c = offsets[r - 1]; c < offsets[r]; ++c) {
^be/src/vec/sink/vtablet_block_convertor.cpp:404: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(_validate_column(state, key_type, type.contains_nulls[0], false,
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:404: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_validate_column(state, key_type, type.contains_nulls[0], false,
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:407: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(_validate_column(state, val_type, type.contains_nulls[1], false,
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:407: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_validate_column(state, val_type, type.contains_nulls[1], false,
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:417: +2, including nesting penalty of 1, nesting level increased to 2
for (size_t sc = 0; sc < column_struct->tuple_size(); ++sc) {
^be/src/vec/sink/vtablet_block_convertor.cpp:418: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_validate_column(state, type.children[sc], type.contains_nulls[sc],
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:418: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(_validate_column(state, type.children[sc], type.contains_nulls[sc],
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:427: +2, including nesting penalty of 1, nesting level increased to 2
if (column_string) {
^be/src/vec/sink/vtablet_block_convertor.cpp:428: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(string_column_checker(column_string));
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:428: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(string_column_checker(column_string));
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^be/src/vec/sink/vtablet_block_convertor.cpp:440: +1, including nesting penalty of 0, nesting level increased to 1
if ((!is_nullable || type == TYPE_OBJECT) && column_ptr && !is_auto_inc) {
^be/src/vec/sink/vtablet_block_convertor.cpp:440: +1
if ((!is_nullable || type == TYPE_OBJECT) && column_ptr && !is_auto_inc) {
^be/src/vec/sink/vtablet_block_convertor.cpp:440: +1
if ((!is_nullable || type == TYPE_OBJECT) && column_ptr && !is_auto_inc) {
^be/src/vec/sink/vtablet_block_convertor.cpp:441: +2, including nesting penalty of 1, nesting level increased to 2
for (int j = 0; j < row_count; ++j) {
^be/src/vec/sink/vtablet_block_convertor.cpp:442: +3, including nesting penalty of 2, nesting level increased to 3
auto row = rows ? (*rows)[j] : j;
^be/src/vec/sink/vtablet_block_convertor.cpp:443: +3, including nesting penalty of 2, nesting level increased to 3
if (null_map[j] && !_filter_map[row]) {
^be/src/vec/sink/vtablet_block_convertor.cpp:446: +4, including nesting penalty of 3, nesting level increased to 4
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row));
^be/src/common/status.h:626: expanded from macro 'RETURN_IF_ERROR'
do { \
^be/src/vec/sink/vtablet_block_convertor.cpp:446: +5, including nesting penalty of 4, nesting level increased to 5
RETURN_IF_ERROR(set_invalid_and_append_error_msg(row));
^be/src/common/status.h:628: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \
^
TPC-H: Total hot run time: 39641 ms |
TPC-DS: Total hot run time: 170474 ms |
ClickBench: Total hot run time: 30.64 s |
bobhan1
changed the title
OlapTableBlockConvertorTABLET_SINK_SHUFFLE_PARTITIONED
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run performance |
TPC-H: Total hot run time: 40646 ms |
TPC-DS: Total hot run time: 173205 ms |
ClickBench: Total hot run time: 30.8 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39646 ms |
TPC-DS: Total hot run time: 174096 ms |
ClickBench: Total hot run time: 30.43 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39521 ms |
TPC-DS: Total hot run time: 170635 ms |
ClickBench: Total hot run time: 30.54 s |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39991 ms |
TPC-DS: Total hot run time: 174340 ms |
ClickBench: Total hot run time: 30.45 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…ange node rather than on TabletWriter when using `TABLET_SINK_SHUFFLE_PARTITIONED` (#36836) ## Proposed changes Issue Number: close #36638 #30914 add partition tablet sink shuffle and the processing of auto_increment column should be handled on exchange node raher than TabletWriter when using partition tablet sink shuffle. branch-2.1-pick: #37029
4 participants
Proposed changes
Issue Number: close #36638
#30914 add partition tablet sink shuffle and the processing of auto_increment column should be handled on exchange node raher than TabletWriter when using partition tablet sink shuffle.
branch-2.1-pick: #37029