Skip to content

Conversation

@xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented Jun 26, 2024

  1. Fix enableParallelResultSink is true, ADBC client use QueryId to fetch result, else use FinstId.
  2. Add arrow flight sql conf in regression-test/pipeline/p0/conf/regression-conf.groovy.
  3. Add regression-test/suites/arrow_flight_sql_p0/test_select.groovy

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xinyiZzz
Copy link
Contributor Author

run buildall

hello-stephen
hello-stephen previously approved these changes Jun 26, 2024
Copy link
Contributor

@hello-stephen hello-stephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 26, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@xinyiZzz
Copy link
Contributor Author

run buildall

HappenLee
HappenLee previously approved these changes Jun 28, 2024
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented Jul 8, 2024

run buildall

1 similar comment
@xinyiZzz
Copy link
Contributor Author

run buildall

@xinyiZzz xinyiZzz dismissed stale reviews from hello-stephen and HappenLee via d53392d July 12, 2024 04:39
@xinyiZzz xinyiZzz force-pushed the 20240625_arrow_flight_regressiontest branch from 81178ac to d53392d Compare July 12, 2024 04:39
@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 12, 2024
@xinyiZzz
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39507 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a104790abce45a1e8b64bd161a28789ef6e79d82, data reload: false

------ Round 1 ----------------------------------
q1	17632	4455	4232	4232
q2	2020	186	191	186
q3	10467	1212	1018	1018
q4	10188	797	880	797
q5	7554	2690	2549	2549
q6	220	140	135	135
q7	971	597	607	597
q8	9213	2095	2059	2059
q9	8816	6553	6522	6522
q10	8817	3799	3848	3799
q11	442	241	236	236
q12	394	237	228	228
q13	18801	2955	2956	2955
q14	282	232	238	232
q15	537	483	489	483
q16	505	387	372	372
q17	958	688	617	617
q18	8078	7490	7386	7386
q19	4419	1363	1401	1363
q20	687	326	318	318
q21	4937	3106	3202	3106
q22	392	328	317	317
Total cold run time: 116330 ms
Total hot run time: 39507 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4368	4262	4227	4227
q2	369	259	268	259
q3	2954	2803	2846	2803
q4	1980	1722	1675	1675
q5	5709	5533	5646	5533
q6	221	142	131	131
q7	2204	1882	1925	1882
q8	3289	3451	3393	3393
q9	8860	8844	9097	8844
q10	4146	3990	3821	3821
q11	592	492	487	487
q12	815	653	642	642
q13	17402	3261	3239	3239
q14	327	293	292	292
q15	533	494	500	494
q16	488	456	443	443
q17	1804	1538	1561	1538
q18	8187	8049	8604	8049
q19	4850	1528	1610	1528
q20	2231	1938	1945	1938
q21	5384	5189	5026	5026
q22	637	567	556	556
Total cold run time: 77350 ms
Total hot run time: 56800 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 178663 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a104790abce45a1e8b64bd161a28789ef6e79d82, data reload: false

query1	927	399	380	380
query2	6445	2365	2278	2278
query3	6640	209	224	209
query4	28611	17731	17652	17652
query5	3681	488	501	488
query6	253	180	171	171
query7	4586	306	297	297
query8	320	277	292	277
query9	8533	2471	2467	2467
query10	446	292	273	273
query11	10624	10159	10141	10141
query12	118	94	88	88
query13	1647	402	380	380
query14	10496	6659	7924	6659
query15	275	191	189	189
query16	8020	328	334	328
query17	1779	581	549	549
query18	2090	310	294	294
query19	334	161	161	161
query20	97	84	88	84
query21	208	129	137	129
query22	4345	4145	4071	4071
query23	34204	33888	33747	33747
query24	10687	2924	2989	2924
query25	626	485	408	408
query26	1012	156	166	156
query27	2116	290	292	290
query28	6658	2206	2193	2193
query29	893	664	660	660
query30	264	161	165	161
query31	985	755	746	746
query32	96	55	57	55
query33	764	309	310	309
query34	984	502	542	502
query35	703	634	616	616
query36	1180	992	980	980
query37	139	87	88	87
query38	2949	2825	2835	2825
query39	870	828	803	803
query40	202	122	125	122
query41	54	51	51	51
query42	124	98	104	98
query43	592	531	559	531
query44	1245	731	746	731
query45	202	167	170	167
query46	1096	748	712	712
query47	1852	1756	1787	1756
query48	366	305	291	291
query49	838	415	419	415
query50	795	408	411	408
query51	7044	6844	6755	6755
query52	115	97	98	97
query53	386	308	306	306
query54	941	471	465	465
query55	75	76	77	76
query56	293	277	279	277
query57	1121	1027	1054	1027
query58	244	270	273	270
query59	3276	3291	3388	3291
query60	313	282	297	282
query61	93	92	101	92
query62	794	660	655	655
query63	326	294	290	290
query64	9425	2245	1681	1681
query65	3282	3168	3167	3167
query66	691	331	330	330
query67	15580	14883	14907	14883
query68	4749	557	552	552
query69	598	492	386	386
query70	1226	1116	1161	1116
query71	399	287	328	287
query72	8648	5418	5756	5418
query73	763	338	330	330
query74	5902	5536	5578	5536
query75	3616	2740	2743	2740
query76	3049	857	1005	857
query77	720	311	317	311
query78	11607	13520	12450	12450
query79	1839	542	541	541
query80	894	484	474	474
query81	594	239	231	231
query82	252	136	140	136
query83	351	176	171	171
query84	273	87	87	87
query85	695	330	306	306
query86	446	309	321	309
query87	3399	3103	3154	3103
query88	3165	2497	2458	2458
query89	481	396	406	396
query90	1751	202	200	200
query91	136	103	104	103
query92	63	52	50	50
query93	1003	519	519	519
query94	968	218	223	218
query95	399	325	333	325
query96	599	279	275	275
query97	3215	3063	3070	3063
query98	212	202	200	200
query99	1523	1262	1319	1262
Total cold run time: 280505 ms
Total hot run time: 178663 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.93 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a104790abce45a1e8b64bd161a28789ef6e79d82, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.68	0.07	0.07
query5	0.50	0.50	0.49
query6	1.14	0.73	0.72
query7	0.03	0.01	0.01
query8	0.05	0.04	0.05
query9	0.53	0.50	0.49
query10	0.54	0.56	0.54
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.59	0.58	0.59
query14	0.77	0.77	0.83
query15	0.85	0.82	0.83
query16	0.36	0.37	0.37
query17	1.04	1.02	1.03
query18	0.23	0.22	0.22
query19	1.91	1.73	1.79
query20	0.02	0.01	0.01
query21	15.40	0.75	0.66
query22	4.53	6.57	2.17
query23	18.30	1.31	1.23
query24	2.07	0.23	0.22
query25	0.15	0.08	0.09
query26	0.30	0.21	0.21
query27	0.45	0.23	0.24
query28	13.33	1.01	0.99
query29	12.60	3.33	3.29
query30	0.26	0.05	0.06
query31	2.88	0.39	0.40
query32	3.31	0.47	0.47
query33	2.93	2.84	2.90
query34	17.08	4.57	4.42
query35	4.43	4.46	4.39
query36	0.66	0.48	0.47
query37	0.19	0.16	0.16
query38	0.16	0.15	0.15
query39	0.04	0.04	0.04
query40	0.15	0.12	0.13
query41	0.09	0.05	0.05
query42	0.06	0.04	0.05
query43	0.05	0.04	0.03
Total cold run time: 110.31 s
Total hot run time: 30.93 s

/**
* Implementation of Arrow Flight SQL service
*
* <p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what the <p> means ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDEA format code automatically added
It seems that because the comment is segmented。。

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 12, 2024
Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit 5e3a4e8 into apache:master Jul 12, 2024
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Jul 12, 2024
…_sql (apache#36854)

1. Fix `enableParallelResultSink` is true, ADBC client use QueryId to
fetch result, else use FinstId.
2. Add arrow flight sql conf in
regression-test/pipeline/p0/conf/regression-conf.groovy.
3. Add regression-test/suites/arrow_flight_sql_p0/test_select.groovy
xinyiZzz added a commit that referenced this pull request Jul 16, 2024
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
…_sql (apache#36854)

1. Fix `enableParallelResultSink` is true, ADBC client use QueryId to
fetch result, else use FinstId.
2. Add arrow flight sql conf in
regression-test/pipeline/p0/conf/regression-conf.groovy.
3. Add regression-test/suites/arrow_flight_sql_p0/test_select.groovy
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
…_sql (#36854)

1. Fix `enableParallelResultSink` is true, ADBC client use QueryId to
fetch result, else use FinstId.
2. Add arrow flight sql conf in
regression-test/pipeline/p0/conf/regression-conf.groovy.
3. Add regression-test/suites/arrow_flight_sql_p0/test_select.groovy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants