Skip to content

Conversation

@dataroaring
Copy link
Contributor

@dataroaring dataroaring commented Jun 26, 2024

Proposed changes

When a lot of tablets fail when loading, then detailed information would cause oom.

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@dataroaring
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

gavinchou
gavinchou previously approved these changes Jun 26, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 26, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 40884 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e152f8bae455120130366923a630adb200cccae5, data reload: false

------ Round 1 ----------------------------------
q1	17639	4557	4375	4375
q2	2016	192	192	192
q3	10549	1220	1165	1165
q4	10216	823	804	804
q5	7591	2724	2693	2693
q6	225	138	138	138
q7	976	619	617	617
q8	9747	2068	2053	2053
q9	9089	6506	6471	6471
q10	8946	3766	3774	3766
q11	461	238	235	235
q12	446	230	234	230
q13	17771	2969	2974	2969
q14	274	221	226	221
q15	534	467	479	467
q16	500	380	378	378
q17	991	714	700	700
q18	8146	7477	7447	7447
q19	8224	1480	1474	1474
q20	662	316	322	316
q21	4901	3828	3873	3828
q22	402	345	345	345
Total cold run time: 120306 ms
Total hot run time: 40884 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4469	4270	4295	4270
q2	383	264	269	264
q3	2972	2731	2736	2731
q4	1878	1654	1644	1644
q5	5294	5284	5325	5284
q6	221	133	130	130
q7	2126	1797	1755	1755
q8	3220	3367	3352	3352
q9	8320	8365	8354	8354
q10	3928	3711	3704	3704
q11	586	484	518	484
q12	780	596	621	596
q13	17252	2993	3002	2993
q14	288	278	268	268
q15	512	465	476	465
q16	484	408	427	408
q17	1773	1478	1467	1467
q18	7606	7556	7371	7371
q19	1737	1559	1549	1549
q20	1973	1790	1815	1790
q21	4864	4655	4671	4655
q22	614	533	530	530
Total cold run time: 71280 ms
Total hot run time: 54064 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173106 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e152f8bae455120130366923a630adb200cccae5, data reload: false

query1	915	391	389	389
query2	6459	2408	2483	2408
query3	6645	226	207	207
query4	19394	17107	17389	17107
query5	4110	465	461	461
query6	254	178	155	155
query7	4588	300	291	291
query8	298	293	299	293
query9	8511	2413	2396	2396
query10	612	301	286	286
query11	10365	9995	10116	9995
query12	124	82	87	82
query13	1635	361	357	357
query14	9776	7043	7481	7043
query15	228	192	190	190
query16	7828	274	262	262
query17	1886	542	526	526
query18	1959	268	275	268
query19	193	144	151	144
query20	91	82	78	78
query21	206	133	129	129
query22	4375	4218	4398	4218
query23	33435	32879	33063	32879
query24	12014	2918	2812	2812
query25	688	369	349	349
query26	1803	153	158	153
query27	3074	315	318	315
query28	7609	2075	2072	2072
query29	1160	611	605	605
query30	290	154	151	151
query31	952	714	742	714
query32	93	53	54	53
query33	764	280	274	274
query34	1016	467	487	467
query35	727	630	631	630
query36	1084	942	937	937
query37	302	72	73	72
query38	2904	2725	2715	2715
query39	892	768	802	768
query40	284	127	125	125
query41	54	52	65	52
query42	124	104	95	95
query43	586	541	544	541
query44	1201	727	737	727
query45	193	169	164	164
query46	1082	736	707	707
query47	1854	1762	1772	1762
query48	354	309	298	298
query49	1192	417	404	404
query50	769	390	384	384
query51	6978	6721	6750	6721
query52	106	94	96	94
query53	363	288	282	282
query54	1018	459	442	442
query55	77	74	73	73
query56	288	259	275	259
query57	1153	1063	1055	1055
query58	263	261	253	253
query59	3417	3181	3305	3181
query60	336	279	310	279
query61	91	91	98	91
query62	647	447	445	445
query63	322	285	283	283
query64	9835	2264	1733	1733
query65	3182	3078	3100	3078
query66	1379	352	394	352
query67	15404	14983	15096	14983
query68	4596	545	549	545
query69	461	300	304	300
query70	1132	1098	1138	1098
query71	410	269	279	269
query72	7050	5746	5749	5746
query73	750	323	322	322
query74	5976	5480	5579	5480
query75	3518	2640	2707	2640
query76	2875	947	929	929
query77	469	302	302	302
query78	10449	9915	9709	9709
query79	2343	516	514	514
query80	981	480	472	472
query81	547	217	218	217
query82	1112	104	102	102
query83	267	170	171	170
query84	233	87	84	84
query85	1581	294	270	270
query86	485	323	290	290
query87	3312	3064	3145	3064
query88	3987	2395	2413	2395
query89	469	399	380	380
query90	1813	193	189	189
query91	128	98	100	98
query92	59	49	48	48
query93	2379	519	505	505
query94	1164	189	189	189
query95	408	308	317	308
query96	592	269	264	264
query97	3250	3060	3058	3058
query98	218	202	203	202
query99	1181	835	833	833
Total cold run time: 276006 ms
Total hot run time: 173106 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.31 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e152f8bae455120130366923a630adb200cccae5, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.21	0.05	0.05
query4	1.68	0.07	0.07
query5	0.49	0.50	0.48
query6	1.14	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.55	0.48	0.47
query10	0.54	0.54	0.54
query11	0.14	0.11	0.12
query12	0.15	0.12	0.12
query13	0.59	0.59	0.58
query14	0.77	0.77	0.78
query15	0.83	0.83	0.82
query16	0.35	0.37	0.37
query17	0.95	0.96	0.98
query18	0.21	0.22	0.26
query19	1.81	1.78	1.80
query20	0.02	0.01	0.01
query21	15.46	0.67	0.67
query22	3.56	7.72	2.52
query23	18.31	1.38	1.35
query24	2.12	0.23	0.22
query25	0.16	0.08	0.08
query26	0.26	0.19	0.18
query27	0.08	0.08	0.08
query28	13.29	1.04	1.01
query29	12.62	3.25	3.28
query30	0.25	0.06	0.07
query31	2.87	0.41	0.38
query32	3.24	0.47	0.47
query33	2.88	2.89	2.90
query34	16.93	4.43	4.41
query35	4.46	4.54	4.51
query36	0.66	0.45	0.49
query37	0.17	0.15	0.16
query38	0.16	0.14	0.15
query39	0.04	0.03	0.03
query40	0.17	0.14	0.15
query41	0.09	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 108.49 s
Total hot run time: 31.31 s

@dataroaring
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 26, 2024
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39547 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 294a8d4186bc6b20fc128046cccd0e8c73f7d22d, data reload: false

------ Round 1 ----------------------------------
q1	17644	4312	4240	4240
q2	2023	195	196	195
q3	10443	1215	1120	1120
q4	10187	749	764	749
q5	7495	2635	2562	2562
q6	219	132	135	132
q7	939	591	580	580
q8	9327	2035	2052	2035
q9	8910	6478	6443	6443
q10	8976	3714	3716	3714
q11	454	230	230	230
q12	478	235	225	225
q13	17764	2999	2979	2979
q14	273	224	213	213
q15	525	486	491	486
q16	494	381	372	372
q17	947	735	678	678
q18	7943	7483	7345	7345
q19	5291	1465	1356	1356
q20	654	323	323	323
q21	4845	3260	3241	3241
q22	392	329	337	329
Total cold run time: 116223 ms
Total hot run time: 39547 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4332	4229	4172	4172
q2	378	264	266	264
q3	2944	2740	2950	2740
q4	1986	1767	1707	1707
q5	5609	5498	5492	5492
q6	216	127	126	126
q7	2260	1904	1871	1871
q8	3260	3404	3407	3404
q9	8646	8655	8834	8655
q10	4068	3874	3672	3672
q11	603	502	509	502
q12	837	648	637	637
q13	16227	3181	3202	3181
q14	301	283	285	283
q15	519	494	478	478
q16	495	429	440	429
q17	1821	1491	1510	1491
q18	8120	7871	7821	7821
q19	1857	1610	1551	1551
q20	3119	1859	1867	1859
q21	5128	4884	4850	4850
q22	625	531	553	531
Total cold run time: 73351 ms
Total hot run time: 55716 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173840 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 294a8d4186bc6b20fc128046cccd0e8c73f7d22d, data reload: false

query1	925	395	373	373
query2	6461	2353	2280	2280
query3	6629	205	206	205
query4	19511	17407	17248	17248
query5	3673	473	463	463
query6	257	174	166	166
query7	4595	298	285	285
query8	309	298	294	294
query9	8459	2410	2390	2390
query10	602	281	293	281
query11	10686	10047	10081	10047
query12	117	89	85	85
query13	1669	372	363	363
query14	10216	6576	7206	6576
query15	233	189	190	189
query16	7724	276	266	266
query17	1650	574	541	541
query18	1916	293	280	280
query19	207	159	156	156
query20	94	88	91	88
query21	217	137	125	125
query22	4414	3991	4111	3991
query23	33782	33689	33676	33676
query24	11321	2850	2933	2850
query25	636	429	390	390
query26	948	158	159	158
query27	2361	334	326	326
query28	6808	2169	2156	2156
query29	924	673	647	647
query30	258	159	158	158
query31	976	777	778	777
query32	90	55	57	55
query33	777	294	293	293
query34	1040	485	487	485
query35	799	641	636	636
query36	1139	969	993	969
query37	146	82	77	77
query38	2984	2850	2870	2850
query39	920	820	806	806
query40	218	135	132	132
query41	57	55	51	51
query42	114	106	125	106
query43	620	568	553	553
query44	1175	719	737	719
query45	202	171	169	169
query46	1077	720	747	720
query47	1851	1778	1792	1778
query48	379	305	302	302
query49	872	417	423	417
query50	783	387	475	387
query51	6886	6787	6722	6722
query52	104	96	89	89
query53	361	303	292	292
query54	888	455	439	439
query55	77	71	73	71
query56	287	264	270	264
query57	1102	1042	1064	1042
query58	253	241	251	241
query59	3470	3255	3301	3255
query60	301	275	281	275
query61	97	99	111	99
query62	617	451	434	434
query63	325	290	289	289
query64	8654	2250	1771	1771
query65	3158	3059	3098	3059
query66	750	331	325	325
query67	15864	14981	15025	14981
query68	8820	563	559	559
query69	729	470	414	414
query70	1399	1114	1143	1114
query71	531	267	264	264
query72	8518	5383	5554	5383
query73	2230	326	328	326
query74	5975	5466	5535	5466
query75	5649	2633	2640	2633
query76	5591	957	887	887
query77	778	294	295	294
query78	10450	9981	9801	9801
query79	8695	514	518	514
query80	948	475	469	469
query81	561	219	236	219
query82	237	102	107	102
query83	349	173	172	172
query84	271	90	90	90
query85	886	330	277	277
query86	357	322	323	322
query87	3285	3119	3082	3082
query88	4605	2395	2381	2381
query89	525	388	382	382
query90	2022	205	192	192
query91	133	104	100	100
query92	62	53	50	50
query93	5786	538	526	526
query94	1311	194	192	192
query95	415	328	326	326
query96	615	269	270	269
query97	3182	3014	3041	3014
query98	220	202	197	197
query99	1120	845	840	840
Total cold run time: 293270 ms
Total hot run time: 173840 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.33 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 294a8d4186bc6b20fc128046cccd0e8c73f7d22d, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.05
query3	0.22	0.05	0.05
query4	1.67	0.11	0.11
query5	0.52	0.46	0.50
query6	1.13	0.74	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.05
query9	0.56	0.51	0.49
query10	0.55	0.54	0.53
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.59	0.59	0.60
query14	0.77	0.79	0.79
query15	0.85	0.82	0.82
query16	0.37	0.37	0.37
query17	1.05	0.98	0.99
query18	0.22	0.24	0.25
query19	1.88	1.69	1.76
query20	0.01	0.01	0.01
query21	15.45	0.76	0.65
query22	4.36	7.63	1.58
query23	18.28	1.34	1.33
query24	2.16	0.22	0.22
query25	0.15	0.09	0.08
query26	0.26	0.18	0.19
query27	0.08	0.08	0.09
query28	13.29	1.04	1.00
query29	12.61	3.26	3.27
query30	0.26	0.06	0.07
query31	2.86	0.38	0.39
query32	3.29	0.47	0.48
query33	2.88	3.00	2.86
query34	17.11	4.41	4.46
query35	4.49	4.50	4.52
query36	0.65	0.47	0.50
query37	0.17	0.16	0.15
query38	0.17	0.15	0.14
query39	0.04	0.03	0.04
query40	0.19	0.14	0.15
query41	0.09	0.04	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.83 s
Total hot run time: 30.33 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 27, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit c2f402d into apache:master Jun 27, 2024
dataroaring added a commit to dataroaring/incubator-doris that referenced this pull request Jun 27, 2024
dataroaring added a commit that referenced this pull request Jun 28, 2024
When a lot of tablets fail when loading, then detailed information would
cause oom.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants