Skip to content

[fix](fe ut) fix unstable SystemInfoServiceTest #36893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 4 commits into from
Jun 27, 2024
Merged

[fix](fe ut) fix unstable SystemInfoServiceTest #36893

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e39806e
make random replica diff bigger
yujun777 Jun 27, 2024
31f7e9e
update
yujun777 Jun 27, 2024
37dbab5
update
yujun777 Jun 27, 2024
c0f632b
update
yujun777 Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions fe/fe-core/src/test/java/org/apache/doris/system/SystemInfoServiceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
import java.util.Collections;
import java.util.List;
import java.util.Map;
import java.util.Set;
import java.util.stream.Collectors;

public class SystemInfoServiceTest {
private SystemInfoService infoService;
Expand Down Expand Up @@ -403,7 +405,7 @@ public void testSelectBackendIdsForReplicaCreation() throws Exception {
ReplicaAllocation replicaAlloc = ReplicaAllocation.DEFAULT_ALLOCATION;
// also check if the random selection logic can evenly distribute the replica.
Map<Long, Integer> beCounterMap = Maps.newHashMap();
for (int i = 0; i < 10000; ++i) {
for (int i = 0; i < 30000; ++i) {
Pair<Map<Tag, List<Long>>, TStorageMedium> ret = infoService.selectBackendIdsForReplicaCreation(replicaAlloc,
Maps.newHashMap(), TStorageMedium.HDD, false, false);
Map<Tag, List<Long>> res = ret.first;
Expand All @@ -412,11 +414,16 @@ public void testSelectBackendIdsForReplicaCreation() throws Exception {
beCounterMap.put(beId, beCounterMap.getOrDefault(beId, 0) + 1);
}
}
Set<Long> expectBackendIds = infoService.getMixBackends().stream()
.filter(Backend::isAlive).map(Backend::getId)
.collect(Collectors.toSet());
Assert.assertEquals(expectBackendIds, beCounterMap.keySet().stream().collect(Collectors.toSet()));
List<Integer> list = Lists.newArrayList(beCounterMap.values());
Collections.sort(list);
int diff = list.get(list.size() - 1) - list.get(0);
// The max replica num and min replica num's diff is less than 5%.
Assert.assertTrue((diff * 1.0 / list.get(0)) < 0.05);
int max = list.get(list.size() - 1);
int diff = max - list.get(0);
// The max replica num and min replica num's diff is less than 30%.
Assert.assertTrue((diff * 1.0 / max) < 0.3);
}

private void addDisk(Backend be, String path, TStorageMedium medium, long totalB, long availB) {
Expand Down