Skip to content

[improvement](statistics)Use real base index id to fetch stats cache. (#36914) #36992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jibing-Li merged 1 commit into from
Jun 28, 2024
Merged

[improvement](statistics)Use real base index id to fetch stats cache. (#36914) #36992

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/statistics/StatisticsCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
package org.apache.doris.statistics;

import org.apache.doris.catalog.Env;
import org.apache.doris.catalog.OlapTable;
import org.apache.doris.catalog.TableIf;
import org.apache.doris.common.ClientPool;
import org.apache.doris.common.Config;
import org.apache.doris.common.ThreadPoolManager;
Expand Down Expand Up @@ -79,6 +81,12 @@ public ColumnStatistic getColumnStatistics(long catalogId, long dbId, long tblId
if (ctx != null && ctx.getSessionVariable().internalSession) {
return ColumnStatistic.UNKNOWN;
}
// Need to change base index id to -1 for OlapTable.
try {
idxId = changeBaseIndexId(catalogId, dbId, tblId, idxId);
} catch (Exception e) {
return ColumnStatistic.UNKNOWN;
}
StatisticsCacheKey k = new StatisticsCacheKey(catalogId, dbId, tblId, idxId, colName);
try {
CompletableFuture<Optional<ColumnStatistic>> f = columnStatisticsCache.get(k);
Expand All @@ -91,6 +99,21 @@ public ColumnStatistic getColumnStatistics(long catalogId, long dbId, long tblId
return ColumnStatistic.UNKNOWN;
}

// Base index id should be set to -1 for OlapTable. Because statistics tables use -1 for base index.
// TODO: Need to use the real index id in statistics table in later version.
private long changeBaseIndexId(long catalogId, long dbId, long tblId, long idxId) {
if (idxId != -1) {
TableIf table = StatisticsUtil.findTable(catalogId, dbId, tblId);
if (table instanceof OlapTable) {
OlapTable olapTable = (OlapTable) table;
if (idxId == olapTable.getBaseIndexId()) {
idxId = -1;
}
}
}
return idxId;
}

public Histogram getHistogram(long ctlId, long dbId, long tblId, String colName) {
return getHistogram(ctlId, dbId, tblId, -1, colName).orElse(null);
}
Expand Down