Skip to content

[Bug](runtime-filter) disable sync filter when pipeline engine is off #36994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
HappenLee merged 1 commit into from
Jun 28, 2024
Merged

[Bug](runtime-filter) disable sync filter when pipeline engine is off #36994

HappenLee merged 1 commit into from
Jun 28, 2024

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Jun 28, 2024

Proposed changes

  1. disable sync filter when pipeline engine is off
  2. reduce some warning log

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Jun 28, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 28, 2024

clang-tidy review says "All clean, LGTM! 👍"

@wm1581066 wm1581066 requested a review from HappenLee June 28, 2024 05:30
HappenLee
HappenLee approved these changes Jun 28, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HappenLee HappenLee merged commit cb80ae9 into apache:branch-2.1 Jun 28, 2024
@wm1581066 wm1581066 added dev/2.1.5-merged usercase Important user case type label labels Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

Assignees

No one assigned

Labels

dev/2.1.5-merged usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@BiteTheDDDDt @HappenLee @wm1581066