Skip to content

Conversation

@dataroaring
Copy link
Contributor

@dataroaring dataroaring commented Jun 29, 2024

This reverts commit 9990181.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@dataroaring
Copy link
Contributor Author

run buildall

@gavinchou gavinchou changed the title Revert "[enhancement](compaction) optimizing memory usage for compact… Revert "[enhancement](compaction) optimizing memory usage for compaction (#36492)" Jun 29, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 29, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40699 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a9eb19951bbe303c972603170da22d3b3ec09316, data reload: false

------ Round 1 ----------------------------------
q1	17630	4352	4312	4312
q2	2011	190	194	190
q3	10474	1189	1123	1123
q4	10198	832	758	758
q5	7492	2634	2640	2634
q6	217	134	132	132
q7	957	589	598	589
q8	9229	2097	2100	2097
q9	8976	6545	6487	6487
q10	9036	3691	3765	3691
q11	446	228	232	228
q12	449	230	227	227
q13	18852	2981	3001	2981
q14	272	224	224	224
q15	541	481	475	475
q16	533	373	389	373
q17	989	748	759	748
q18	8089	7522	7429	7429
q19	8358	1600	1536	1536
q20	658	337	346	337
q21	4958	3783	3924	3783
q22	409	345	346	345
Total cold run time: 120774 ms
Total hot run time: 40699 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4444	4236	4219	4219
q2	399	297	272	272
q3	3152	2934	2856	2856
q4	2077	1732	1688	1688
q5	5524	5503	5594	5503
q6	221	131	134	131
q7	2241	1820	1830	1820
q8	3293	3436	3416	3416
q9	8788	8873	8757	8757
q10	4055	3744	3850	3744
q11	585	505	515	505
q12	793	633	661	633
q13	15850	3191	3169	3169
q14	320	284	298	284
q15	541	467	511	467
q16	473	443	445	443
q17	1822	1507	1493	1493
q18	8197	8027	7817	7817
q19	1859	1744	1723	1723
q20	2170	1903	1880	1880
q21	5280	4936	4839	4839
q22	640	569	561	561
Total cold run time: 72724 ms
Total hot run time: 56220 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174063 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a9eb19951bbe303c972603170da22d3b3ec09316, data reload: false

query1	919	384	383	383
query2	6453	2458	2402	2402
query3	6639	204	212	204
query4	19097	17626	17459	17459
query5	3684	481	465	465
query6	261	165	157	157
query7	4587	284	299	284
query8	310	301	303	301
query9	8533	2399	2379	2379
query10	574	300	282	282
query11	10735	10025	10234	10025
query12	117	84	83	83
query13	1668	371	359	359
query14	9306	6832	7680	6832
query15	234	190	189	189
query16	7978	293	289	289
query17	1867	568	540	540
query18	2052	280	280	280
query19	205	160	161	160
query20	88	86	89	86
query21	210	130	122	122
query22	4379	4117	4180	4117
query23	34103	33442	33274	33274
query24	10780	2947	2884	2884
query25	621	405	391	391
query26	707	169	157	157
query27	2200	316	336	316
query28	5982	2157	2147	2147
query29	910	652	658	652
query30	266	161	160	160
query31	985	765	750	750
query32	98	54	61	54
query33	700	303	303	303
query34	907	488	493	488
query35	755	635	641	635
query36	1179	959	964	959
query37	151	75	78	75
query38	2987	2812	2835	2812
query39	895	842	830	830
query40	218	132	126	126
query41	58	54	51	51
query42	119	101	97	97
query43	604	562	573	562
query44	1062	750	738	738
query45	206	165	168	165
query46	1087	705	710	705
query47	1865	1812	1766	1766
query48	379	309	306	306
query49	844	503	418	418
query50	769	384	377	377
query51	7044	6846	6796	6796
query52	103	94	93	93
query53	355	283	277	277
query54	876	440	431	431
query55	73	75	72	72
query56	289	260	265	260
query57	1128	1059	1077	1059
query58	238	253	245	245
query59	3541	3439	3355	3355
query60	328	287	272	272
query61	92	91	94	91
query62	620	441	440	440
query63	320	295	285	285
query64	8574	2273	1747	1747
query65	3179	3088	3078	3078
query66	784	317	326	317
query67	15612	15027	14944	14944
query68	8670	548	562	548
query69	761	476	400	400
query70	1401	1130	1102	1102
query71	504	283	269	269
query72	8962	5236	5781	5236
query73	2303	326	326	326
query74	6009	5475	5494	5475
query75	5113	2685	2688	2685
query76	4881	973	992	973
query77	782	306	299	299
query78	10440	9933	9787	9787
query79	9508	512	510	510
query80	960	467	471	467
query81	550	217	219	217
query82	276	100	106	100
query83	352	168	164	164
query84	267	84	84	84
query85	875	335	278	278
query86	353	329	307	307
query87	3334	3057	3066	3057
query88	4897	2351	2369	2351
query89	531	397	376	376
query90	2000	196	191	191
query91	130	100	98	98
query92	64	51	49	49
query93	5915	514	515	514
query94	1282	189	188	188
query95	402	319	318	318
query96	620	270	267	267
query97	3242	3049	3041	3041
query98	217	202	202	202
query99	1143	854	826	826
Total cold run time: 291233 ms
Total hot run time: 174063 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.66 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a9eb19951bbe303c972603170da22d3b3ec09316, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.06
query4	1.65	0.09	0.09
query5	0.50	0.47	0.48
query6	1.14	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.55	0.49	0.48
query10	0.55	0.54	0.55
query11	0.16	0.11	0.11
query12	0.16	0.12	0.12
query13	0.59	0.59	0.60
query14	0.79	0.78	0.78
query15	0.85	0.82	0.82
query16	0.34	0.37	0.36
query17	1.04	1.00	1.06
query18	0.25	0.24	0.23
query19	1.87	1.68	1.79
query20	0.01	0.00	0.00
query21	15.45	0.73	0.66
query22	3.45	7.52	2.18
query23	18.23	1.37	1.24
query24	2.07	0.22	0.21
query25	0.16	0.08	0.08
query26	0.27	0.17	0.18
query27	0.08	0.08	0.08
query28	13.31	1.02	1.01
query29	12.69	3.30	3.23
query30	0.25	0.07	0.05
query31	2.85	0.38	0.39
query32	3.30	0.46	0.48
query33	2.89	2.89	2.93
query34	17.21	4.40	4.51
query35	4.52	4.46	4.41
query36	0.65	0.46	0.49
query37	0.18	0.16	0.15
query38	0.15	0.14	0.15
query39	0.04	0.03	0.04
query40	0.17	0.14	0.14
query41	0.09	0.05	0.05
query42	0.05	0.05	0.05
query43	0.04	0.03	0.04
Total cold run time: 108.97 s
Total hot run time: 30.66 s

Copy link
Contributor

@freemandealer freemandealer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 4e165dc into apache:master Jun 30, 2024
dataroaring added a commit that referenced this pull request Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants