Skip to content

[improvement](segmentcache) limit segment cache by memory or segment … #37035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Jun 30, 2024
Merged

[improvement](segmentcache) limit segment cache by memory or segment … #37035

dataroaring merged 2 commits into from
Jun 30, 2024

Conversation

@dataroaring
Copy link
Contributor

@dataroaring dataroaring commented Jun 30, 2024 •
edited
Loading

…num (#37026)

pick ##37026

Also enlarge columns per segment.

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@dataroaring
Copy link
Contributor Author

dataroaring commented Jun 30, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2024

clang-tidy review says "All clean, LGTM! 👍"

@dataroaring
Copy link
Contributor Author

dataroaring commented Jun 30, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jun 30, 2024

TeamCity be ut coverage result:
Function Coverage: 36.31% (9143/25179)
Line Coverage: 27.85% (74582/267753)
Region Coverage: 26.76% (38454/143714)
Branch Coverage: 23.47% (19499/83098)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c4dd3076ad9c56a5462296413b13739239b48ab3_c4dd3076ad9c56a5462296413b13739239b48ab3/report/index.html

sollhui
sollhui approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@sollhui sollhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2024

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 30, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2024

PR approved by at least one committer and no changes requested.

@dataroaring dataroaring merged commit 07278e9 into apache:branch-2.1 Jun 30, 2024
@yiguolei yiguolei mentioned this pull request Jul 19, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

+1 more reviewer

@sollhui sollhui sollhui approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dataroaring @doris-robot @gavinchou @sollhui