-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](file-scanner) add not found file number in profile #37042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39960 ms |
TPC-DS: Total hot run time: 171986 ms |
ClickBench: Total hot run time: 30.09 s |
|
LGTM |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40490 ms |
TPC-DS: Total hot run time: 172863 ms |
ClickBench: Total hot run time: 31.11 s |
kaka11chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40181 ms |
TPC-DS: Total hot run time: 172313 ms |
ClickBench: Total hot run time: 30.44 s |
9cc25a6 to
6f1ceea
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40205 ms |
TPC-DS: Total hot run time: 171886 ms |
ClickBench: Total hot run time: 30.47 s |
kaka11chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
PR apache#35319 ignore the not found files in external table by default. This PR add a BE config `ignore_not_found_file_in_external_table` to control this behavior, and the default value is still `true`. Also add a new metric `NotFoundFileNum`, separate from `EmptyFileNum`, to record the number of not found files in a query
PR #35319 ignore the not found files in external table by default. This PR add a BE config `ignore_not_found_file_in_external_table` to control this behavior, and the default value is still `true`. Also add a new metric `NotFoundFileNum`, separate from `EmptyFileNum`, to record the number of not found files in a query
followup #37042 1. The previous PR miss one place to record "not found" file num 2. Catch "NoSuchKey" error and treat it as "not found"
followup apache#37042 1. The previous PR miss one place to record "not found" file num 2. Catch "NoSuchKey" error and treat it as "not found"
followup #37042 1. The previous PR miss one place to record "not found" file num 2. Catch "NoSuchKey" error and treat it as "not found"
PR #35319 ignore the not found files in external table by default.
This PR add a BE config
ignore_not_found_file_in_external_tableto control this behavior,and the default value is still
true.Also add a new metric
NotFoundFileNum, separate fromEmptyFileNum,to record the number of not found files in a query