Skip to content

[fix](Nereids) simplify window expression should inherit data type #37061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jul 1, 2024
Merged

[fix](Nereids) simplify window expression should inherit data type #37061

morrySnow merged 1 commit into from
Jul 1, 2024

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Jul 1, 2024 •
edited
Loading

intro by #33647

after window expression rewritten by literal.
literal's data type should same with original window expression.

@doris-robot
Copy link

doris-robot commented Jul 1, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

morrySnow commented Jul 1, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jul 1, 2024

TPC-H: Total hot run time: 40369 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 4fe4f9f6829d09ab07e7a1898adf63cc8a279e2c, data reload: false

------ Round 1 ----------------------------------
q1	18054	5405	4375	4375
q2	2588	196	193	193
q3	12168	1234	1158	1158
q4	10632	860	908	860
q5	7737	2729	2694	2694
q6	225	142	147	142
q7	984	628	636	628
q8	9572	2087	2067	2067
q9	8997	6469	6516	6469
q10	8988	3722	3767	3722
q11	474	236	238	236
q12	415	241	231	231
q13	17775	2984	2974	2974
q14	266	216	223	216
q15	506	480	493	480
q16	512	393	374	374
q17	973	686	684	684
q18	8044	7523	7462	7462
q19	1666	1590	1486	1486
q20	684	315	335	315
q21	4923	3287	3276	3276
q22	397	327	329	327
Total cold run time: 116580 ms
Total hot run time: 40369 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4307	4231	4235	4231
q2	367	271	261	261
q3	2964	2820	2746	2746
q4	1901	1612	1630	1612
q5	5260	5270	5308	5270
q6	219	132	132	132
q7	2126	1760	1742	1742
q8	3196	3340	3339	3339
q9	8374	8335	8305	8305
q10	3908	3712	3698	3698
q11	611	507	501	501
q12	768	655	593	593
q13	16336	2980	2986	2980
q14	288	259	264	259
q15	519	495	470	470
q16	466	427	407	407
q17	1758	1461	1467	1461
q18	7667	7559	7474	7474
q19	1699	1607	1551	1551
q20	2007	1796	1809	1796
q21	4968	4745	4704	4704
q22	638	535	544	535
Total cold run time: 70347 ms
Total hot run time: 54067 ms

@doris-robot
Copy link

doris-robot commented Jul 1, 2024

TPC-DS: Total hot run time: 173695 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 4fe4f9f6829d09ab07e7a1898adf63cc8a279e2c, data reload: false

query1	943	395	375	375
query2	6474	2444	2362	2362
query3	6646	205	212	205
query4	20472	17472	17333	17333
query5	4179	470	496	470
query6	285	193	164	164
query7	4608	301	309	301
query8	321	298	268	268
query9	8463	2378	2378	2378
query10	611	288	272	272
query11	10544	10026	10007	10007
query12	134	82	83	82
query13	1640	349	349	349
query14	9012	7830	7631	7631
query15	250	183	193	183
query16	7821	283	261	261
query17	1881	551	545	545
query18	1947	268	267	267
query19	192	145	145	145
query20	90	79	82	79
query21	209	134	131	131
query22	4471	4282	4104	4104
query23	33885	33043	33188	33043
query24	11268	2792	2961	2792
query25	651	373	379	373
query26	1687	152	156	152
query27	3000	319	312	312
query28	7774	2077	2052	2052
query29	1042	637	614	614
query30	267	150	149	149
query31	943	750	740	740
query32	93	53	57	53
query33	762	311	298	298
query34	926	466	484	466
query35	752	651	625	625
query36	1072	966	942	942
query37	148	76	74	74
query38	2867	2711	2773	2711
query39	877	800	804	800
query40	284	123	124	123
query41	55	51	49	49
query42	115	99	99	99
query43	579	564	514	514
query44	1228	732	731	731
query45	194	166	167	166
query46	1081	727	719	719
query47	1840	1771	1737	1737
query48	361	299	295	295
query49	1136	419	418	418
query50	773	383	389	383
query51	6906	6722	6792	6722
query52	110	95	100	95
query53	365	302	301	301
query54	891	443	442	442
query55	76	74	74	74
query56	281	266	264	264
query57	1165	1047	1035	1035
query58	297	255	245	245
query59	3285	3194	3110	3110
query60	303	286	279	279
query61	95	91	89	89
query62	634	433	466	433
query63	322	300	303	300
query64	9849	2276	1822	1822
query65	3239	3094	3137	3094
query66	1374	339	334	334
query67	15401	15017	14861	14861
query68	4565	528	525	525
query69	462	317	301	301
query70	1226	1077	1146	1077
query71	373	280	305	280
query72	7078	5475	5596	5475
query73	734	321	322	321
query74	5963	5540	5594	5540
query75	3351	2662	2663	2662
query76	2462	976	1002	976
query77	462	301	293	293
query78	10299	9937	9736	9736
query79	2389	508	507	507
query80	870	481	471	471
query81	543	221	227	221
query82	762	110	106	106
query83	269	200	175	175
query84	237	92	89	89
query85	1773	273	270	270
query86	486	308	306	306
query87	3243	3064	3157	3064
query88	4082	2356	2351	2351
query89	494	384	394	384
query90	1845	193	187	187
query91	123	116	96	96
query92	62	51	48	48
query93	2324	497	494	494
query94	1251	189	185	185
query95	406	312	313	312
query96	580	271	272	271
query97	3258	3111	3107	3107
query98	224	203	191	191
query99	1132	836	832	832
Total cold run time: 274774 ms
Total hot run time: 173695 ms

@doris-robot
Copy link

doris-robot commented Jul 1, 2024

ClickBench: Total hot run time: 30.42 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 4fe4f9f6829d09ab07e7a1898adf63cc8a279e2c, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.04	0.04
query3	0.22	0.04	0.04
query4	1.68	0.07	0.07
query5	0.49	0.50	0.52
query6	1.14	0.73	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.05
query9	0.54	0.50	0.50
query10	0.55	0.54	0.54
query11	0.14	0.12	0.11
query12	0.16	0.12	0.12
query13	0.58	0.58	0.60
query14	0.76	0.77	0.79
query15	0.84	0.82	0.82
query16	0.36	0.40	0.36
query17	1.01	0.97	1.01
query18	0.22	0.24	0.24
query19	1.78	1.70	1.72
query20	0.02	0.01	0.01
query21	15.46	0.74	0.66
query22	4.65	7.34	1.79
query23	18.25	1.46	1.28
query24	2.09	0.25	0.21
query25	0.15	0.09	0.08
query26	0.27	0.18	0.17
query27	0.08	0.08	0.08
query28	13.25	1.01	1.01
query29	12.63	3.30	3.31
query30	0.25	0.06	0.05
query31	2.89	0.39	0.38
query32	3.27	0.46	0.48
query33	2.85	2.89	2.98
query34	17.02	4.53	4.40
query35	4.55	4.45	4.51
query36	0.66	0.51	0.48
query37	0.17	0.14	0.14
query38	0.16	0.14	0.14
query39	0.04	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.05	0.04
query42	0.05	0.05	0.04
query43	0.04	0.03	0.04
Total cold run time: 109.71 s
Total hot run time: 30.42 s

@morrySnow
Copy link
Contributor Author

morrySnow commented Jul 1, 2024

run feut

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 55f5fce into apache:master Jul 1, 2024
@morrySnow morrySnow deleted the fix_simplify_window branch July 1, 2024 08:06
@wm1581066 wm1581066 added the usercase Important user case type label label Jul 2, 2024
dataroaring pushed a commit that referenced this pull request Jul 2, 2024
@morrySnow @dataroaring
[fix](Nereids) simplify window expression should inherit data type (#…
ffbfe6b 
…37061)

intro by #33647

after window expression rewritten by literal.
literal's data type should same with original window expression.
morrySnow added a commit to morrySnow/incubator-doris that referenced this pull request Jul 4, 2024
@morrySnow
[fix](Nereids) simplify window expression should inherit data type (a…
117c46c 
…pache#37061)

pick from master apache#37061

after window expression rewritten by literal.
literal's data type should same with original window expression.
@morrySnow morrySnow mentioned this pull request Jul 4, 2024
Merged
morrySnow added a commit that referenced this pull request Jul 4, 2024
@morrySnow
[fix](Nereids) simplify window expression should inherit data type (#…
c7ad1f3 
…37061) (#37283)

pick from master #37061

after window expression rewritten by literal.
literal's data type should same with original window expression.
morningman pushed a commit to morningman/doris that referenced this pull request Jul 9, 2024
@morrySnow @morningman
[fix](Nereids) simplify window expression should inherit data type (a…
08c2fed 
…pache#37061)

intro by apache#33647

after window expression rewritten by literal.
literal's data type should same with original window expression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@924060929 924060929 924060929 approved these changes

+1 more reviewer

@feiniaofeiafei feiniaofeiafei feiniaofeiafei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged p0_b reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@morrySnow @doris-robot @924060929 @feiniaofeiafei @wm1581066 @dataroaring