Skip to content

[Bug][Metrics] Fix bug that some of metrics can not be got #3708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chaoyli merged 1 commit into from
May 28, 2020
Merged

[Bug][Metrics] Fix bug that some of metrics can not be got #3708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions be/src/util/doris_metrics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,6 @@ DorisMetrics::DorisMetrics() : _name("doris_be"), _hook_name("doris_metrics"), _
_metrics.register_metric(
"stream_load", MetricLabels().add("type", "load_rows"),
&stream_load_rows_total);
_metrics.register_metric(
"load", MetricLabels().add("type", "receive_bytes"),
&stream_receive_bytes_total);
_metrics.register_metric("load_rows", &load_rows_total);
_metrics.register_metric("load_bytes", &load_bytes_total);

Expand Down
3 changes: 1 addition & 2 deletions be/src/util/metrics.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,8 @@ void Metric::hide() {
bool MetricCollector::add_metic(const MetricLabels& labels, Metric* metric) {
if (empty()) {
_type = metric->type();
_unit = metric->unit();
} else {
if (metric->type() != _type || metric->unit() != _unit) {
if (metric->type() != _type) {
return false;
}
}
Expand Down
2 changes: 0 additions & 2 deletions be/src/util/metrics.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,10 +310,8 @@ class MetricCollector {
return _metrics;
}
MetricType type() const { return _type; }
MetricUnit unit() const { return _unit; }
private:
MetricType _type = MetricType::UNTYPED;
MetricUnit _unit = MetricUnit::NOUNIT;
std::map<MetricLabels, Metric*> _metrics;
};

Expand Down