Skip to content

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Jul 3, 2024

Enable fetch hive table row count through file list by default. Change the sample partition count to 30 to reduce resource consumption.
Using a table with 100000 partition to test the performance. Row count could be fetch within 0.2 second and the cpu used is less than 1 core.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Jibing-Li Jibing-Li marked this pull request as ready for review July 3, 2024 08:58
@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40067 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 87d2b67aa1ae411f67369eadd4b7ae0245aa4217, data reload: false

------ Round 1 ----------------------------------
q1	17614	4387	4318	4318
q2	2042	206	194	194
q3	10448	1203	1158	1158
q4	10198	840	817	817
q5	7525	2675	2652	2652
q6	221	137	138	137
q7	956	606	608	606
q8	9231	2112	2083	2083
q9	8914	6506	6486	6486
q10	8916	3728	3740	3728
q11	468	240	240	240
q12	441	240	238	238
q13	18918	2994	2962	2962
q14	276	216	231	216
q15	526	492	492	492
q16	511	367	372	367
q17	971	658	674	658
q18	8046	7565	7438	7438
q19	3798	1523	1458	1458
q20	687	335	331	331
q21	4870	3152	3857	3152
q22	397	347	336	336
Total cold run time: 115974 ms
Total hot run time: 40067 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4367	4248	4270	4248
q2	366	276	262	262
q3	2989	2840	2902	2840
q4	2022	1701	1658	1658
q5	5687	5519	5543	5519
q6	222	129	131	129
q7	2236	1868	1885	1868
q8	3313	3440	3524	3440
q9	8917	8855	8939	8855
q10	4214	3854	3725	3725
q11	591	495	504	495
q12	879	667	663	663
q13	16276	3173	3194	3173
q14	311	281	285	281
q15	521	494	479	479
q16	490	452	456	452
q17	1827	1537	1491	1491
q18	8205	8055	7933	7933
q19	1744	1567	1630	1567
q20	2087	1860	1877	1860
q21	7812	4796	4792	4792
q22	614	544	574	544
Total cold run time: 75690 ms
Total hot run time: 56274 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174199 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 87d2b67aa1ae411f67369eadd4b7ae0245aa4217, data reload: false

query1	924	379	378	378
query2	6442	2440	2232	2232
query3	6632	204	213	204
query4	19541	17489	17432	17432
query5	3616	461	508	461
query6	259	172	175	172
query7	4594	305	291	291
query8	319	282	290	282
query9	8417	2372	2355	2355
query10	572	295	293	293
query11	10479	9968	10043	9968
query12	120	89	83	83
query13	1641	370	378	370
query14	9463	6640	7084	6640
query15	229	181	188	181
query16	7757	276	269	269
query17	1875	580	543	543
query18	1969	281	283	281
query19	202	160	157	157
query20	93	86	85	85
query21	213	141	129	129
query22	4264	4121	4177	4121
query23	33995	33592	33721	33592
query24	10793	2952	2875	2875
query25	624	418	471	418
query26	712	162	156	156
query27	2270	333	329	329
query28	6132	2130	2122	2122
query29	905	643	627	627
query30	263	159	152	152
query31	1012	752	751	751
query32	91	56	53	53
query33	652	305	294	294
query34	866	480	493	480
query35	774	681	637	637
query36	1098	980	998	980
query37	135	80	79	79
query38	2949	2837	2827	2827
query39	906	855	856	855
query40	226	131	125	125
query41	56	52	51	51
query42	113	97	106	97
query43	598	588	565	565
query44	1073	745	737	737
query45	190	167	171	167
query46	1089	720	690	690
query47	1856	1749	1774	1749
query48	384	307	305	305
query49	818	407	403	403
query50	778	389	391	389
query51	6954	6796	6756	6756
query52	102	93	100	93
query53	368	296	304	296
query54	877	469	456	456
query55	74	73	74	73
query56	279	267	268	267
query57	1140	1019	1016	1016
query58	270	250	240	240
query59	3420	3282	3239	3239
query60	307	272	264	264
query61	92	89	97	89
query62	603	446	443	443
query63	322	287	288	287
query64	8524	2268	1764	1764
query65	3216	3112	3134	3112
query66	741	346	327	327
query67	15583	15057	15070	15057
query68	4647	528	543	528
query69	553	447	333	333
query70	1194	1071	1132	1071
query71	397	282	280	280
query72	8719	5429	5529	5429
query73	744	326	322	322
query74	5847	5532	5559	5532
query75	3965	2677	2674	2674
query76	2874	899	921	899
query77	655	304	297	297
query78	10472	9868	9935	9868
query79	2541	519	513	513
query80	1143	466	474	466
query81	555	224	225	224
query82	843	111	101	101
query83	365	170	165	165
query84	262	87	86	86
query85	1233	285	270	270
query86	445	311	328	311
query87	3449	3103	3102	3102
query88	4177	2447	2486	2447
query89	459	371	378	371
query90	1797	190	190	190
query91	129	100	102	100
query92	58	51	49	49
query93	1856	511	507	507
query94	1169	191	191	191
query95	412	317	326	317
query96	607	275	277	275
query97	3169	3047	3077	3047
query98	224	202	205	202
query99	1224	821	856	821
Total cold run time: 270035 ms
Total hot run time: 174199 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.74 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 87d2b67aa1ae411f67369eadd4b7ae0245aa4217, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.22	0.05	0.04
query4	1.68	0.07	0.08
query5	0.51	0.49	0.50
query6	1.13	0.72	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.54	0.48	0.48
query10	0.55	0.54	0.55
query11	0.15	0.12	0.12
query12	0.14	0.12	0.13
query13	0.59	0.59	0.59
query14	0.76	0.79	0.79
query15	0.84	0.80	0.81
query16	0.37	0.36	0.34
query17	0.98	0.96	0.94
query18	0.24	0.23	0.26
query19	1.85	1.74	1.74
query20	0.01	0.01	0.01
query21	15.45	0.77	0.67
query22	4.67	6.52	2.08
query23	18.29	1.39	1.24
query24	2.08	0.23	0.24
query25	0.16	0.09	0.08
query26	0.27	0.18	0.17
query27	0.08	0.08	0.08
query28	13.29	1.03	1.01
query29	12.57	3.34	3.32
query30	0.25	0.06	0.06
query31	2.87	0.39	0.38
query32	3.26	0.48	0.46
query33	2.90	2.90	2.86
query34	17.21	4.44	4.43
query35	4.48	4.54	4.47
query36	0.65	0.48	0.47
query37	0.19	0.15	0.16
query38	0.14	0.14	0.14
query39	0.04	0.04	0.03
query40	0.17	0.14	0.14
query41	0.09	0.05	0.04
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.94 s
Total hot run time: 30.74 s

@Jibing-Li
Copy link
Contributor Author

run buildall

morningman
morningman previously approved these changes Jul 3, 2024
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 3, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 40031 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 08c9fc2b0a8a95276f98755e55802b4d0a2f918d, data reload: false

------ Round 1 ----------------------------------
q1	17600	4433	4316	4316
q2	2009	194	192	192
q3	10436	1254	1084	1084
q4	10194	749	726	726
q5	7476	2665	2616	2616
q6	225	136	137	136
q7	953	606	608	606
q8	9247	2085	2080	2080
q9	8921	6498	6491	6491
q10	8917	3714	3736	3714
q11	468	234	238	234
q12	563	237	238	237
q13	17974	3130	3174	3130
q14	270	234	232	232
q15	526	488	480	480
q16	510	397	385	385
q17	981	723	681	681
q18	8235	7558	7448	7448
q19	7168	1507	1464	1464
q20	662	320	324	320
q21	5096	3123	3869	3123
q22	419	336	339	336
Total cold run time: 118850 ms
Total hot run time: 40031 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4403	4256	4237	4237
q2	374	269	265	265
q3	3085	2860	2942	2860
q4	1975	1761	1757	1757
q5	5497	5490	5442	5442
q6	224	130	133	130
q7	2284	1876	1808	1808
q8	3295	3436	3437	3436
q9	8770	8789	8765	8765
q10	4174	3745	3807	3745
q11	614	497	507	497
q12	805	657	651	651
q13	17248	3134	3180	3134
q14	304	286	280	280
q15	544	497	486	486
q16	503	452	443	443
q17	1813	1552	1512	1512
q18	8229	8175	7824	7824
q19	1751	1700	1633	1633
q20	2118	1887	1865	1865
q21	7353	4839	5019	4839
q22	665	567	558	558
Total cold run time: 76028 ms
Total hot run time: 56167 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173080 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 08c9fc2b0a8a95276f98755e55802b4d0a2f918d, data reload: false

query1	926	380	369	369
query2	6451	2468	2403	2403
query3	6651	205	212	205
query4	18978	17575	17245	17245
query5	3717	490	485	485
query6	248	162	160	160
query7	4585	297	282	282
query8	302	289	286	286
query9	8401	2426	2406	2406
query10	572	298	291	291
query11	10464	9958	10069	9958
query12	112	89	80	80
query13	1636	357	351	351
query14	9481	7303	7755	7303
query15	236	189	186	186
query16	7722	304	291	291
query17	1569	543	514	514
query18	1909	267	266	266
query19	189	150	148	148
query20	91	81	79	79
query21	209	132	152	132
query22	4221	3922	3883	3883
query23	33878	33789	33532	33532
query24	11063	2898	2858	2858
query25	608	390	413	390
query26	740	158	153	153
query27	2315	321	328	321
query28	6117	2170	2137	2137
query29	905	659	611	611
query30	263	157	152	152
query31	983	749	777	749
query32	99	52	53	52
query33	760	288	286	286
query34	1057	481	484	481
query35	762	668	624	624
query36	1121	962	975	962
query37	149	86	79	79
query38	2931	2832	2838	2832
query39	920	845	847	845
query40	223	138	129	129
query41	59	54	57	54
query42	112	108	102	102
query43	618	598	582	582
query44	1152	750	728	728
query45	201	167	171	167
query46	1080	718	714	714
query47	1818	1757	1763	1757
query48	366	298	296	296
query49	848	407	407	407
query50	769	377	374	374
query51	6964	6812	6828	6812
query52	104	91	94	91
query53	372	300	297	297
query54	888	434	443	434
query55	76	74	73	73
query56	287	265	264	264
query57	1118	1069	1062	1062
query58	247	232	271	232
query59	3541	3207	3164	3164
query60	325	280	279	279
query61	95	93	91	91
query62	593	448	446	446
query63	338	294	292	292
query64	8546	2269	1765	1765
query65	3175	3099	3137	3099
query66	751	326	332	326
query67	15701	15069	15091	15069
query68	4521	526	534	526
query69	546	488	335	335
query70	1183	1152	1023	1023
query71	367	276	284	276
query72	7203	5800	5359	5359
query73	756	323	321	321
query74	5869	5507	5512	5507
query75	3393	2622	2660	2622
query76	2296	992	967	967
query77	618	292	297	292
query78	10515	8782	9033	8782
query79	3807	521	506	506
query80	2004	480	472	472
query81	607	219	221	219
query82	1363	112	109	109
query83	330	171	169	169
query84	270	90	84	84
query85	1497	279	270	270
query86	421	299	301	299
query87	3294	3082	3057	3057
query88	4384	2352	2334	2334
query89	496	375	372	372
query90	1689	189	186	186
query91	127	99	101	99
query92	56	48	51	48
query93	4765	505	499	499
query94	959	207	210	207
query95	406	319	312	312
query96	595	259	259	259
query97	3188	3035	3070	3035
query98	226	198	201	198
query99	1230	852	843	843
Total cold run time: 272689 ms
Total hot run time: 173080 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.2 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 08c9fc2b0a8a95276f98755e55802b4d0a2f918d, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.03	0.04
query3	0.23	0.06	0.06
query4	1.67	0.08	0.08
query5	0.50	0.49	0.50
query6	1.13	0.74	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.05
query9	0.55	0.48	0.50
query10	0.54	0.53	0.55
query11	0.16	0.11	0.11
query12	0.16	0.12	0.13
query13	0.60	0.59	0.58
query14	0.76	0.77	0.78
query15	0.84	0.80	0.82
query16	0.36	0.36	0.34
query17	1.05	1.05	0.97
query18	0.23	0.25	0.25
query19	1.76	1.67	1.77
query20	0.01	0.01	0.01
query21	15.39	0.77	0.66
query22	3.63	6.70	2.58
query23	18.27	1.39	1.28
query24	2.13	0.23	0.23
query25	0.16	0.09	0.08
query26	0.26	0.17	0.18
query27	0.08	0.08	0.08
query28	13.22	1.01	1.00
query29	12.63	3.29	3.29
query30	0.26	0.06	0.06
query31	2.93	0.39	0.38
query32	3.26	0.48	0.47
query33	2.88	2.90	2.89
query34	17.00	4.39	4.40
query35	4.48	4.53	4.47
query36	0.64	0.47	0.48
query37	0.18	0.15	0.15
query38	0.16	0.15	0.15
query39	0.04	0.03	0.04
query40	0.17	0.14	0.15
query41	0.09	0.05	0.05
query42	0.06	0.04	0.05
query43	0.05	0.04	0.04
Total cold run time: 108.71 s
Total hot run time: 31.2 s

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jul 4, 2024
@Jibing-Li
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39759 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a87ad5d935d4ccbb58270910c4f74c998b465780, data reload: false

------ Round 1 ----------------------------------
q1	17612	5091	4293	4293
q2	2028	195	189	189
q3	10433	1237	1030	1030
q4	10180	709	907	709
q5	7514	2645	2650	2645
q6	220	142	137	137
q7	970	605	616	605
q8	9219	2082	2081	2081
q9	8969	6514	6475	6475
q10	8988	3701	3717	3701
q11	446	237	230	230
q12	459	228	236	228
q13	17768	2986	3005	2986
q14	274	223	227	223
q15	512	470	487	470
q16	511	382	373	373
q17	965	728	673	673
q18	8041	7477	7311	7311
q19	5941	1509	1496	1496
q20	666	321	325	321
q21	4914	3241	3935	3241
q22	405	351	342	342
Total cold run time: 117035 ms
Total hot run time: 39759 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4419	4250	4282	4250
q2	362	264	253	253
q3	2954	2914	2877	2877
q4	2033	1671	1766	1671
q5	5581	5483	5447	5447
q6	222	133	145	133
q7	2221	1871	1853	1853
q8	3271	3432	3404	3404
q9	8674	8709	8710	8709
q10	4190	3788	3764	3764
q11	587	502	499	499
q12	841	671	627	627
q13	15916	3175	3174	3174
q14	299	278	277	277
q15	508	504	488	488
q16	481	442	433	433
q17	1799	1531	1489	1489
q18	8101	7856	7930	7856
q19	1836	1707	1649	1649
q20	2882	1918	1861	1861
q21	5149	5052	4896	4896
q22	632	594	557	557
Total cold run time: 72958 ms
Total hot run time: 56167 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 173261 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a87ad5d935d4ccbb58270910c4f74c998b465780, data reload: false

query1	922	374	379	374
query2	6450	2483	2358	2358
query3	6633	204	206	204
query4	20982	17553	17286	17286
query5	3709	497	492	492
query6	258	166	163	163
query7	4588	296	295	295
query8	334	299	312	299
query9	8664	2453	2437	2437
query10	581	297	297	297
query11	10560	10035	10035	10035
query12	116	87	86	86
query13	1648	377	375	375
query14	9696	6928	7537	6928
query15	232	192	191	191
query16	7800	316	317	316
query17	1664	564	537	537
query18	1958	280	282	280
query19	197	156	153	153
query20	93	82	84	82
query21	212	132	126	126
query22	4182	3998	4272	3998
query23	33793	33491	33721	33491
query24	11149	2936	2940	2936
query25	657	405	398	398
query26	1185	168	160	160
query27	2641	322	331	322
query28	7309	2160	2159	2159
query29	919	666	648	648
query30	265	163	162	162
query31	962	774	747	747
query32	96	54	55	54
query33	768	304	311	304
query34	974	491	485	485
query35	778	645	640	640
query36	1133	979	991	979
query37	154	83	85	83
query38	2964	2812	2882	2812
query39	889	819	857	819
query40	217	142	129	129
query41	58	57	53	53
query42	112	106	109	106
query43	612	571	565	565
query44	1226	757	737	737
query45	203	177	168	168
query46	1095	716	708	708
query47	1865	1774	1795	1774
query48	374	322	308	308
query49	984	419	412	412
query50	763	391	378	378
query51	6825	6885	6695	6695
query52	107	94	89	89
query53	363	292	280	280
query54	893	443	463	443
query55	76	71	71	71
query56	282	269	262	262
query57	1127	1065	1023	1023
query58	254	256	254	254
query59	3457	3310	3176	3176
query60	305	280	262	262
query61	94	92	95	92
query62	605	441	447	441
query63	320	288	287	287
query64	8876	2290	1775	1775
query65	3135	3244	3115	3115
query66	851	328	331	328
query67	15653	15014	14984	14984
query68	8669	564	553	553
query69	735	429	353	353
query70	1351	1148	1138	1138
query71	546	292	288	288
query72	8868	5167	5495	5167
query73	2228	329	320	320
query74	5976	5528	5481	5481
query75	5416	2651	2713	2651
query76	5605	1074	943	943
query77	782	313	303	303
query78	9582	9069	9038	9038
query79	9710	521	528	521
query80	2263	481	473	473
query81	571	219	216	216
query82	377	108	103	103
query83	289	163	159	159
query84	275	84	87	84
query85	993	279	319	279
query86	359	314	310	310
query87	3252	3104	3057	3057
query88	4165	2373	2370	2370
query89	527	393	396	393
query90	2071	185	189	185
query91	129	98	102	98
query92	61	52	49	49
query93	6548	516	525	516
query94	1373	212	209	209
query95	411	316	318	316
query96	616	265	264	264
query97	3202	2983	2997	2983
query98	214	198	186	186
query99	1152	829	858	829
Total cold run time: 297163 ms
Total hot run time: 173261 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.83 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a87ad5d935d4ccbb58270910c4f74c998b465780, data reload: false

query1	0.04	0.03	0.04
query2	0.07	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.07	0.07
query5	0.49	0.49	0.50
query6	1.13	0.74	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.55	0.49	0.49
query10	0.54	0.55	0.54
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.60	0.59
query14	0.77	0.78	0.78
query15	0.84	0.80	0.81
query16	0.37	0.36	0.37
query17	0.95	1.01	1.01
query18	0.22	0.27	0.23
query19	1.75	1.66	1.85
query20	0.02	0.01	0.01
query21	15.39	0.77	0.66
query22	3.48	7.36	2.13
query23	18.33	1.28	1.25
query24	2.14	0.25	0.23
query25	0.16	0.08	0.09
query26	0.27	0.17	0.18
query27	0.08	0.07	0.09
query28	13.17	1.02	0.99
query29	12.60	3.31	3.32
query30	0.24	0.06	0.07
query31	2.84	0.39	0.39
query32	3.27	0.48	0.47
query33	2.91	2.87	2.83
query34	17.11	4.46	4.40
query35	4.48	4.53	4.53
query36	0.65	0.48	0.47
query37	0.18	0.16	0.16
query38	0.15	0.15	0.15
query39	0.04	0.04	0.04
query40	0.16	0.15	0.15
query41	0.09	0.04	0.05
query42	0.05	0.05	0.05
query43	0.04	0.03	0.04
Total cold run time: 108.44 s
Total hot run time: 30.83 s

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 4, 2024
@Jibing-Li Jibing-Li merged commit 94ce626 into apache:master Jul 4, 2024
@Jibing-Li Jibing-Li deleted the rowcount branch July 9, 2024 03:51
Jibing-Li added a commit to Jibing-Li/incubator-doris that referenced this pull request Jul 12, 2024
…ile size. (apache#37218)

Enable fetch hive table row count through file list by default. Change
the sample partition count to 30 to reduce resource consumption.
Using a table with 100000 partition to test the performance. Row count
could be fetch within 0.2 second and the cpu used is less than 1 core.
Jibing-Li added a commit that referenced this pull request Jul 12, 2024
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
…ile size. (#37218)

Enable fetch hive table row count through file list by default. Change
the sample partition count to 30 to reduce resource consumption.
Using a table with 100000 partition to test the performance. Row count
could be fetch within 0.2 second and the cpu used is less than 1 core.
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants