Skip to content

[branch-2.0](timezone) refactor tzdata load to accelerate and unify timezone parsing (#37062) #37270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiaokang merged 1 commit into from
Jul 31, 2024
Merged

[branch-2.0](timezone) refactor tzdata load to accelerate and unify timezone parsing (#37062) #37270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ be/tags
be/test/olap/test_data/tablet_meta_test.hdr
be/.devcontainer/
be/src/apache-orc/
zoneinfo/

## tools
tools/ssb-tools/ssb-data/
Expand Down
4 changes: 0 additions & 4 deletions be/src/common/config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1121,10 +1121,6 @@ DEFINE_Bool(exit_on_exception, "false");

DEFINE_Bool(ignore_always_true_predicate_for_segment, "true");

// Dir of default timezone files
DEFINE_String(default_tzfiles_path, "${DORIS_HOME}/zoneinfo");
DEFINE_Bool(use_doris_tzfile, "false");

// the max package bytes be thrift server can receive
// avoid accepting error or too large package causing OOM,default 20000000(20M)
DEFINE_Int32(be_thrift_max_pkg_bytes, "20000000");
Expand Down
4 changes: 0 additions & 4 deletions be/src/common/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1175,10 +1175,6 @@ DECLARE_mBool(exit_on_exception);
// Remove predicate that is always true for a segment.
DECLARE_Bool(ignore_always_true_predicate_for_segment);

// Dir of default timezone files
DECLARE_String(default_tzfiles_path);
DECLARE_Bool(use_doris_tzfile);

// the max package bytes be thrift server can receive
// avoid accepting error or too large package causing OOM,default 20000000(20M)
DECLARE_Int32(be_thrift_max_pkg_bytes);
Expand Down
1 change: 0 additions & 1 deletion be/src/runtime/exec_env_init.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ Status ExecEnv::_init(const std::vector<StorePath>& store_paths) {
_frontend_client_cache = new FrontendServiceClientCache(config::max_client_cache_size_per_host);
_broker_client_cache = new BrokerServiceClientCache(config::max_client_cache_size_per_host);

TimezoneUtils::load_timezone_names();
TimezoneUtils::load_timezones_to_cache();

ThreadPoolBuilder("SendBatchThreadPool")
Expand Down
Loading