Skip to content

[fix](HadoopLz4BlockCompression)Fixed the bug that HadoopLz4BlockCompression creates _decompressor every time it decompresses.(#37187) #37299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Jul 4, 2024
Merged

[fix](HadoopLz4BlockCompression)Fixed the bug that HadoopLz4BlockCompression creates _decompressor every time it decompresses.(#37187) #37299

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion be/src/util/block_compression.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
defined(__i386) || defined(_M_IX86)
#include <libdeflate.h>
#endif
#include <glog/log_severity.h>
#include <glog/logging.h>
Copy link
Contributor

@github-actions github-actions bot Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: duplicate include [readability-duplicate-include]

be/src/util/block_compression.cpp:27:

- #include <glog/log_severity.h>
- #include <glog/logging.h>
+ #include <glog/log_severity.h>

#include <limits.h>
#include <lz4/lz4.h>
#include <lz4/lz4frame.h>
Expand Down Expand Up @@ -213,12 +215,18 @@ class Lz4BlockCompression : public BlockCompressionCodec {

class HadoopLz4BlockCompression : public Lz4BlockCompression {
public:
HadoopLz4BlockCompression() {
Status st = Decompressor::create_decompressor(CompressType::LZ4BLOCK, &_decompressor);
if (!st.ok()) {
LOG(FATAL) << "HadoopLz4BlockCompression construction failed. status = " << st << "\n";
}
}

static HadoopLz4BlockCompression* instance() {
static HadoopLz4BlockCompression s_instance;
return &s_instance;
}
Status decompress(const Slice& input, Slice* output) override {
RETURN_IF_ERROR(Decompressor::create_decompressor(CompressType::LZ4BLOCK, &_decompressor));
size_t input_bytes_read = 0;
size_t decompressed_len = 0;
size_t more_input_bytes = 0;
Expand Down