Skip to content

[branch-2.1] Picks "[fix](autoinc) Fix AutoIncrementGenerator and add more logs about auto-increment column #37306" #37366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 6, 2024
Merged

[branch-2.1] Picks "[fix](autoinc) Fix AutoIncrementGenerator and add more logs about auto-increment column #37306" #37366

dataroaring merged 1 commit into from
Jul 6, 2024
+40 −29

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Jul 6, 2024

Proposed changes

picks #37306

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 6, 2024

run buildall

@bobhan1 bobhan1 mentioned this pull request Jul 6, 2024
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 6, 2024

TeamCity be ut coverage result:
Function Coverage: 36.33% (9151/25192)
Line Coverage: 27.87% (74694/268039)
Region Coverage: 26.76% (38525/143938)
Branch Coverage: 23.45% (19518/83234)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fad22daba05f2ce69d82d5d00b6c953ec8190c70_fad22daba05f2ce69d82d5d00b6c953ec8190c70/report/index.html

dataroaring pushed a commit that referenced this pull request Jul 6, 2024
@bobhan1
[fix](autoinc) Fix AutoIncrementGenerator and add more logs about aut…
1220324 
…o-increment column (#37306)

## Proposed changes

1. when run out batchEndId in memory, we (1) write edit log to update
batchEndId, (2) update batchEndId in memory, (3) update nextId in memory
2. add more logs about auto-increment column.
3. remove useless `lowerBound`

branch-2.1-pick: #37366
@dataroaring dataroaring merged commit 38b3870 into apache:branch-2.1 Jul 6, 2024
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@bobhan1 @dataroaring
[fix](autoinc) Fix AutoIncrementGenerator and add more logs about aut…
93f2c95 
…o-increment column (#37306)

## Proposed changes

1. when run out batchEndId in memory, we (1) write edit log to update
batchEndId, (2) update batchEndId in memory, (3) update nextId in memory
2. add more logs about auto-increment column.
3. remove useless `lowerBound`

branch-2.1-pick: #37366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bobhan1 @doris-robot @dataroaring