Skip to content

[feature](json)support explode_json_object func #37378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xiaokang merged 15 commits into from
Jul 16, 2024
Merged

[feature](json)support explode_json_object func #37378

xiaokang merged 15 commits into from
Jul 16, 2024

Conversation

@amorynan
Copy link
Contributor

@amorynan amorynan commented Jul 7, 2024 •
edited
Loading

Proposed changes

backport: #36887
Issue Number: close #xxx

@amorynan
Copy link
Contributor Author

amorynan commented Jul 7, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Jul 7, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@amorynan
Copy link
Contributor Author

amorynan commented Jul 8, 2024

run buildall

github-actions[bot]
github-actions bot reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@amorynan
Copy link
Contributor Author

amorynan commented Jul 13, 2024

run buildall

@amorynan
Copy link
Contributor Author

amorynan commented Jul 13, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jul 13, 2024

TeamCity be ut coverage result:
Function Coverage: 36.43% (9191/25229)
Line Coverage: 27.97% (75142/268631)
Region Coverage: 26.85% (38763/144345)
Branch Coverage: 23.55% (19648/83442)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4a3c5c2b850990fc293f04b783dd6299427d3b11_4a3c5c2b850990fc293f04b783dd6299427d3b11/report/index.html

@amorynan
Copy link
Contributor Author

amorynan commented Jul 15, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jul 15, 2024

TeamCity be ut coverage result:
Function Coverage: 36.52% (9260/25356)
Line Coverage: 28.04% (75654/269801)
Region Coverage: 26.87% (38900/144773)
Branch Coverage: 23.60% (19749/83678)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7ce1fc529bf2efcf85cedb60a844fe3728473099_7ce1fc529bf2efcf85cedb60a844fe3728473099/report/index.html

@amorynan
Copy link
Contributor Author

amorynan commented Jul 15, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jul 15, 2024

TeamCity be ut coverage result:
Function Coverage: 36.52% (9261/25359)
Line Coverage: 28.03% (75657/269877)
Region Coverage: 26.86% (38902/144806)
Branch Coverage: 23.60% (19753/83702)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7d49e6affe519d2af3fa449c68aee560d9c6455f_7d49e6affe519d2af3fa449c68aee560d9c6455f/report/index.html

HappenLee
HappenLee approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 16, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2024

PR approved by anyone and no changes requested.

@xiaokang xiaokang merged commit 3cb1d4e into apache:branch-2.1 Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@HappenLee HappenLee HappenLee approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amorynan @doris-robot @HappenLee @xiaokang