[Feature] Add QueryDetail to store query statistics. #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

chaoyli merged 8 commits into apache:master from chaoyli:master

Jun 15, 2020

Contributor

chaoyli commented Jun 1, 2020

Store the query statistics in memory.
Supporting RESTFUL interface to get the statistics.

chaoyli self-assigned this

chaoyli linked an issue

that may be closed by this pull request

[Proposal] Add query monitor detail in FE. #3689

Closed

xy720 reviewed

View reviewed changes

fe/src/main/java/org/apache/doris/qe/ConnectProcessor.java Show resolved Hide resolved

xy720 reviewed

View reviewed changes

fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated Show resolved Hide resolved

kangkaisen reviewed

View reviewed changes

fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated Show resolved Hide resolved

kangkaisen reviewed

View reviewed changes

fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated Show resolved Hide resolved

kangkaisen reviewed

View reviewed changes

fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated Show resolved Hide resolved

kangkaisen reviewed

View reviewed changes

fe/src/main/java/org/apache/doris/qe/SessionVariable.java Outdated Show resolved Hide resolved

kangkaisen reviewed

View reviewed changes

fe/src/main/java/org/apache/doris/qe/QueryDetail.java Show resolved Hide resolved

kangkaisen reviewed

View reviewed changes

fe/src/main/java/org/apache/doris/http/rest/ConnectionAction.java Outdated Show resolved Hide resolved

kangkaisen reviewed

View reviewed changes

fe/src/main/java/org/apache/doris/http/rest/ConnectionAction.java Show resolved Hide resolved

Contributor

kangkaisen commented Jun 1, 2020

@chaoyli Hi, you should add the doc for new http api.

morningman reviewed

View reviewed changes

fe/src/main/java/org/apache/doris/http/rest/ProfileAction.java Show resolved Hide resolved

fe/src/main/java/org/apache/doris/qe/QueryDetail.java Outdated Show resolved Hide resolved

fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated Show resolved Hide resolved

chaoyli closed this

chaoyli reopened this

morningman requested changes

View reviewed changes

fe/src/main/java/org/apache/doris/qe/QueryDetail.java Show resolved Hide resolved

fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Show resolved Hide resolved

fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated Show resolved Hide resolved

fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Outdated Show resolved Hide resolved

morningman reviewed

View reviewed changes

be/src/service/http_service.cpp Outdated Show resolved Hide resolved

morningman requested changes

View reviewed changes

Contributor

morningman left a comment

Next time, please DO NOT modify multiple unrelated modules in one PR. If you need to make changes, please submit multiple PRs, or specify the changes you made in the comment.

In this PR, you try to modify:

Some configuration defaults
Units of monitoring indicators
Delete some default logs
QueryDetails related changes

There 4 changes seems unrelated.

docs/zh-CN/administrator-guide/http-actions/connection-action.md Outdated Show resolved Hide resolved

docs/zh-CN/administrator-guide/http-actions/connection-action.md Outdated Show resolved Hide resolved

docs/zh-CN/administrator-guide/http-actions/connection-action.md Outdated Show resolved Hide resolved

docs/zh-CN/administrator-guide/http-actions/query-detail-action.md Outdated Show resolved Hide resolved

docs/zh-CN/administrator-guide/http-actions/query-detail-action.md Outdated Show resolved Hide resolved

fe/src/main/java/org/apache/doris/common/Log4jConfig.java Show resolved Hide resolved

fe/src/main/java/org/apache/doris/PaloFe.java Show resolved Hide resolved

fe/src/main/java/org/apache/doris/qe/QueryDetailQueue.java Show resolved Hide resolved

chaoyli added 8 commits

June 15, 2020 17:31


          [Feature] Add QueryDetail to store query statistics.

e0acd0b

1. Store the query statistics in memory.
2. Supporting RESTFUL interface to get the statistics.


          Fix unit bug

9500aac


          Fix the bug

4bbd061


          Fix some metrics interface

0e368f5


          Fix bug

16668cd


          Add docs

65dd79d


          Add some docs

a93a0a5


          Add unit test for QueryDetailQueue

393d20d

morningman approved these changes

View reviewed changes

Contributor

morningman left a comment

LGTM

morningman added approved area/metrics kind/improvement labels

morningman added the api-review label

chaoyli merged commit 6c4d7c6 into apache:master

morningman mentioned this pull request

[Fix][Bug] Fix compile and UT bug #3888

Merged

baidu-doris pushed a commit to baidu-doris/incubator-doris that referenced this pull request


          [Feature] Add QueryDetail to store query statistics. (apache#3744)

39fa777

1. Store the query statistics in memory.
2. Supporting RESTFUL interface to get the statistics.

hubgeter pushed a commit to hubgeter/doris that referenced this pull request


          [Bug](runtime-filter) fix missing rf when target not exist on backend…

c70b1eb

… where the producer is located apache#47108 (apache#3744)

Sometimes the consumer of a certain rf does not exist on the BE where
the producer of a certain rf is located. At this time, the send to
remote operation of the rf will cause problems and the rf will be lost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-review approved area/metrics kind/improvement