[Bug] Fix a bug that tablet may be modified to BETA_ROWSET after cloned #3750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to BETA_ROWSET after cloned TabletMeta's _preferred_rowset_type is not initialized after object constructing and may be a random value, and this field is not updated when create ALPHA_ROWSET tablet, and it will not be serialized into pb in this case. So if cloning an ALPHA_ROWSET tablet from another BE, this new created local tablet's _preferred_rowset_type field may be random as BETA_ROWSET and can not be overwrote after cloned, then new input rows will be wrote as BETA_ROWSET format which is not we expect. This patch fix this bug by giving _preferred_rowset_type a default value and updating this field when create any type of tablet, and add an unit test and related overwrite equal operator functions.
morningman
reviewed
Jun 2, 2020
morningman
added
area/storage
imay
reviewed
Jun 4, 2020
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jun 7, 2020
…to BETA_ROWSET after cloned (apache#3750) TabletMeta's _preferred_rowset_type is not initialized after object constructing and may be a random value, and this field is not updated when create ALPHA_ROWSET tablet, and it will not be serialized into pb in this case. So if cloning an ALPHA_ROWSET tablet from another BE, this new created local tablet's _preferred_rowset_type field may be random as BETA_ROWSET and can not be overwrote after cloned, then new input rows will be wrote as BETA_ROWSET format which is not we expect. This patch fix this bug by giving _preferred_rowset_type a default value and updating this field when create any type of tablet, and add an unit test and related overwrite equal operator functions.
acelyc111
added a commit
to acelyc111/incubator-doris
that referenced
this pull request
Jan 20, 2021
…to BETA_ROWSET after cloned (apache#3750) TabletMeta's _preferred_rowset_type is not initialized after object constructing and may be a random value, and this field is not updated when create ALPHA_ROWSET tablet, and it will not be serialized into pb in this case. So if cloning an ALPHA_ROWSET tablet from another BE, this new created local tablet's _preferred_rowset_type field may be random as BETA_ROWSET and can not be overwrote after cloned, then new input rows will be wrote as BETA_ROWSET format which is not we expect. This patch fix this bug by giving _preferred_rowset_type a default value and updating this field when create any type of tablet, and add an unit test and related overwrite equal operator functions.
hubgeter
pushed a commit
to hubgeter/doris
that referenced
this pull request
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TabletMeta's _preferred_rowset_type is not initialized after object constructing and
may be a random value, and this field is not updated when create ALPHA_ROWSET tablet,
and it will not be serialized into pb in this case. So if cloning an ALPHA_ROWSET
tablet from another BE, this new created local tablet's _preferred_rowset_type field
may be random as BETA_ROWSET and can not be overwrote after cloned, then new input
rows will be wrote as BETA_ROWSET format which is not we expect.
This patch fix this bug by giving _preferred_rowset_type a default value and updating
this field when create any type of tablet, and add an unit test and related overwrite
equal operator functions.