Skip to content

[fix](memory) Modified low water mark=min(6.4G, MemTotal * 5%) #37525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xinyiZzz merged 2 commits into from
Jul 11, 2024
Merged

[fix](memory) Modified low water mark=min(6.4G, MemTotal * 5%) #37525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c69d162
1
xinyiZzz Jul 9, 2024
1f2248c
Merge branch 'master' into 20240707_fix_avai_conf
xinyiZzz Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions be/src/common/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,9 @@ DECLARE_mInt32(max_fill_rate);
DECLARE_mInt32(double_resize_threshold);

// The maximum low water mark of the system `/proc/meminfo/MemAvailable`, Unit byte, default 6.4G,
// actual low water mark=min(6.4G, MemTotal * 10%), avoid wasting too much memory on machines
// with large memory larger than 64G.
// Turn up max. On machines with more than 64G memory, more memory buffers will be reserved for Full GC.
// actual low water mark=min(6.4G, MemTotal * 5%), avoid wasting too much memory on machines
// with large memory larger than 128G.
// Turn up max. On machines with more than 128G memory, more memory buffers will be reserved for Full GC.
// Turn down max. will use as much memory as possible.
DECLARE_Int64(max_sys_mem_available_low_water_mark_bytes);

Expand Down
2 changes: 1 addition & 1 deletion be/src/util/mem_info.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ void MemInfo::init() {
// upper sys_mem_available_low_water_mark, avoid wasting too much memory.
_s_sys_mem_available_low_water_mark = std::max<int64_t>(
std::min<int64_t>(std::min<int64_t>(_s_physical_mem - _s_mem_limit,
int64_t(_s_physical_mem * 0.1)),
int64_t(_s_physical_mem * 0.05)),
config::max_sys_mem_available_low_water_mark_bytes),
0);
_s_sys_mem_available_warning_water_mark = _s_sys_mem_available_low_water_mark * 2;
Expand Down