Skip to content

[fix](move-memtable) check segment num when closing each tablet (#36753) #37536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liaoxin01 merged 2 commits into from
Jul 11, 2024
Merged

[fix](move-memtable) check segment num when closing each tablet (#36753) #37536

liaoxin01 merged 2 commits into from
Jul 11, 2024

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Jul 9, 2024 •
edited
Loading

cherry-pick #36753 and #37660

@doris-robot
Copy link

doris-robot commented Jul 9, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaijchen
Copy link
Member Author

kaijchen commented Jul 9, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2024

clang-tidy review says "All clean, LGTM! 👍"

@kaijchen
[fix](move-memtable) check segment num when closing each tablet (apac…
e9d9d8a 
…he#36753)

Previously, there is chance that sender failed to send some data while
the receiver being unaware of.
This will cause lost data if some segments are skipped.

This PR fixes the problem by including checks in both sender and
receiver.
When sender failed to send rpc, LoadStreamStub will mark the involved
tablets failed.
Each sender will send segment num for each tablet in CLOSE_LOAD,
and receivers (LoadStream) will sum up and check total segment nums.
@kaijchen
Copy link
Member Author

kaijchen commented Jul 10, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2024

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2024

PR approved by anyone and no changes requested.

@kaijchen
Copy link
Member Author

kaijchen commented Jul 11, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 11, 2024

TeamCity be ut coverage result:
Function Coverage: 36.36% (9162/25199)
Line Coverage: 27.90% (74867/268357)
Region Coverage: 26.80% (38638/144158)
Branch Coverage: 23.49% (19577/83350)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c748b2e3b1b6969c2b1874e32bf70ce542c9471d_c748b2e3b1b6969c2b1874e32bf70ce542c9471d/report/index.html

@liaoxin01
Copy link
Contributor

liaoxin01 commented Jul 11, 2024

run p0

@liaoxin01 liaoxin01 merged commit fed632b into apache:branch-2.1 Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. meta-change reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaijchen @doris-robot @liaoxin01