[fix](dynamic partition) drop partition exclude history_partition_num #37539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
need re-format FE |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39675 ms |
TPC-DS: Total hot run time: 174239 ms |
ClickBench: Total hot run time: 30.34 s |
Contributor
Author
|
run external |
Contributor
Author
|
run p1 |
Contributor
Author
|
run cloud_p1 |
Contributor
Author
|
run p0 |
1 similar comment
Contributor
Author
|
run p0 |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run p1 |
Contributor
Author
|
run cloud_p1 |
Contributor
Author
|
run external |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
run buildall |
github-actions
bot
removed
the
approved
dataroaring
force-pushed
the
fix-dynamic-partition-drop-partition
branch
from
862d9c7 to
86af736
Compare
Contributor
|
run buildall |
TPC-H: Total hot run time: 39415 ms |
TPC-DS: Total hot run time: 173448 ms |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
ClickBench: Total hot run time: 30.38 s |
dataroaring
added a commit
that referenced
this pull request
Jul 9, 2024
…#37539) FIX: When dropping dynamic partition, PR #35778 will use math.max(start, -history_partition_num) as the first partition, but it may delete users' partitions if they specify both start and history_partition_num inappropriately. For safety reason, revert this behavious changed, only use start as the first partition when dropping partitions. For those who had specified a very small start value, drop partitions will catch an exception , and stop dropping this table's partition and then record this error in dynamic info. Users can use command `SHOW DYNAMIC PARTITION TABLES FROM DBXXX` to know this error. From this error, it will give user hint to modify start if they really specify a error start. --------- Co-authored-by: Yongqiang YANG <98214048+dataroaring@users.noreply.github.com>
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Jul 10, 2024
…apache#37539) FIX: When dropping dynamic partition, PR apache#35778 will use math.max(start, -history_partition_num) as the first partition, but it may delete users' partitions if they specify both start and history_partition_num inappropriately. For safety reason, revert this behavious changed, only use start as the first partition when dropping partitions. For those who had specified a very small start value, drop partitions will catch an exception , and stop dropping this table's partition and then record this error in dynamic info. Users can use command `SHOW DYNAMIC PARTITION TABLES FROM DBXXX` to know this error. From this error, it will give user hint to modify start if they really specify a error start. --------- Co-authored-by: Yongqiang YANG <98214048+dataroaring@users.noreply.github.com>
yujun777
added a commit
to yujun777/doris
that referenced
this pull request
Jul 10, 2024
…apache#37539) FIX: When dropping dynamic partition, PR apache#35778 will use math.max(start, -history_partition_num) as the first partition, but it may delete users' partitions if they specify both start and history_partition_num inappropriately. For safety reason, revert this behavious changed, only use start as the first partition when dropping partitions. For those who had specified a very small start value, drop partitions will catch an exception , and stop dropping this table's partition and then record this error in dynamic info. Users can use command `SHOW DYNAMIC PARTITION TABLES FROM DBXXX` to know this error. From this error, it will give user hint to modify start if they really specify a error start. --------- Co-authored-by: Yongqiang YANG <98214048+dataroaring@users.noreply.github.com>
xiaokang
pushed a commit
that referenced
this pull request
Jul 10, 2024
dataroaring
added a commit
that referenced
this pull request
Jul 10, 2024
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
zxealous
reviewed
Sep 6, 2024
| addPartitionClauses = getAddPartitionClause(db, olapTable, partitionColumn, partitionFormat, | ||
| executeFirstTime); | ||
| } | ||
| clearDropPartitionFailedMsg(olapTable.getId()); |
Contributor
There was a problem hiding this comment.
why call clearDropPartitionFailedMsg() here?
Contributor
There was a problem hiding this comment.
This will cause the status to remain NORMAL even if add partition failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX:
When dropping dynamic partition, PR #35778 will use math.max(start, -history_partition_num) as the first partition, but it may delete users' partitions if they specify both start and history_partition_num inappropriately. For safety reason, revert this behavious changed, only use start as the first partition when dropping partitions.
For those who had specified a very small start value, drop partitions will catch an exception , and stop dropping this table's partition and then record this error in dynamic info. Users can use command
SHOW DYNAMIC PARTITION TABLES FROM DBXXXto know this error. From this error, it will give user hint to modify start if they really specify a error start.