Skip to content

[improvement](jdbc catalog) Catch AbstractMethodError in getColumnValue Method and Suggest Updating to ojdbc8+ #37608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zy-kkk merged 1 commit into from
Jul 11, 2024
Merged

[improvement](jdbc catalog) Catch AbstractMethodError in getColumnValue Method and Suggest Updating to ojdbc8+ #37608

zy-kkk merged 1 commit into from
Jul 11, 2024

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Jul 10, 2024

Catch AbstractMethodError in getColumnValue method.
Provide a clear error message suggesting the use of ojdbc8 or higher versions to avoid compatibility issues.

@zy-kkk
[improvement](jdbc catalog) Catch AbstractMethodError in `getColumn…
370c2a8 
…Value` Method and Suggest Updating to ojdbc8+
@zy-kkk
Copy link
Member Author

zy-kkk commented Jul 10, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jul 10, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@doris-robot
Copy link

doris-robot commented Jul 10, 2024

TPC-H: Total hot run time: 39827 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 370c2a8025380f6c98fc115498352f4d7e174ed4, data reload: false

------ Round 1 ----------------------------------
q1	17688	4354	4268	4268
q2	2010	189	195	189
q3	10450	1137	1224	1137
q4	10187	771	758	758
q5	7581	2636	2583	2583
q6	217	136	135	135
q7	951	595	608	595
q8	9223	2061	2031	2031
q9	9044	6496	6503	6496
q10	9035	3728	3723	3723
q11	453	235	238	235
q12	497	224	224	224
q13	17784	2952	2988	2952
q14	260	234	223	223
q15	512	479	485	479
q16	511	403	374	374
q17	955	679	707	679
q18	7935	7444	7407	7407
q19	5541	1456	1438	1438
q20	646	329	323	323
q21	4903	3896	3240	3240
q22	387	338	343	338
Total cold run time: 116770 ms
Total hot run time: 39827 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4355	4265	4239	4239
q2	367	269	276	269
q3	2988	2817	2863	2817
q4	2095	1631	1681	1631
q5	5623	5499	5470	5470
q6	217	133	130	130
q7	2175	1892	1867	1867
q8	3287	3386	3415	3386
q9	8689	8745	8760	8745
q10	4050	3823	3699	3699
q11	586	487	509	487
q12	844	617	645	617
q13	15904	3156	3193	3156
q14	313	282	289	282
q15	534	479	484	479
q16	495	434	438	434
q17	1816	1550	1519	1519
q18	8113	8101	7961	7961
q19	1805	1700	1507	1507
q20	2163	1893	1863	1863
q21	5073	5072	4677	4677
q22	621	557	573	557
Total cold run time: 72113 ms
Total hot run time: 55792 ms

@doris-robot
Copy link

doris-robot commented Jul 10, 2024

TPC-DS: Total hot run time: 171368 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 370c2a8025380f6c98fc115498352f4d7e174ed4, data reload: false

query1	918	370	365	365
query2	6451	2466	2436	2436
query3	6631	204	209	204
query4	27490	17436	17381	17381
query5	3686	483	486	483
query6	284	173	167	167
query7	4584	301	288	288
query8	325	324	295	295
query9	8514	2363	2346	2346
query10	435	275	274	274
query11	10441	9897	9961	9897
query12	113	84	85	84
query13	1627	379	368	368
query14	10151	7361	7641	7361
query15	230	180	183	180
query16	7560	301	305	301
query17	1569	547	538	538
query18	1310	274	275	274
query19	185	150	155	150
query20	90	84	78	78
query21	202	127	122	122
query22	4424	4061	3997	3997
query23	33845	33868	33637	33637
query24	11193	2844	2850	2844
query25	632	395	377	377
query26	1041	152	152	152
query27	2702	282	284	282
query28	7322	2115	2099	2099
query29	864	639	625	625
query30	257	149	163	149
query31	996	764	742	742
query32	93	54	51	51
query33	757	297	293	293
query34	1018	496	507	496
query35	668	567	567	567
query36	1107	978	986	978
query37	150	83	84	83
query38	2947	2861	2784	2784
query39	899	861	826	826
query40	207	121	116	116
query41	56	50	50	50
query42	123	99	103	99
query43	585	556	558	556
query44	1209	753	733	733
query45	193	164	166	164
query46	1111	721	731	721
query47	1818	1775	1773	1773
query48	377	309	300	300
query49	848	407	410	407
query50	784	394	417	394
query51	6887	6836	6800	6800
query52	105	94	93	93
query53	359	288	304	288
query54	894	449	447	447
query55	76	74	74	74
query56	289	259	271	259
query57	1089	1055	1024	1024
query58	257	267	262	262
query59	3578	3240	3529	3240
query60	302	292	276	276
query61	100	102	145	102
query62	798	633	653	633
query63	328	296	291	291
query64	9493	2212	1669	1669
query65	3182	3102	3094	3094
query66	764	325	329	325
query67	15268	14844	15152	14844
query68	4559	550	542	542
query69	617	471	353	353
query70	1197	1095	1130	1095
query71	438	290	290	290
query72	7517	2789	2603	2603
query73	743	319	324	319
query74	5943	5543	5443	5443
query75	3422	2686	2668	2668
query76	2849	970	974	970
query77	639	297	310	297
query78	11847	9278	8921	8921
query79	3591	522	522	522
query80	1512	478	488	478
query81	592	215	219	215
query82	609	142	134	134
query83	336	174	176	174
query84	354	91	89	89
query85	721	303	307	303
query86	437	316	301	301
query87	3226	3053	3088	3053
query88	4413	2445	2430	2430
query89	473	390	392	390
query90	1967	192	195	192
query91	132	103	104	103
query92	67	48	49	48
query93	4265	520	513	513
query94	1063	218	218	218
query95	409	319	311	311
query96	614	274	274	274
query97	3210	3070	3055	3055
query98	235	242	196	196
query99	1499	1260	1265	1260
Total cold run time: 284287 ms
Total hot run time: 171368 ms

@doris-robot
Copy link

doris-robot commented Jul 10, 2024

ClickBench: Total hot run time: 30.94 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 370c2a8025380f6c98fc115498352f4d7e174ed4, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.70	0.07	0.07
query5	0.51	0.50	0.49
query6	1.14	0.72	0.72
query7	0.01	0.01	0.02
query8	0.05	0.04	0.05
query9	0.54	0.50	0.50
query10	0.54	0.52	0.54
query11	0.14	0.11	0.12
query12	0.16	0.13	0.12
query13	0.60	0.59	0.58
query14	0.73	0.79	0.77
query15	0.85	0.82	0.82
query16	0.36	0.37	0.37
query17	1.06	0.98	0.97
query18	0.23	0.22	0.22
query19	1.79	1.73	1.72
query20	0.01	0.01	0.02
query21	15.41	0.77	0.66
query22	3.69	7.17	2.23
query23	18.24	1.32	1.23
query24	2.11	0.24	0.23
query25	0.16	0.09	0.08
query26	0.28	0.20	0.19
query27	0.45	0.22	0.23
query28	13.60	1.01	1.00
query29	12.90	3.34	3.31
query30	0.26	0.06	0.07
query31	2.88	0.39	0.38
query32	3.29	0.48	0.45
query33	2.85	2.96	2.93
query34	17.06	4.34	4.38
query35	4.41	4.44	4.44
query36	0.66	0.46	0.46
query37	0.19	0.16	0.16
query38	0.15	0.15	0.14
query39	0.05	0.03	0.03
query40	0.15	0.13	0.12
query41	0.09	0.05	0.04
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.73 s
Total hot run time: 30.94 s

morningman
morningman approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2024

PR approved by anyone and no changes requested.

@zy-kkk zy-kkk merged commit 3c1488c into apache:master Jul 11, 2024
@zy-kkk zy-kkk deleted the ojdbc6 branch July 11, 2024 01:58
zy-kkk added a commit to zy-kkk/doris that referenced this pull request Jul 11, 2024
@zy-kkk
[improvement](jdbc catalog) Catch AbstractMethodError in `getColumn…
0720b33 
…Value` Method and Suggest Updating to ojdbc8+ (apache#37608)

Catch AbstractMethodError in getColumnValue method.
Provide a clear error message suggesting the use of ojdbc8 or higher
versions to avoid compatibility issues.
@zy-kkk zy-kkk mentioned this pull request Jul 11, 2024
Merged
zy-kkk added a commit that referenced this pull request Jul 11, 2024
@zy-kkk
[branch-2.1][improvement](jdbc catalog) Catch AbstractMethodError i…
ef75448 
…n `getColumnValue` Method and Suggest Updating to ojdbc8+ (#37634)

pick (#37608)

Catch AbstractMethodError in getColumnValue method. Provide a clear
error message suggesting the use of ojdbc8 or higher versions to avoid
compatibility issues.
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
@zy-kkk @seawinde
[improvement](jdbc catalog) Catch AbstractMethodError in `getColumn…
6e85b6c 
…Value` Method and Suggest Updating to ojdbc8+ (apache#37608)

Catch AbstractMethodError in getColumnValue method.
Provide a clear error message suggesting the use of ojdbc8 or higher
versions to avoid compatibility issues.
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@zy-kkk @dataroaring
[improvement](jdbc catalog) Catch AbstractMethodError in `getColumn…
f7dd16e 
…Value` Method and Suggest Updating to ojdbc8+ (#37608)

Catch AbstractMethodError in getColumnValue method.
Provide a clear error message suggesting the use of ojdbc8 or higher
versions to avoid compatibility issues.
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@AshinGau AshinGau AshinGau approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zy-kkk @doris-robot @morningman @AshinGau @dataroaring