Skip to content

[fix](cloud) fix analyze compound predicate exception when show copy #37656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Jul 12, 2024
Merged

[fix](cloud) fix analyze compound predicate exception when show copy #37656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fe/fe-core/src/main/java/org/apache/doris/analysis/ShowCopyStmt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ protected void analyzeCompoundPredicate(Expr cp) throws AnalysisException {
}
}

protected void analyzeCompoundPredicate(Expr expr, List<Expr> exprs) throws AnalysisException {
private void analyzeCompoundPredicate(Expr expr, List<Expr> exprs) throws AnalysisException {
if (expr instanceof CompoundPredicate) {
CompoundPredicate cp = (CompoundPredicate) expr;
if (cp.getOp() != CompoundPredicate.Operator.AND) {
Expand Down
10 changes: 1 addition & 9 deletions fe/fe-core/src/main/java/org/apache/doris/analysis/ShowLoadStmt.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,15 +164,7 @@ public void analyze(Analyzer analyzer) throws AnalysisException, UserException {
// analyze where clause if not null
if (whereClause != null) {
if (whereClause instanceof CompoundPredicate) {
CompoundPredicate cp = (CompoundPredicate) whereClause;
if (cp.getOp() != org.apache.doris.analysis.CompoundPredicate.Operator.AND) {
throw new AnalysisException("Only allow compound predicate with operator AND");
}

// check whether left.columnName equals to right.columnName
checkPredicateName(cp.getChild(0), cp.getChild(1));
analyzeSubPredicate(cp.getChild(0));
analyzeSubPredicate(cp.getChild(1));
analyzeCompoundPredicate(whereClause);
} else {
analyzeSubPredicate(whereClause);
}
Expand Down