[Enhancement](delete) Modify some p2 delete cases' property #37689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Collaborator
Author
|
run buildall |
1 similar comment
Collaborator
Author
|
run buildall |
bobhan1
approved these changes
Aug 4, 2024
Yukang-Lian
force-pushed
the
Modify-P2-Delete-Property
branch
from
3f924c1 to
31d5d40
Compare
Collaborator
Author
|
run buildall |
Contributor
|
PR approved by anyone and no changes requested. |
gavinchou
approved these changes
Sep 13, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
dataroaring
pushed a commit
that referenced
this pull request
Oct 9, 2024
In #35917 and #37151, we changed MOW table default delete command from delete predicate to delete sign. It makes sure the correctness during partial update but leads to slowdowns. Actually, if there is no partial update, delete predicate will not lead to data fault. Delete data by delete predicate or delete sign can be controlled by a table property "enable_light_delete". If "enable_light_delete=true", we execute delete command by delete predicate. Otherwise, we execute delete command by delete sign. In p2 cases, there are lots of cases with large data need to delete and do not perform partial column update operations. Therefore, in order to make it faster, we change some cases default create table clause.
Yukang-Lian
added a commit
to Yukang-Lian/doris
that referenced
this pull request
Oct 12, 2024
…7689) In apache#35917 and apache#37151, we changed MOW table default delete command from delete predicate to delete sign. It makes sure the correctness during partial update but leads to slowdowns. Actually, if there is no partial update, delete predicate will not lead to data fault. Delete data by delete predicate or delete sign can be controlled by a table property "enable_light_delete". If "enable_light_delete=true", we execute delete command by delete predicate. Otherwise, we execute delete command by delete sign. In p2 cases, there are lots of cases with large data need to delete and do not perform partial column update operations. Therefore, in order to make it faster, we change some cases default create table clause.
Yukang-Lian
added a commit
to Yukang-Lian/doris
that referenced
this pull request
Oct 12, 2024
…7689) In apache#35917 and apache#37151, we changed MOW table default delete command from delete predicate to delete sign. It makes sure the correctness during partial update but leads to slowdowns. Actually, if there is no partial update, delete predicate will not lead to data fault. Delete data by delete predicate or delete sign can be controlled by a table property "enable_light_delete". If "enable_light_delete=true", we execute delete command by delete predicate. Otherwise, we execute delete command by delete sign. In p2 cases, there are lots of cases with large data need to delete and do not perform partial column update operations. Therefore, in order to make it faster, we change some cases default create table clause.
dataroaring
pushed a commit
that referenced
this pull request
Oct 12, 2024
dataroaring
added
dev/2.1.7-merged
dev/2.0.16-merged
dev/3.0.3-merged
and removed
dev/3.0.x
labels
dataroaring
pushed a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
In #35917 and #37151, we changed MOW table default delete command from delete predicate to delete sign. It makes sure the correctness during partial update but leads to slowdowns. Actually, if there is no partial update, delete predicate will not lead to data fault. Delete data by delete predicate or delete sign can be controlled by a table property "enable_light_delete". If "enable_light_delete=true", we execute delete command by delete predicate. Otherwise, we execute delete command by delete sign.
In p2 cases, there are lots of cases with large data need to delete and do not perform partial column update operations. Therefore, in order to make it faster, we change some cases default create table clause.