Skip to content

[improve](load) reduce memory reserved in memtable limiter (#37511) #37699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liaoxin01 merged 2 commits into from
Jul 15, 2024
Merged

[improve](load) reduce memory reserved in memtable limiter (#37511) #37699

liaoxin01 merged 2 commits into from
Jul 15, 2024

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented Jul 12, 2024

cherry-pick #37511

@kaijchen
[improve](load) reduce memory reserved in memtable limiter (apache#37511
fef9384 
)

causing memtable memory limiter reserving too much memory.

This PR adds a BE config `memtable_limiter_reserved_memory_bytes`,
defaults to 800MB, which defines bytes reserved in memtable memory
limiter.
@doris-robot
Copy link

doris-robot commented Jul 12, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaijchen
Copy link
Member Author

kaijchen commented Jul 12, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2024

clang-tidy review says "All clean, LGTM! 👍"

@kaijchen
Copy link
Member Author

kaijchen commented Jul 13, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 13, 2024

TeamCity be ut coverage result:
Function Coverage: 36.60% (9270/25328)
Line Coverage: 28.12% (75833/269655)
Region Coverage: 26.93% (38969/144692)
Branch Coverage: 23.63% (19779/83696)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6b5860ad94c3f49944efbf81d386c2db74085bc8_6b5860ad94c3f49944efbf81d386c2db74085bc8/report/index.html

@liaoxin01 liaoxin01 merged commit 232202b into apache:branch-2.1 Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaijchen @doris-robot @liaoxin01