-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhancement](compaction) Control the parallelism for urgent compaction tasks #37782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement](compaction) Control the parallelism for urgent compaction tasks #37782
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40273 ms |
TPC-DS: Total hot run time: 173381 ms |
ClickBench: Total hot run time: 30.72 s |
|
run buildall |
TPC-H: Total hot run time: 40142 ms |
TPC-DS: Total hot run time: 173918 ms |
ClickBench: Total hot run time: 31.16 s |
|
run p0 |
be/src/olap/olap_server.cpp
Outdated
| copied_base_map = _tablet_submitted_base_compaction; | ||
| } | ||
| auto stores = get_stores(); | ||
| bool is_busy = std::none_of( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too many indentions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
|
clang-tidy review says "All clean, LGTM! 👍" |
b29fefc to
7327080
Compare
7327080 to
8d32cb2
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40006 ms |
TPC-DS: Total hot run time: 172959 ms |
ClickBench: Total hot run time: 30.47 s |
|
PR approved by anyone and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…on tasks (#37782) ## Proposed changes For some urgent compaction tasks, their submittion should take parallelism into account. Currently, we apply the control policy for data loading in specific. Other source of urgent tasks are considered as eager.
…on tasks (apache#37782) For some urgent compaction tasks, their submittion should take parallelism into account. Currently, we apply the control policy for data loading in specific. Other source of urgent tasks are considered as eager.
Proposed changes
For some urgent compaction tasks, their submittion should take parallelism into account.
Currently, we apply the control policy for data loading in specific. Other source of urgent tasks are considered as eager.