-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](nereids) fix aggr node colocate flag which local shuffle depending on #37788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](nereids) fix aggr node colocate flag which local shuffle depending on #37788
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 40129 ms |
TPC-DS: Total hot run time: 172908 ms |
ClickBench: Total hot run time: 31.31 s |
|
run p0 |
|
run p0 |
7f20fe7 to
e7823ff
Compare
|
run buildall |
TPC-H: Total hot run time: 39539 ms |
TPC-DS: Total hot run time: 173734 ms |
ClickBench: Total hot run time: 30.56 s |
|
run buildall |
TPC-H: Total hot run time: 39893 ms |
TPC-DS: Total hot run time: 173554 ms |
ClickBench: Total hot run time: 31.47 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Local shuffle depends on the operator node's isColocate flag, to decide the shuffle columns.
Current aggr node's isColocate true setting is too strict to support shuffle-colocate scenarios.
This pr releases the unnecessary restriction (only support table scan) and sets the flag true expectly.