-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhancement](log)Updated the default setting of sys_log_mode in fe.conf for better performance #37793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…onf from NORMAL to ASYNC for better performance.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
caiconghui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 40120 ms |
TPC-DS: Total hot run time: 173011 ms |
ClickBench: Total hot run time: 30.24 s |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need modify Config.java too
…ig.java from NORMAL to ASYNC for better performance.
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 39648 ms |
TPC-DS: Total hot run time: 173904 ms |
ClickBench: Total hot run time: 30.91 s |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Do not pick to 2.1 now, we should check it on master. |
…onf for better performance (apache#37793) ## Proposed changes <!--Describe your changes.--> Updated the default setting of `sys_log_mode` in `fe.conf` from `NORMAL` to `ASYNC` for better performance.
…onf for better performance (#37793) ## Proposed changes <!--Describe your changes.--> Updated the default setting of `sys_log_mode` in `fe.conf` from `NORMAL` to `ASYNC` for better performance.
followup #37793 NORMAL: sync flush + with location ASYNC(default): async flush + with location BRIEF: async flush + without location
followup #37793 NORMAL: sync flush + with location ASYNC(default): async flush + with location BRIEF: async flush + without location
Proposed changes
Updated the default setting of
sys_log_modeinfe.conffromNORMALtoASYNCfor better performance.