[Bug](join) avoid overflow on bucket_size+1 #37807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Proposed changes avoid overflow on bucket_size+1 ```cpp *** Query id: 7371b4516f5b475f-8c060d33a27ffde0 *** *** is nereids: 1 *** *** tablet id: 0 *** *** Aborted at 1720441228 (unix time) try "date -d @1720441228" if you are using GNU date *** *** Current BE git commitID: 2c9d3af *** *** SIGSEGV address not mapped to object (@0x7fec499d5be8) received by PID 466196 (TID 470466 OR 0x7fe5411fc700) from PID 1235049448; stack trace: *** 0# 0x0000561B81AFD533 in /mnt/disk1/xiaolei/incubator-doris/output/be/lib/doris_be 1# 0x00007FEC26D7FB50 in /lib64/libc.so.6 2# doris::Status doris::pipeline::ProcessHashTableBuild<doris::vectorized::MethodOneNumber<unsigned char, doris::JoinHashTable<unsigned char, HashCRC32<unsigned char> > > >::run<0, false, false, false>(doris::vectorized::MethodOneNumber<unsigned char, doris::JoinHashTable<unsigned char, HashCRC32<unsigned char> > >&, doris::vectorized::PODArray<unsigned char, 4096ul, Allocator<false, false, false>, 16ul, 15ul> const*, bool*) in /mnt/disk1/xiaolei/incubator-doris/output/be/lib/doris_be 3# 0x0000561B8AAE8B90 in /mnt/disk1/xiaolei/incubator-doris/output/be/lib/doris_be 4# doris::pipeline::HashJoinBuildSinkLocalState::process_build_block(doris::RuntimeState*, doris::vectorized::Block&) in /mnt/disk1/xiaolei/incubator-doris/output/be/lib/doris_be 5# doris::pipeline::HashJoinBuildSinkOperatorX::sink(doris::RuntimeState*, doris::vectorized::Block*, bool) in /mnt/disk1/xiaolei/incubator-doris/output/be/lib/doris_be 6# doris::pipeline::PipelineTask::execute(bool*) in /mnt/disk1/xiaolei/incubator-doris/output/be/lib/doris_be 7# doris::pipeline::TaskScheduler::_do_work(unsigned long) in /mnt/disk1/xiaolei/incubator-doris/output/be/lib/doris_be 8# doris::ThreadPool::dispatch_thread() in /mnt/disk1/xiaolei/incubator-doris/output/be/lib/doris_be 9# doris::Thread::supervise_thread(void*) in /mnt/disk1/xiaolei/incubator-doris/output/be/lib/doris_be 10# start_thread in /lib64/libpthread.so.0 11# __clone in /lib64/libc.so.6 ```
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
yiguolei
approved these changes
Jul 15, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
pick from #37493