[Bug](bitmap) clear set when bitmap fastunion #37816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
reviewed
Jul 15, 2024
|
|
||
| BitmapValue& fastunion(const std::vector<const BitmapValue*>& values) { | ||
| std::vector<const detail::Roaring64Map*> bitmaps; | ||
| std::vector<uint64_t> single_values; |
Contributor
There was a problem hiding this comment.
please modify the unit test in BE UT
yiguolei
approved these changes
Jul 15, 2024
BiteTheDDDDt
added a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Jul 16, 2024
## Proposed changes before:6 min 59.33 sec after :24.67 sec
BiteTheDDDDt
added a commit
to BiteTheDDDDt/incubator-doris
that referenced
this pull request
Jul 16, 2024
## Proposed changes before:6 min 59.33 sec after :24.67 sec
yiguolei
pushed a commit
that referenced
this pull request
Jul 16, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jul 17, 2024
## Proposed changes before:6 min 59.33 sec after :24.67 sec
dataroaring
pushed a commit
that referenced
this pull request
Jul 17, 2024
## Proposed changes before:6 min 59.33 sec after :24.67 sec
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
before:6 min 59.33 sec
after :24.67 sec