Skip to content

[fix](inverted index) Corrected the issue of no_index_match failure caused by empty data. #37947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qidaye merged 1 commit into from
Jul 17, 2024
Merged

[fix](inverted index) Corrected the issue of no_index_match failure caused by empty data. #37947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion be/src/vec/functions/match.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,12 @@ Status FunctionMatchPhrasePrefix::execute_match(
auto data_tokens = analyse_data_token(column_name, inverted_index_ctx, string_col, i,
array_offsets, current_src_array_offset);

for (size_t j = 0; j < data_tokens.size() - query_tokens.size() + 1; j++) {
int32_t dis_count = data_tokens.size() - query_tokens.size();
if (dis_count < 0) {
continue;
}

for (size_t j = 0; j < dis_count + 1; j++) {
if (data_tokens[j] == query_tokens[0] || query_tokens.size() == 1) {
bool match = true;
for (size_t k = 0; k < query_tokens.size(); k++) {
Expand Down
6 changes: 6 additions & 0 deletions regression-test/data/inverted_index_p0/test_no_index_match.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,9 @@
-- !sql --
66

-- !sql --
0

-- !sql --
0

5 changes: 5 additions & 0 deletions regression-test/suites/inverted_index_p0/test_no_index_match.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@ suite("test_no_index_match", "p0") {
create_httplogs_unique_table.call(testTable_unique)
load_httplogs_data.call(testTable_unique, 'httplogs_unique', 'true', 'json', 'documents-1000.json')

sql """ INSERT INTO ${testTable_unique} VALUES (1, '1', '', 1, 1); """

sql 'sync'

try {
Expand All @@ -89,6 +91,9 @@ suite("test_no_index_match", "p0") {
qt_sql """ select count() from ${testTable_unique} where (request match_phrase 'hm bg'); """
qt_sql """ select count() from ${testTable_unique} where (request match_phrase_prefix 'hm b'); """
qt_sql """ select count() from ${testTable_unique} where (request match_regexp 'la'); """

qt_sql """ select count() from ${testTable_unique} where (request match_phrase '欧冶工业品'); """
qt_sql """ select count() from ${testTable_unique} where (request match_phrase_prefix '欧冶工业品'); """
} finally {
}
} finally {
Expand Down