Skip to content

[fix](round) fix round decimal128 overflow (#37733) #37963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 4 commits into from
Jul 18, 2024
Merged

[fix](round) fix round decimal128 overflow (#37733) #37963

yiguolei merged 4 commits into from
Jul 18, 2024

Conversation

@cambyzju
Copy link
Contributor

@cambyzju cambyzju commented Jul 17, 2024 •
edited
Loading

cherry-pick #37733 and #38106 to branch-2.1

@cambyzju
[fix](round) fix round decimal128 overflow (apache#37733)
448dbf2 
## Proposed changes

Issue Number: close #apache#37143

<!--Describe your changes.-->
@doris-robot
Copy link

doris-robot commented Jul 17, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cambyzju
Copy link
Contributor Author

cambyzju commented Jul 17, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju cambyzju force-pushed the fix-2.1-round-0717 branch from 3695cb2 to 8eed3b6 Compare July 17, 2024 12:26
@cambyzju
Copy link
Contributor Author

cambyzju commented Jul 17, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju cambyzju force-pushed the fix-2.1-round-0717 branch from 8eed3b6 to 82b6576 Compare July 18, 2024 02:39
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju cambyzju force-pushed the fix-2.1-round-0717 branch from 82b6576 to 3e91364 Compare July 18, 2024 02:47
@cambyzju
Copy link
Contributor Author

cambyzju commented Jul 18, 2024

run ut

@cambyzju
Copy link
Contributor Author

cambyzju commented Jul 18, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

TeamCity be ut coverage result:
Function Coverage: 36.46% (9240/25345)
Line Coverage: 27.99% (75513/269795)
Region Coverage: 26.81% (38820/144807)
Branch Coverage: 23.55% (19713/83694)
Coverage Report: http://coverage.selectdb-in.cc/coverage/3e913648dc0c01d7fe2afbe49c63d1af3ee8d1f7_3e913648dc0c01d7fe2afbe49c63d1af3ee8d1f7/report/index.html

@cambyzju cambyzju force-pushed the fix-2.1-round-0717 branch from 3e91364 to 1f279c4 Compare July 18, 2024 03:55
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju cambyzju force-pushed the fix-2.1-round-0717 branch from 1f279c4 to 19e6279 Compare July 18, 2024 04:03
@cambyzju
Copy link
Contributor Author

cambyzju commented Jul 18, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

TeamCity be ut coverage result:
Function Coverage: 36.46% (9240/25345)
Line Coverage: 27.99% (75526/269795)
Region Coverage: 26.82% (38835/144809)
Branch Coverage: 23.56% (19715/83694)
Coverage Report: http://coverage.selectdb-in.cc/coverage/19e6279dad06ea6eb068634a5cf6169664bcf6c0_19e6279dad06ea6eb068634a5cf6169664bcf6c0/report/index.html

@cambyzju
Copy link
Contributor Author

cambyzju commented Jul 18, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

TeamCity be ut coverage result:
Function Coverage: 36.45% (9239/25345)
Line Coverage: 27.99% (75528/269795)
Region Coverage: 26.81% (38827/144809)
Branch Coverage: 23.56% (19720/83694)
Coverage Report: http://coverage.selectdb-in.cc/coverage/ec22606dd23aee122133fd8b1ad97f2d4d22a1b5_ec22606dd23aee122133fd8b1ad97f2d4d22a1b5/report/index.html

@cambyzju
Copy link
Contributor Author

cambyzju commented Jul 18, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

TeamCity be ut coverage result:
Function Coverage: 36.46% (9240/25342)
Line Coverage: 27.99% (75526/269796)
Region Coverage: 26.82% (38834/144804)
Branch Coverage: 23.56% (19715/83688)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f852bcf242b89e957dbcfea17ba0399b02e88c36_f852bcf242b89e957dbcfea17ba0399b02e88c36/report/index.html

@yiguolei yiguolei merged commit de2272c into apache:branch-2.1 Jul 18, 2024
cambyzju added a commit to cambyzju/incubator-doris that referenced this pull request Jul 19, 2024
@cambyzju
[fix](round) fix round decimal128 overflow (apache#37733) (apache#37963)
3dd1388 
cherry-pick apache#37733 to branch-2.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cambyzju @doris-robot @yiguolei