Skip to content

[fix](round) fix round decimal128 overflow (#37733) #37965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cambyzju merged 2 commits into from
Jul 19, 2024
Merged

[fix](round) fix round decimal128 overflow (#37733) #37965

cambyzju merged 2 commits into from
Jul 19, 2024

Conversation

@cambyzju
Copy link
Contributor

@cambyzju cambyzju commented Jul 17, 2024

cherry-pick #37733 to branch-2.0

@doris-robot
Copy link

doris-robot commented Jul 17, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@cambyzju cambyzju force-pushed the fix-2.0-round-0717 branch from 73d64c4 to b5b773f Compare July 17, 2024 01:51
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju cambyzju force-pushed the fix-2.0-round-0717 branch 2 times, most recently from 7ee850d to a41a222 Compare July 17, 2024 12:37
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@cambyzju
Copy link
Contributor Author

cambyzju commented Jul 17, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jul 17, 2024

TPC-H: Total hot run time: 49713 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a41a2221159aabcc0878e1b21021377375f528bf, data reload: false

------ Round 1 ----------------------------------
q1	17800	4459	4389	4389
q2	2034	156	151	151
q3	10261	1914	1962	1914
q4	10162	1270	1324	1270
q5	8672	3879	3919	3879
q6	226	128	126	126
q7	2035	1595	1589	1589
q8	9563	2748	2706	2706
q9	13777	10248	10146	10146
q10	8617	3534	3510	3510
q11	415	238	252	238
q12	478	306	299	299
q13	18367	4000	4044	4000
q14	349	332	331	331
q15	498	466	465	465
q16	667	583	581	581
q17	1145	953	910	910
q18	7276	6758	6785	6758
q19	1785	1633	1644	1633
q20	563	314	291	291
q21	4452	4169	4083	4083
q22	527	451	444	444
Total cold run time: 119669 ms
Total hot run time: 49713 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4298	4290	4282	4282
q2	321	228	224	224
q3	4134	4155	4129	4129
q4	2761	2778	2745	2745
q5	7146	7093	7077	7077
q6	239	120	122	120
q7	3213	2772	2817	2772
q8	4359	4428	4454	4428
q9	16846	16682	16901	16682
q10	4246	4282	4277	4277
q11	746	683	674	674
q12	1040	866	870	866
q13	6724	3734	3721	3721
q14	458	419	421	419
q15	506	458	460	458
q16	736	679	678	678
q17	3823	3749	3827	3749
q18	8913	8836	8828	8828
q19	1731	1642	1639	1639
q20	2360	2099	2127	2099
q21	8430	8418	8456	8418
q22	1024	970	982	970
Total cold run time: 84054 ms
Total hot run time: 79255 ms

@doris-robot
Copy link

doris-robot commented Jul 17, 2024

TeamCity be ut coverage result:
Function Coverage: 37.81% (8117/21466)
Line Coverage: 29.48% (66532/225690)
Region Coverage: 28.95% (34288/118442)
Branch Coverage: 24.83% (17616/70950)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a41a2221159aabcc0878e1b21021377375f528bf_a41a2221159aabcc0878e1b21021377375f528bf/report/index.html

@doris-robot
Copy link

doris-robot commented Jul 17, 2024

TPC-DS: Total hot run time: 202777 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a41a2221159aabcc0878e1b21021377375f528bf, data reload: false

query1	922	418	376	376
query2	6546	2873	2611	2611
query3	6926	208	206	206
query4	20929	17967	17893	17893
query5	19727	6493	6483	6483
query6	295	217	242	217
query7	4148	294	318	294
query8	444	426	417	417
query9	3119	2675	2600	2600
query10	415	325	298	298
query11	11291	10814	10772	10772
query12	127	77	75	75
query13	5602	692	695	692
query14	17748	13227	13358	13227
query15	367	234	258	234
query16	6460	283	259	259
query17	1713	1449	880	880
query18	2314	420	404	404
query19	207	149	151	149
query20	78	81	86	81
query21	200	95	91	91
query22	5155	4790	5056	4790
query23	32655	32025	31886	31886
query24	7019	6503	6472	6472
query25	536	434	420	420
query26	611	163	160	160
query27	1995	289	299	289
query28	6158	2366	2295	2295
query29	2834	2827	2845	2827
query30	236	166	172	166
query31	918	730	750	730
query32	69	63	59	59
query33	419	263	262	262
query34	855	472	485	472
query35	1114	917	862	862
query36	1376	1043	1415	1043
query37	91	62	62	62
query38	3096	2896	2965	2896
query39	1394	1338	1311	1311
query40	209	92	93	92
query41	47	46	45	45
query42	87	90	76	76
query43	774	734	692	692
query44	1115	718	710	710
query45	246	238	240	238
query46	1213	978	968	968
query47	1813	1805	1687	1687
query48	1038	721	709	709
query49	617	382	377	377
query50	852	590	625	590
query51	4688	4645	4594	4594
query52	96	82	95	82
query53	454	319	338	319
query54	2679	2455	2445	2445
query55	89	78	90	78
query56	228	223	212	212
query57	1228	1204	1087	1087
query58	202	202	216	202
query59	4327	4058	3751	3751
query60	222	200	201	200
query61	96	91	98	91
query62	830	491	575	491
query63	494	353	344	344
query64	2440	1551	1448	1448
query65	3632	3558	3549	3549
query66	805	384	382	382
query67	15449	18361	15446	15446
query68	8530	638	667	638
query69	576	374	366	366
query70	1667	1296	1506	1296
query71	393	306	309	306
query72	6610	3463	3433	3433
query73	744	321	321	321
query74	6322	5805	5795	5795
query75	5127	3739	3731	3731
query76	5104	1135	1178	1135
query77	758	251	261	251
query78	12632	11667	12286	11667
query79	9895	661	653	653
query80	1023	406	403	403
query81	496	235	232	232
query82	1338	103	96	96
query83	167	132	129	129
query84	257	72	71	71
query85	896	340	343	340
query86	334	287	280	280
query87	3243	3004	3074	3004
query88	4677	2326	2309	2309
query89	469	279	294	279
query90	1950	218	220	218
query91	174	154	144	144
query92	64	52	57	52
query93	5573	589	577	577
query94	724	209	216	209
query95	1102	1057	1047	1047
query96	644	338	322	322
query97	6465	6352	6324	6324
query98	192	169	165	165
query99	2929	818	860	818
Total cold run time: 313154 ms
Total hot run time: 202777 ms

@doris-robot
Copy link

doris-robot commented Jul 17, 2024

ClickBench: Total hot run time: 30.2 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a41a2221159aabcc0878e1b21021377375f528bf, data reload: false

query1	0.02	0.02	0.01
query2	0.07	0.03	0.02
query3	0.25	0.05	0.05
query4	1.79	0.06	0.07
query5	0.54	0.52	0.52
query6	1.24	0.60	0.61
query7	0.01	0.00	0.01
query8	0.04	0.02	0.02
query9	0.52	0.47	0.48
query10	0.53	0.54	0.54
query11	0.11	0.08	0.08
query12	0.12	0.09	0.09
query13	0.61	0.62	0.61
query14	0.79	0.78	0.81
query15	0.77	0.76	0.76
query16	0.39	0.35	0.36
query17	1.02	1.00	0.98
query18	0.22	0.25	0.24
query19	1.94	1.78	1.78
query20	0.02	0.01	0.01
query21	15.47	0.54	0.54
query22	2.10	2.35	1.54
query23	17.24	1.02	1.02
query24	7.74	0.74	1.25
query25	0.36	0.11	0.06
query26	0.82	0.17	0.16
query27	0.04	0.03	0.03
query28	5.51	0.74	0.73
query29	12.62	2.08	2.29
query30	0.54	0.52	0.52
query31	2.81	0.38	0.37
query32	3.39	0.49	0.49
query33	3.06	3.08	3.06
query34	15.26	4.77	4.77
query35	4.86	4.84	4.84
query36	1.06	1.02	1.03
query37	0.05	0.05	0.05
query38	0.04	0.02	0.02
query39	0.02	0.01	0.01
query40	0.16	0.14	0.14
query41	0.07	0.02	0.01
query42	0.02	0.02	0.02
query43	0.03	0.01	0.01
Total cold run time: 104.27 s
Total hot run time: 30.2 s

@doris-robot
Copy link

doris-robot commented Jul 17, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit a41a2221159aabcc0878e1b21021377375f528bf with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.3 seconds inserted 10000000 Rows, about 469K ops/s

@cambyzju cambyzju force-pushed the fix-2.0-round-0717 branch from a41a222 to 49aa5b7 Compare July 18, 2024 04:01
@cambyzju cambyzju force-pushed the fix-2.0-round-0717 branch from 49aa5b7 to af0e6d3 Compare July 18, 2024 04:05
@cambyzju
Copy link
Contributor Author

cambyzju commented Jul 18, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

TPC-H: Total hot run time: 50391 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit af0e6d39d82c65c5e51b7edaa10aa586b8b084af, data reload: false

------ Round 1 ----------------------------------
q1	17519	4381	4355	4355
q2	2064	157	149	149
q3	10259	1905	1979	1905
q4	10103	1269	1351	1269
q5	8495	3929	3912	3912
q6	235	127	127	127
q7	2080	1617	1619	1617
q8	9296	2749	2713	2713
q9	11138	11080	10539	10539
q10	8713	3588	3585	3585
q11	428	250	243	243
q12	470	292	299	292
q13	18379	3963	4049	3963
q14	342	322	331	322
q15	514	461	463	461
q16	675	590	564	564
q17	1141	990	995	990
q18	7401	6947	6835	6835
q19	1792	1687	1676	1676
q20	562	321	321	321
q21	4449	4112	4178	4112
q22	526	441	443	441
Total cold run time: 116581 ms
Total hot run time: 50391 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4349	4304	4282	4282
q2	323	230	228	228
q3	4243	4142	4118	4118
q4	2764	2765	2735	2735
q5	7180	7156	7134	7134
q6	236	122	119	119
q7	3240	2866	2864	2864
q8	4357	4483	4518	4483
q9	16874	16911	16785	16785
q10	4215	4295	4293	4293
q11	739	709	681	681
q12	1028	864	862	862
q13	4708	3736	3713	3713
q14	448	419	418	418
q15	526	452	447	447
q16	739	692	677	677
q17	3853	3866	3844	3844
q18	8760	8776	8959	8776
q19	1724	1721	1662	1662
q20	2379	2166	2112	2112
q21	8482	8474	8572	8474
q22	1094	989	1003	989
Total cold run time: 82261 ms
Total hot run time: 79696 ms

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

TeamCity be ut coverage result:
Function Coverage: 37.81% (8117/21466)
Line Coverage: 29.48% (66542/225689)
Region Coverage: 28.95% (34291/118442)
Branch Coverage: 24.83% (17619/70950)
Coverage Report: http://coverage.selectdb-in.cc/coverage/af0e6d39d82c65c5e51b7edaa10aa586b8b084af_af0e6d39d82c65c5e51b7edaa10aa586b8b084af/report/index.html

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

TPC-DS: Total hot run time: 204276 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit af0e6d39d82c65c5e51b7edaa10aa586b8b084af, data reload: false

query1	925	420	380	380
query2	6528	2844	2721	2721
query3	6929	219	212	212
query4	19890	18049	18044	18044
query5	19756	6557	6547	6547
query6	296	237	229	229
query7	4156	298	320	298
query8	415	446	474	446
query9	3128	2669	2614	2614
query10	408	323	319	319
query11	11292	10787	10671	10671
query12	130	80	76	76
query13	5643	687	686	686
query14	18057	13770	13607	13607
query15	366	244	247	244
query16	6462	299	269	269
query17	1688	1457	876	876
query18	2311	416	411	411
query19	206	157	152	152
query20	82	82	83	82
query21	196	97	99	97
query22	5476	5061	5116	5061
query23	32383	31913	32030	31913
query24	6949	6568	6480	6480
query25	525	421	424	421
query26	536	161	160	160
query27	1832	300	293	293
query28	6148	2390	2332	2332
query29	2952	2677	2784	2677
query30	244	167	168	167
query31	919	724	744	724
query32	66	65	64	64
query33	406	265	267	265
query34	847	469	484	469
query35	1144	894	927	894
query36	1465	1215	1113	1113
query37	95	64	62	62
query38	3053	2931	2975	2931
query39	1380	1329	1316	1316
query40	203	96	96	96
query41	44	45	43	43
query42	90	84	86	84
query43	717	623	664	623
query44	1116	718	730	718
query45	247	237	237	237
query46	1219	955	995	955
query47	1916	1812	1629	1629
query48	1009	719	735	719
query49	635	391	359	359
query50	857	600	585	585
query51	4754	4616	4730	4616
query52	99	82	100	82
query53	441	317	338	317
query54	2623	2437	2431	2431
query55	84	87	77	77
query56	210	203	219	203
query57	1192	1068	1066	1066
query58	229	211	211	211
query59	4322	3989	4210	3989
query60	225	213	219	213
query61	96	95	99	95
query62	837	475	484	475
query63	487	345	336	336
query64	2452	1546	1520	1520
query65	3677	3568	3568	3568
query66	784	373	369	369
query67	15809	15255	15171	15171
query68	9763	669	653	653
query69	591	337	332	332
query70	1627	1394	1532	1394
query71	417	316	317	316
query72	6582	3472	3505	3472
query73	732	327	322	322
query74	6218	5793	5875	5793
query75	5367	3697	3742	3697
query76	6238	1185	1167	1167
query77	1058	271	255	255
query78	12618	11680	11835	11680
query79	9542	697	666	666
query80	1372	425	416	416
query81	490	240	241	240
query82	1679	100	101	100
query83	183	135	138	135
query84	262	73	75	73
query85	898	338	334	334
query86	577	323	302	302
query87	3352	3113	3168	3113
query88	4743	2431	2417	2417
query89	485	294	293	293
query90	1947	212	220	212
query91	174	143	142	142
query92	60	54	57	54
query93	6844	601	599	599
query94	891	213	210	210
query95	1102	1044	1056	1044
query96	654	331	326	326
query97	6487	6456	6315	6315
query98	199	175	166	166
query99	3040	945	928	928
Total cold run time: 317850 ms
Total hot run time: 204276 ms

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

ClickBench: Total hot run time: 30.9 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit af0e6d39d82c65c5e51b7edaa10aa586b8b084af, data reload: false

query1	0.02	0.02	0.02
query2	0.07	0.02	0.02
query3	0.24	0.04	0.05
query4	1.78	0.06	0.05
query5	0.54	0.52	0.52
query6	1.28	0.61	0.61
query7	0.01	0.01	0.01
query8	0.03	0.02	0.02
query9	0.52	0.50	0.48
query10	0.54	0.54	0.54
query11	0.12	0.08	0.09
query12	0.12	0.09	0.09
query13	0.61	0.62	0.61
query14	0.79	0.77	0.77
query15	0.78	0.75	0.76
query16	0.36	0.36	0.36
query17	1.00	1.02	1.01
query18	0.23	0.26	0.25
query19	1.92	1.88	1.84
query20	0.02	0.01	0.01
query21	15.46	0.55	0.56
query22	1.92	1.91	1.23
query23	17.44	1.01	0.93
query24	3.84	1.57	2.72
query25	0.39	0.12	0.05
query26	0.62	0.16	0.16
query27	0.05	0.04	0.03
query28	7.02	0.72	0.71
query29	12.67	2.28	2.29
query30	0.56	0.52	0.58
query31	2.80	0.38	0.37
query32	3.38	0.52	0.52
query33	3.07	3.10	3.02
query34	15.27	4.78	4.76
query35	4.86	4.86	4.86
query36	1.06	1.00	1.01
query37	0.06	0.05	0.05
query38	0.04	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.14	0.15
query41	0.07	0.01	0.02
query42	0.02	0.02	0.01
query43	0.02	0.02	0.02
Total cold run time: 101.78 s
Total hot run time: 30.9 s

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit af0e6d39d82c65c5e51b7edaa10aa586b8b084af with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.1 seconds inserted 10000000 Rows, about 473K ops/s

@cambyzju
Copy link
Contributor Author

cambyzju commented Jul 18, 2024

run external

@cambyzju
Copy link
Contributor Author

cambyzju commented Jul 18, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

TPC-H: Total hot run time: 49818 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f2dbb0af74eee4e5ed70f8bdca5b67020da44c8b, data reload: false

------ Round 1 ----------------------------------
q1	17783	4383	4350	4350
q2	2073	160	146	146
q3	10339	1903	1911	1903
q4	10106	1244	1313	1244
q5	8599	3893	3857	3857
q6	240	123	127	123
q7	2041	1639	1575	1575
q8	9539	2746	2729	2729
q9	13770	10259	10429	10259
q10	8633	3531	3519	3519
q11	414	244	246	244
q12	467	300	300	300
q13	18355	3986	4068	3986
q14	347	329	327	327
q15	506	450	459	450
q16	658	567	571	567
q17	1130	935	920	920
q18	7136	6897	6885	6885
q19	1797	1690	1642	1642
q20	544	329	303	303
q21	4452	4110	4052	4052
q22	527	437	450	437
Total cold run time: 119456 ms
Total hot run time: 49818 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4284	4272	4304	4272
q2	320	223	226	223
q3	4140	4157	4138	4138
q4	2740	2722	2741	2722
q5	7163	7064	7125	7064
q6	240	117	120	117
q7	3212	2816	2818	2816
q8	4350	4425	4466	4425
q9	16882	16808	17409	16808
q10	4247	4265	4229	4229
q11	761	698	682	682
q12	1032	855	866	855
q13	6466	3787	3694	3694
q14	457	424	425	424
q15	510	449	455	449
q16	739	683	693	683
q17	3764	3791	3780	3780
q18	8721	8772	8818	8772
q19	1745	1677	1713	1677
q20	2353	2133	2117	2117
q21	8423	8462	8471	8462
q22	1062	980	954	954
Total cold run time: 83611 ms
Total hot run time: 79363 ms

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

TPC-DS: Total hot run time: 202313 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f2dbb0af74eee4e5ed70f8bdca5b67020da44c8b, data reload: false

query1	914	422	373	373
query2	6530	2896	2620	2620
query3	6922	220	206	206
query4	20046	17941	17816	17816
query5	19726	6508	6509	6508
query6	289	218	231	218
query7	4159	318	309	309
query8	424	438	430	430
query9	3100	2675	2628	2628
query10	428	291	304	291
query11	11302	10786	10623	10623
query12	122	78	77	77
query13	5619	741	701	701
query14	17880	13265	13137	13137
query15	359	232	252	232
query16	6479	292	270	270
query17	1679	1473	859	859
query18	2318	399	404	399
query19	204	151	150	150
query20	81	78	79	78
query21	193	94	92	92
query22	5100	5006	5067	5006
query23	32355	31615	32039	31615
query24	7002	6438	6590	6438
query25	550	424	423	423
query26	621	163	161	161
query27	1990	291	293	291
query28	6201	2334	2300	2300
query29	2913	2777	2850	2777
query30	239	175	172	172
query31	946	722	738	722
query32	62	61	57	57
query33	403	252	261	252
query34	836	471	477	471
query35	1135	886	869	869
query36	1343	1165	1224	1165
query37	90	62	62	62
query38	3088	2951	2937	2937
query39	1366	1354	1325	1325
query40	209	101	93	93
query41	46	43	43	43
query42	88	81	79	79
query43	689	719	708	708
query44	1098	725	731	725
query45	245	233	231	231
query46	1216	950	960	950
query47	1883	1829	1841	1829
query48	1012	715	728	715
query49	611	367	402	367
query50	867	637	600	600
query51	4749	4659	4675	4659
query52	90	95	78	78
query53	444	316	314	314
query54	2673	2430	2462	2430
query55	106	78	87	78
query56	241	215	211	211
query57	1164	1110	1093	1093
query58	201	216	203	203
query59	4029	3760	4152	3760
query60	215	185	217	185
query61	95	100	95	95
query62	823	464	511	464
query63	489	341	339	339
query64	2598	1536	1454	1454
query65	3683	3544	3543	3543
query66	827	375	366	366
query67	16026	14924	17564	14924
query68	9239	646	669	646
query69	574	333	334	333
query70	1659	1547	1352	1352
query71	412	299	316	299
query72	6533	3493	3445	3445
query73	730	323	326	323
query74	6327	5844	5854	5844
query75	5344	3774	3713	3713
query76	5853	1176	1199	1176
query77	975	267	266	266
query78	12604	12035	11628	11628
query79	10519	657	637	637
query80	869	411	404	404
query81	455	235	236	235
query82	831	98	96	96
query83	161	135	129	129
query84	253	69	73	69
query85	887	320	326	320
query86	328	305	294	294
query87	3219	3006	3015	3006
query88	4341	2313	2309	2309
query89	484	296	293	293
query90	1987	212	204	204
query91	173	137	140	137
query92	65	53	52	52
query93	6924	618	601	601
query94	713	210	214	210
query95	1094	1043	1063	1043
query96	652	329	326	326
query97	6461	6425	6383	6383
query98	192	178	173	173
query99	3034	771	897	771
Total cold run time: 315323 ms
Total hot run time: 202313 ms

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

ClickBench: Total hot run time: 31.31 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f2dbb0af74eee4e5ed70f8bdca5b67020da44c8b, data reload: false

query1	0.02	0.02	0.02
query2	0.06	0.02	0.02
query3	0.25	0.04	0.04
query4	1.80	0.07	0.06
query5	0.53	0.52	0.51
query6	1.27	0.61	0.63
query7	0.01	0.01	0.01
query8	0.03	0.02	0.02
query9	0.54	0.46	0.48
query10	0.54	0.52	0.53
query11	0.12	0.08	0.09
query12	0.11	0.09	0.09
query13	0.62	0.62	0.61
query14	0.77	0.77	0.80
query15	0.77	0.75	0.76
query16	0.36	0.36	0.36
query17	1.02	0.98	0.99
query18	0.22	0.24	0.25
query19	1.92	1.87	1.81
query20	0.02	0.01	0.01
query21	15.44	0.54	0.56
query22	2.02	2.29	2.30
query23	17.22	1.11	0.95
query24	3.66	3.44	1.05
query25	0.38	0.08	0.06
query26	0.67	0.15	0.16
query27	0.05	0.04	0.04
query28	6.94	0.78	0.78
query29	12.67	2.23	2.24
query30	0.61	0.50	0.54
query31	2.82	0.41	0.37
query32	3.35	0.50	0.49
query33	3.07	3.07	3.12
query34	15.26	4.76	4.77
query35	4.85	4.85	4.80
query36	1.06	1.02	1.01
query37	0.06	0.05	0.04
query38	0.03	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.14	0.14
query41	0.06	0.01	0.01
query42	0.02	0.02	0.01
query43	0.02	0.02	0.02
Total cold run time: 101.42 s
Total hot run time: 31.31 s

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit f2dbb0af74eee4e5ed70f8bdca5b67020da44c8b with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.4 seconds inserted 10000000 Rows, about 467K ops/s

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

TeamCity be ut coverage result:
Function Coverage: 37.82% (8119/21466)
Line Coverage: 29.48% (66542/225693)
Region Coverage: 28.96% (34297/118445)
Branch Coverage: 24.83% (17619/70952)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f2dbb0af74eee4e5ed70f8bdca5b67020da44c8b_f2dbb0af74eee4e5ed70f8bdca5b67020da44c8b/report/index.html

lide-reed
lide-reed approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024

PR approved by anyone and no changes requested.

@cambyzju cambyzju merged commit ce71a13 into apache:branch-2.0 Jul 19, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@cambyzju
[fix](round) fix round decimal128 overflow (apache#37733) (apache#37965)
df2fcfa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lide-reed lide-reed lide-reed approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. kind/test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cambyzju @doris-robot @lide-reed