-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](fe) Fix removeDroppedMember use incorrect nodeName
#37987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
```
com.sleepycat.je.rep.MasterStateException: (JE 18.3.12) Cannot remove an active master
at com.sleepycat.je.rep.util.ReplicationGroupAdmin.checkMember(ReplicationGroupAdmin.java:591)
at com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:315)
at org.apache.doris.ha.BDBHA.removeDroppedMember(BDBHA.java:262)
at org.apache.doris.catalog.Env.removeDroppedFrontends(Env.java:3077)
at org.apache.doris.catalog.Env.transferToMaster(Env.java:1520)
at org.apache.doris.catalog.Env.access$1300(Env.java:338)
at org.apache.doris.catalog.Env$5.runOneCycle(Env.java:2792)
at org.apache.doris.common.util.Daemon.run(Daemon.java:116)
```
* the bug is introduced by apache#35203
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 39789 ms |
TPC-DS: Total hot run time: 175138 ms |
ClickBench: Total hot run time: 30.55 s |
```
com.sleepycat.je.rep.MasterStateException: (JE 18.3.12) Cannot remove an active master
at com.sleepycat.je.rep.util.ReplicationGroupAdmin.checkMember(ReplicationGroupAdmin.java:591)
at com.sleepycat.je.rep.util.ReplicationGroupAdmin.removeMember(ReplicationGroupAdmin.java:315)
at org.apache.doris.ha.BDBHA.removeDroppedMember(BDBHA.java:262)
at org.apache.doris.catalog.Env.removeDroppedFrontends(Env.java:3077)
at org.apache.doris.catalog.Env.transferToMaster(Env.java:1520)
at org.apache.doris.catalog.Env.access$1300(Env.java:338)
at org.apache.doris.catalog.Env$5.runOneCycle(Env.java:2792)
at org.apache.doris.common.util.Daemon.run(Daemon.java:116)
```
* the bug is introduced by #35203
bdbjeandfe memoryinconsistent state #35203Proposed changes
Issue Number: close #xxx