Skip to content

[fix](load) fix memtable agg functions #38017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 3 commits into from
Jul 18, 2024
Merged

[fix](load) fix memtable agg functions #38017

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7549470
[fix](load) fix memtable agg functions
kaijchen Jul 17, 2024
69c7c0b
comments
kaijchen Jul 17, 2024
22f7bec
rename var
kaijchen Jul 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions be/src/olap/memtable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,19 +182,21 @@ Status MemTable::insert(const vectorized::Block* input_block,
const std::vector<uint32_t>& row_idxs) {
if (_is_first_insertion) {
_is_first_insertion = false;
auto cloneBlock = input_block->clone_without_columns(&_column_offset);
_input_mutable_block = vectorized::MutableBlock::build_mutable_block(&cloneBlock);
auto clone_block = input_block->clone_without_columns(&_column_offset);
_input_mutable_block = vectorized::MutableBlock::build_mutable_block(&clone_block);
_vec_row_comparator->set_block(&_input_mutable_block);
_output_mutable_block = vectorized::MutableBlock::build_mutable_block(&cloneBlock);
_output_mutable_block = vectorized::MutableBlock::build_mutable_block(&clone_block);
if (_keys_type != KeysType::DUP_KEYS) {
_init_agg_functions(input_block);
// there may be additional intermediate columns in input_block
// we only need columns indicated by column offset in the output
_init_agg_functions(&clone_block);
}
if (_tablet_schema->has_sequence_col()) {
if (_is_partial_update) {
// for unique key partial update, sequence column index in block
// may be different with the index in `_tablet_schema`
for (size_t i = 0; i < cloneBlock.columns(); i++) {
if (cloneBlock.get_by_position(i).name == SEQUENCE_COL) {
for (size_t i = 0; i < clone_block.columns(); i++) {
if (clone_block.get_by_position(i).name == SEQUENCE_COL) {
_seq_col_idx_in_block = i;
break;
}
Expand Down