Skip to content

[Fix](beut) Fix TestDeleteConditionHandler beut #38043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 18, 2024
Merged

[Fix](beut) Fix TestDeleteConditionHandler beut #38043

dataroaring merged 1 commit into from
Jul 18, 2024

Conversation

@bobhan1
Copy link
Contributor

@bobhan1 bobhan1 commented Jul 18, 2024

Proposed changes

introduced in #37834

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

gavinchou
gavinchou previously approved these changes Jul 18, 2024
View reviewed changes
@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 18, 2024

run buildall

@bobhan1 bobhan1 mentioned this pull request Jul 18, 2024
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024

clang-tidy review says "All clean, LGTM! 👍"

zhannngchen
zhannngchen approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jul 18, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

TPC-H: Total hot run time: 39776 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7efe3397d1d65ca7dc49f584dca29d56b78e11c3, data reload: false

------ Round 1 ----------------------------------
q1	17645	4270	4330	4270
q2	2022	190	190	190
q3	10447	1185	1093	1093
q4	10181	790	791	790
q5	7545	2777	2627	2627
q6	221	137	140	137
q7	948	609	604	604
q8	9336	2052	2086	2052
q9	8815	6618	6604	6604
q10	8735	3752	3723	3723
q11	457	240	238	238
q12	437	231	229	229
q13	18563	2973	2990	2973
q14	275	227	244	227
q15	523	476	496	476
q16	494	383	372	372
q17	959	659	669	659
q18	8026	7576	7326	7326
q19	6123	1365	1450	1365
q20	685	334	343	334
q21	4845	3290	3203	3203
q22	345	288	284	284
Total cold run time: 117627 ms
Total hot run time: 39776 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4431	4265	4244	4244
q2	381	267	268	267
q3	2995	2922	2912	2912
q4	1997	1684	1721	1684
q5	5667	5506	5484	5484
q6	224	139	140	139
q7	2260	1852	1842	1842
q8	3221	3387	3485	3387
q9	8745	8795	8776	8776
q10	4040	3859	3796	3796
q11	583	526	516	516
q12	819	656	662	656
q13	16358	3199	3224	3199
q14	324	295	299	295
q15	526	499	476	476
q16	507	427	455	427
q17	1817	1510	1513	1510
q18	8121	7983	7968	7968
q19	2000	1634	1610	1610
q20	2127	1870	1848	1848
q21	5200	4805	4830	4805
q22	596	523	513	513
Total cold run time: 72939 ms
Total hot run time: 56354 ms

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

TPC-DS: Total hot run time: 173652 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7efe3397d1d65ca7dc49f584dca29d56b78e11c3, data reload: false

query1	923	377	372	372
query2	6450	1947	1772	1772
query3	6668	207	230	207
query4	27519	17561	17251	17251
query5	3762	492	488	488
query6	253	169	163	163
query7	4585	284	282	282
query8	263	200	191	191
query9	8634	2450	2479	2450
query10	443	310	294	294
query11	10475	9961	10106	9961
query12	116	88	85	85
query13	1661	368	364	364
query14	10183	7725	8451	7725
query15	221	171	169	169
query16	7232	324	321	321
query17	1785	574	548	548
query18	1245	288	333	288
query19	194	151	149	149
query20	91	82	84	82
query21	203	132	124	124
query22	4474	3983	3936	3936
query23	33844	33782	33451	33451
query24	10918	2985	2911	2911
query25	605	395	393	393
query26	697	152	147	147
query27	2159	283	284	283
query28	5987	2076	2079	2076
query29	863	649	628	628
query30	260	159	166	159
query31	947	767	758	758
query32	98	53	56	53
query33	713	329	303	303
query34	912	503	506	503
query35	699	575	585	575
query36	1148	962	996	962
query37	156	89	84	84
query38	2941	2871	2811	2811
query39	893	850	875	850
query40	203	124	125	124
query41	51	45	44	44
query42	112	104	103	103
query43	509	488	462	462
query44	1192	763	759	759
query45	193	163	163	163
query46	1083	753	741	741
query47	1854	1749	1742	1742
query48	355	295	297	295
query49	832	410	433	410
query50	779	401	407	401
query51	6968	6825	6706	6706
query52	105	103	94	94
query53	355	289	294	289
query54	888	449	443	443
query55	76	74	73	73
query56	291	264	278	264
query57	1105	1096	1047	1047
query58	243	245	248	245
query59	2852	2693	2735	2693
query60	303	284	278	278
query61	97	95	96	95
query62	807	644	630	630
query63	322	287	291	287
query64	9108	2230	6018	2230
query65	3142	3106	3092	3092
query66	743	333	328	328
query67	15371	14967	14716	14716
query68	4570	527	534	527
query69	651	412	373	373
query70	1091	1125	1146	1125
query71	412	289	282	282
query72	8108	6121	5515	5515
query73	739	328	329	328
query74	6286	5613	5600	5600
query75	3507	2691	2720	2691
query76	2880	961	1022	961
query77	718	305	314	305
query78	9671	9067	8864	8864
query79	2845	512	529	512
query80	2593	495	475	475
query81	598	227	219	219
query82	738	139	140	139
query83	364	175	169	169
query84	270	94	90	90
query85	1864	314	305	305
query86	467	330	306	306
query87	3319	3099	3068	3068
query88	4501	2375	2397	2375
query89	486	380	387	380
query90	1766	194	195	194
query91	131	99	101	99
query92	60	49	51	49
query93	4573	501	502	501
query94	1149	213	216	213
query95	408	325	322	322
query96	624	275	269	269
query97	3184	3026	3041	3026
query98	217	199	191	191
query99	1591	1256	1263	1256
Total cold run time: 281540 ms
Total hot run time: 173652 ms

@doris-robot
Copy link

doris-robot commented Jul 18, 2024

ClickBench: Total hot run time: 30.97 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7efe3397d1d65ca7dc49f584dca29d56b78e11c3, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.06
query4	1.66	0.08	0.08
query5	0.50	0.47	0.49
query6	1.15	0.73	0.73
query7	0.03	0.01	0.01
query8	0.06	0.05	0.05
query9	0.55	0.50	0.49
query10	0.55	0.54	0.54
query11	0.16	0.11	0.12
query12	0.15	0.13	0.12
query13	0.59	0.58	0.58
query14	0.76	0.77	0.78
query15	0.86	0.81	0.80
query16	0.37	0.38	0.37
query17	1.04	0.98	1.01
query18	0.23	0.22	0.22
query19	1.86	1.67	1.70
query20	0.01	0.01	0.01
query21	15.41	0.72	0.65
query22	4.42	6.61	2.32
query23	18.27	1.38	1.29
query24	2.13	0.24	0.23
query25	0.16	0.08	0.08
query26	0.30	0.22	0.22
query27	0.45	0.23	0.24
query28	13.17	1.03	1.01
query29	12.67	3.30	3.27
query30	0.25	0.07	0.05
query31	2.88	0.40	0.38
query32	3.27	0.48	0.47
query33	2.91	2.91	2.90
query34	17.15	4.34	4.33
query35	4.42	4.37	4.44
query36	0.65	0.46	0.47
query37	0.19	0.15	0.16
query38	0.15	0.15	0.15
query39	0.05	0.04	0.04
query40	0.15	0.11	0.12
query41	0.10	0.05	0.05
query42	0.05	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 110.12 s
Total hot run time: 30.97 s

@bobhan1
Copy link
Contributor Author

bobhan1 commented Jul 18, 2024

run external

dataroaring
dataroaring approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dataroaring pushed a commit that referenced this pull request Jul 18, 2024
@bobhan1
[branch-2.1] Picks "[opt](delete) Delete job should retry for failure…
c30c1d2 
… that is not DELETE_INVALID_XXX #37834" (#38032)

## Proposed changes

picks #37834 and
#38043
@dataroaring dataroaring merged commit c094339 into apache:master Jul 18, 2024
dataroaring pushed a commit that referenced this pull request Jul 19, 2024
@bobhan1 @dataroaring
[Fix](beut) Fix TestDeleteConditionHandler beut (#38043)
4bc800f 
introduced in #37834
@bobhan1 bobhan1 mentioned this pull request Aug 28, 2024
Merged
dataroaring pushed a commit that referenced this pull request Aug 28, 2024
@bobhan1
[branch-2.0](delete) Fix delete job timeout when executing `delete fr…
4114178 
…om ...` (#40028)

## Proposed changes

picks #37363,
#37834,
#38043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou gavinchou left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.15-merged dev/2.1.5-merged dev/3.0.1-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bobhan1 @doris-robot @gavinchou @zhannngchen @dataroaring