-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](inverted index) fixed in_list condition not indexed on pipelinex #38178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
2561a93
[fix](inverted index) fixed in_list condition not indexed on pipeline…
zzzxl1993 584a853
[fix](inverted index) Error parsing NULL_LITERAL (#37842)
zzzxl1993 d1ea692
[fix](inverted index) Incorrect handling of NULL literal (#37921)
zzzxl1993 44a78de
[fix](inverted index) fix the intermittent failure of the case. (#37386)
zzzxl1993 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67 changes: 67 additions & 0 deletions
67
regression-test/data/fault_injection_p0/test_index_inlist_fault_injection.out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| -- This file is automatically generated. You should know what you did if you want to edit this | ||
| -- !sql -- | ||
| 8 | ||
|
|
||
| -- !sql -- | ||
| 996 | ||
|
|
||
| -- !sql -- | ||
| 210 | ||
|
|
||
| -- !sql -- | ||
| 8 | ||
|
|
||
| -- !sql -- | ||
| 998 | ||
|
|
||
| -- !sql -- | ||
| 208 | ||
|
|
||
| -- !sql -- | ||
| 30 | ||
|
|
||
| -- !sql -- | ||
| 0 | ||
|
|
||
| -- !sql -- | ||
| 0 | ||
|
|
||
| -- !sql -- | ||
| 34 | ||
|
|
||
| -- !sql -- | ||
| 2 | ||
|
|
||
| -- !sql -- | ||
| 2 | ||
|
|
||
| -- !sql -- | ||
| 3 | ||
|
|
||
| -- !sql -- | ||
| 2 | ||
|
|
||
| -- !sql -- | ||
| 30 | ||
|
|
||
| -- !sql -- | ||
| 0 | ||
|
|
||
| -- !sql -- | ||
| 0 | ||
|
|
||
| -- !sql -- | ||
| 34 | ||
|
|
||
| -- !sql -- | ||
| 2 | ||
|
|
||
| -- !sql -- | ||
| 2 | ||
|
|
||
| -- !sql -- | ||
| 3 | ||
|
|
||
| -- !sql -- | ||
| 2 | ||
|
|
18 changes: 18 additions & 0 deletions
18
regression-test/data/inverted_index_p0/test_index_rqg_bug4.out
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| -- This file is automatically generated. You should know what you did if you want to edit this | ||
| -- !sql -- | ||
| \N | ||
| a | ||
| b | ||
| f | ||
| h | ||
| i | ||
| j | ||
| k | ||
| l | ||
| o | ||
| p | ||
| q | ||
| v | ||
| y | ||
| z | ||
|
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: function '_normalize_binary_compound_predicate' has cognitive complexity of 54 (threshold 50) [readability-function-cognitive-complexity]
Status ScanLocalState<Derived>::_normalize_binary_compound_predicate( ^Additional context
be/src/pipeline/exec/scan_operator.cpp:1084: +1, including nesting penalty of 0, nesting level increased to 1
be/src/pipeline/exec/scan_operator.cpp:1085: nesting level increased to 2
be/src/pipeline/exec/scan_operator.cpp:1086: nesting level increased to 2
be/src/pipeline/exec/scan_operator.cpp:1087: nesting level increased to 2
be/src/pipeline/exec/scan_operator.cpp:1088: +1
be/src/pipeline/exec/scan_operator.cpp:1096: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(_should_push_down_binary_predicate( ^be/src/common/status.h:609: expanded from macro 'RETURN_IF_ERROR'
do { \ ^be/src/pipeline/exec/scan_operator.cpp:1096: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_should_push_down_binary_predicate( ^be/src/common/status.h:611: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \ ^be/src/pipeline/exec/scan_operator.cpp:1099: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(_should_push_down_binary_predicate( ^be/src/common/status.h:609: expanded from macro 'RETURN_IF_ERROR'
do { \ ^be/src/pipeline/exec/scan_operator.cpp:1099: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_should_push_down_binary_predicate( ^be/src/common/status.h:611: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \ ^be/src/pipeline/exec/scan_operator.cpp:1102: +2, including nesting penalty of 1, nesting level increased to 2
RETURN_IF_ERROR(_should_push_down_binary_predicate( ^be/src/common/status.h:609: expanded from macro 'RETURN_IF_ERROR'
do { \ ^be/src/pipeline/exec/scan_operator.cpp:1102: +3, including nesting penalty of 2, nesting level increased to 3
RETURN_IF_ERROR(_should_push_down_binary_predicate( ^be/src/common/status.h:611: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \ ^be/src/pipeline/exec/scan_operator.cpp:1105: +2, including nesting penalty of 1, nesting level increased to 2
if (eq_pdt == vectorized::VScanNode::PushDownType::UNACCEPTABLE && ^be/src/pipeline/exec/scan_operator.cpp:1106: +1
ne_pdt == vectorized::VScanNode::PushDownType::UNACCEPTABLE && ^be/src/pipeline/exec/scan_operator.cpp:1113: +2, including nesting penalty of 1, nesting level increased to 2
if (eq_pdt == vectorized::VScanNode::PushDownType::ACCEPTABLE || ^be/src/pipeline/exec/scan_operator.cpp:1114: +1
ne_pdt == vectorized::VScanNode::PushDownType::ACCEPTABLE || ^be/src/pipeline/exec/scan_operator.cpp:1116: +3, including nesting penalty of 2, nesting level increased to 3
be/src/pipeline/exec/scan_operator.cpp:1117: +4, including nesting penalty of 3, nesting level increased to 4
be/src/pipeline/exec/scan_operator.cpp:1117: +1
be/src/pipeline/exec/scan_operator.cpp:1120: +5, including nesting penalty of 4, nesting level increased to 5
be/src/common/status.h:609: expanded from macro 'RETURN_IF_ERROR'
do { \ ^be/src/pipeline/exec/scan_operator.cpp:1120: +6, including nesting penalty of 5, nesting level increased to 6
be/src/common/status.h:611: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \ ^be/src/pipeline/exec/scan_operator.cpp:1124: +1, nesting level increased to 4
} else { ^be/src/pipeline/exec/scan_operator.cpp:1125: +5, including nesting penalty of 4, nesting level increased to 5
be/src/common/status.h:609: expanded from macro 'RETURN_IF_ERROR'
do { \ ^be/src/pipeline/exec/scan_operator.cpp:1125: +6, including nesting penalty of 5, nesting level increased to 6
be/src/common/status.h:611: expanded from macro 'RETURN_IF_ERROR'
if (UNLIKELY(!_status_.ok())) { \ ^