-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](load data) decommission replica don't load data when it misses versions #38198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](load data) decommission replica don't load data when it misses versions #38198
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
2 similar comments
|
run buildall |
|
run buildall |
deardeng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 39874 ms |
TPC-DS: Total hot run time: 174310 ms |
ClickBench: Total hot run time: 30.82 s |
|
run feut |
|
run cloud_p1 |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
…versions (#38198) BUG: when a decommission replica misses versions (last failed version > 0), it will cause a bug: 1. It cann't do compaction due to it has miss versions; 2. It cann't cloning the missing rowsets because it's decommissioned. So if it continue to load data, its rowset will increase util it cause error -235(TOO MANY VERSION). Fix: don't write data to the decommission replica if it miss rowsets.
…versions apache#38198 (apache#38257) cherry pick from apache#38198
BUG: when a decommission replica misses versions (last failed version > 0), it will cause a bug:
So if it continue to load data, its rowset will increase util it cause error -235(TOO MANY VERSION).
Fix: don't write data to the decommission replica if it miss rowsets.