[fix](cloud-schema-change) Write schema change jobs to a deserialized pb buffer rather than a new one #38210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Collaborator
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
w41ter
previously approved these changes
Jul 22, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
luwei16
reviewed
Jul 22, 2024
Hastyshell
force-pushed
the
fix-ms-compaction-job-lose
branch
from
2606648 to
7150356
Compare
Collaborator
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Hastyshell
force-pushed
the
fix-ms-compaction-job-lose
branch
from
7150356 to
b33f8cc
Compare
Collaborator
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Hastyshell
force-pushed
the
fix-ms-compaction-job-lose
branch
from
b33f8cc to
dd5ee0f
Compare
Collaborator
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Hastyshell
force-pushed
the
fix-ms-compaction-job-lose
branch
from
dd5ee0f to
0976ef6
Compare
Collaborator
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
…pb buffer rather than a new one
Hastyshell
force-pushed
the
fix-ms-compaction-job-lose
branch
from
0976ef6 to
169e3fc
Compare
Collaborator
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Collaborator
Author
|
run cloud p1 |
luwei16
approved these changes
Jul 25, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Jul 27, 2024
… pb buffer rather than a new one (#38210) ## Proposed changes Currently, when starting a schema change job, job info will be persists in an new created protobuf struct rather than the original stored one, which will lead to compation job losing and result in `failed to lease compaction job`. Therefore, write the newly created schema job info into the deserialized proto buffer of the original job info to fix the job info lose.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Currently, when starting a schema change job, job info will be persists in an new created protobuf struct rather than the original stored one, which will lead to compation job losing and result in
failed to lease compaction job.Therefore, write the newly created schema job info into the deserialized proto buffer of the original job info to fix the job info lose.