Skip to content

FIX: remove unused_import, this caused fe compile failed #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stalary wants to merge 1 commit into from
Closed

FIX: remove unused_import, this caused fe compile failed #3825

stalary wants to merge 1 commit into from

Conversation

@stalary
Copy link
Contributor

@stalary stalary commented Jun 11, 2020

remove unused_import, this caused fe compile failed

imay
imay approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay added approved Indicates a PR has been approved by one committer. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 11, 2020
@morningman
Copy link
Contributor

morningman commented Jun 11, 2020

Hi @stalary , thank u for your PR, but this bug has been fixed in #3826.
So I will close this PR.

@morningman morningman closed this Jun 11, 2020
@stalary stalary deleted the unused_import branch July 19, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imay imay imay approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stalary @morningman @imay