Skip to content

[fix](compaction) fix the issue of writing segment with 0 rows during compaction #38251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 3 commits into from
Jul 24, 2024
Merged

[fix](compaction) fix the issue of writing segment with 0 rows during compaction #38251

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45437d5
[fix](compaction) fix the issue of writing segment with 0 rows during…
luwei16 Jul 23, 2024
346d7c0
fix
luwei16 Jul 23, 2024
e2bb50b
fix code style
luwei16 Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions be/src/olap/rowset/vertical_beta_rowset_writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ Status VerticalBetaRowsetWriter<T>::add_columns(const vectorized::Block* block,
VLOG_NOTICE << "num_rows_written: " << num_rows_written
<< ", _cur_writer_idx: " << _cur_writer_idx;
uint32_t num_rows_key_group = _segment_writers[_cur_writer_idx]->row_count();
CHECK_LE(num_rows_written, num_rows_key_group);
CHECK_LT(num_rows_written, num_rows_key_group);
// init if it's first value column write in current segment
if (num_rows_written == 0) {
VLOG_NOTICE << "init first value column segment writer";
Expand All @@ -104,7 +104,8 @@ Status VerticalBetaRowsetWriter<T>::add_columns(const vectorized::Block* block,
left -= to_write;
CHECK_GE(left, 0);

if (left > 0) {
if (num_rows_key_group == num_rows_written + to_write &&
_cur_writer_idx < _segment_writers.size() - 1) {
++_cur_writer_idx;
}
}
Expand Down