[opt](catalog) merge scan range to avoid too many splits #38311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| LOG(INFO) << "Merge " << scan_ranges.size() << " scan ranges to " << _scan_ranges.size(); | ||
| } | ||
|
|
||
| protected: |
Contributor
There was a problem hiding this comment.
warning: redundant access specifier has the same accessibility as the previous access specifier [readability-redundant-access-specifiers]
Suggested change
| protected: |
Additional context
be/src/vec/exec/scan/split_source_connector.h:46: previously declared here
protected:
^
Contributor
Author
|
run buildall |
1 similar comment
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41631 ms |
TPC-DS: Total hot run time: 169742 ms |
ClickBench: Total hot run time: 30.52 s |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41571 ms |
TPC-DS: Total hot run time: 169772 ms |
ClickBench: Total hot run time: 29.73 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41714 ms |
TPC-DS: Total hot run time: 169578 ms |
ClickBench: Total hot run time: 30.13 s |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
morningman
added a commit
to morningman/doris
that referenced
this pull request
Aug 6, 2024
PR apache#34032 introduce a new method to get splits batch by batch, but it removed a logic that BE will merge scan ranges to avoid too many scan ranges being scheduled. This PR mainly changes: 1. Add scan range merging logic back. 2. Change the default file split size from 8MB to 64MB, to avoid too many small split.
morningman
added a commit
that referenced
this pull request
Aug 6, 2024
dataroaring
added
dev/3.0.1-merged
dev/3.0.x-conflict
and removed
dev/3.0.1-merged
labels
dataroaring
pushed a commit
that referenced
this pull request
Aug 11, 2024
PR #34032 introduce a new method to get splits batch by batch, but it removed a logic that BE will merge scan ranges to avoid too many scan ranges being scheduled. This PR mainly changes: 1. Add scan range merging logic back. 2. Change the default file split size from 8MB to 64MB, to avoid too many small split.
morningman
added a commit
to morningman/doris
that referenced
this pull request
Aug 12, 2024
dataroaring
pushed a commit
that referenced
this pull request
Aug 16, 2024
PR #34032 introduce a new method to get splits batch by batch, but it removed a logic that BE will merge scan ranges to avoid too many scan ranges being scheduled. This PR mainly changes: 1. Add scan range merging logic back. 2. Change the default file split size from 8MB to 64MB, to avoid too many small split.
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #34032 introduce a new method to get splits batch by batch,
but it removed a logic that BE will merge scan ranges to avoid too many scan ranges being scheduled.
This PR mainly changes: