Skip to content

[fix](group commit) Pick some group commit pr #38320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 3 commits into from
Jul 25, 2024
Merged

[fix](group commit) Pick some group commit pr #38320

dataroaring merged 3 commits into from
Jul 25, 2024

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Jul 24, 2024 •
edited
Loading

Pick #38292, #34021, #38228, some modify of #37260, some modify of #37595

@mymeiyi
[fix](group commit) group commit show error url (apache#38292)
64f1f0b 
`insert into` in group commit should show error url if some rows are
invalid.
@doris-robot
Copy link

doris-robot commented Jul 24, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@mymeiyi mymeiyi changed the title [fix](group commit) group commit show error url (#38292) [fix](group commit) Pick group commit show error url (#38292) Jul 24, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jul 24, 2024

clang-tidy review says "All clean, LGTM! 👍"

@dataroaring
Copy link
Contributor

dataroaring commented Jul 25, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jul 25, 2024

TeamCity be ut coverage result:
Function Coverage: 36.47% (9243/25345)
Line Coverage: 28.00% (75552/269869)
Region Coverage: 26.82% (38852/144858)
Branch Coverage: 23.56% (19731/83736)
Coverage Report: http://coverage.selectdb-in.cc/coverage/64f1f0b89a3108b4f1f2e56307585747391a7d98_64f1f0b89a3108b4f1f2e56307585747391a7d98/report/index.html

@mymeiyi mymeiyi changed the title [fix](group commit) Pick group commit show error url (#38292) [fix](group commit) Pick some group commit pr Jul 25, 2024
@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 25, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2024

clang-tidy review says "All clean, LGTM! 👍"

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 25, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 25, 2024

TeamCity be ut coverage result:
Function Coverage: 36.48% (9246/25345)
Line Coverage: 28.01% (75593/269923)
Region Coverage: 26.81% (38849/144880)
Branch Coverage: 23.54% (19718/83748)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8502120ca171a264078bbd64e664414d0370f972_8502120ca171a264078bbd64e664414d0370f972/report/index.html

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 25, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented Jul 25, 2024

TeamCity be ut coverage result:
Function Coverage: 36.44% (9254/25398)
Line Coverage: 28.00% (75644/270191)
Region Coverage: 26.81% (38878/145023)
Branch Coverage: 23.54% (19731/83808)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c65a8ccd4284eb7473106b27b3391dffe7878073_c65a8ccd4284eb7473106b27b3391dffe7878073/report/index.html

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 25, 2024

run feut

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jul 25, 2024

run fe_ut

@dataroaring dataroaring merged commit 91f0301 into apache:branch-2.1 Jul 25, 2024
@mymeiyi mymeiyi deleted the pick-38292 branch September 10, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

meta-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mymeiyi @doris-robot @dataroaring