[cherry-pick](branch-2.1) Fix some group commit forward to master problems #38345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Proposed changes <!--Describe your changes.--> When client connect to observer and do group commit, observer will forward to master. The forward parameter `GroupCommitInfo` maybe null, which leads to an exception.
…ache#38265) ## Proposed changes <!--Describe your changes.--> The error message is: 2024-07-23 17:30:09.300 INFO [suite-thread-1] (StreamLoadAction.groovy:201) - Stream load elapsed 2050 ms, is http stream: true, response: nulljava.lang.IllegalStateException: Expect frontend stream load response code is 307, but meet 200 body: {"status":"FAILED","msg":"errCode = 2, detailMessage = Required field 'user' was not present! Struct: TMasterOpRequest(user:null, db:, sql:, clientNodeHost:172.20.48.85, clientNodePort:9010, groupCommitInfo:TGroupCommitInfo(getGroupCommitLoadBeId:true, groupCommitLoadTableId:10321, isCloud:false))"} The forward param `TMasterOpRequest`(FrontendService.thrift) has a required field `user`, which get from ConnectContext. So we set admin_user to ConnectContext to solve this problem.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Collaborator
Author
|
run buildall |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Pick #38228 #38265